Removed getPlainTextLength

[devr0306]

Summary

Removed getPlainTextLength as it was inconsistent with ink.

Details

Removed getPlainTextLength and the test file corresponding to it

Related Issues

Fixes #18748

How to Validate

Run all tests and make sure nothing fails

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @devr0306, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the InlineMarkdownRenderer by removing the getPlainTextLength utility function. This function was identified as inconsistent with the ink library's rendering logic, and its removal simplifies the codebase and ensures better alignment with the intended display behavior. The associated test file has also been removed.

Highlights

• Function Removal: The getPlainTextLength utility function has been removed from InlineMarkdownRenderer.tsx.
• Test File Deletion: The corresponding test file InlineMarkdownRenderer.test.ts for getPlainTextLength has been deleted.
• Consistency Improvement: This removal addresses inconsistencies with the ink library's text rendering behavior.

Changelog

• packages/cli/src/ui/utils/InlineMarkdownRenderer.test.ts
  • Removed the entire test file for getPlainTextLength.
• packages/cli/src/ui/utils/InlineMarkdownRenderer.tsx
  • Removed the stringWidth import.
  • Deleted the getPlainTextLength function and its associated JSDoc.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully removes the getPlainTextLength function and its associated tests, addressing an inconsistent utility and eliminating the unused string-width dependency. These clean and well-contained changes enhance the consistency of text handling within the UI components.

[github-actions]

Size Change: -2 B (0%)

Total Size: 24.3 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	24.3 MB	-2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}

[jacob314]