Skip to content

Comments

fix(workflows): improve maintainer detection for automated PR actions#18869

Merged
bdmorgan merged 5 commits intomainfrom
fix/maintainer-pr-closure
Feb 12, 2026
Merged

fix(workflows): improve maintainer detection for automated PR actions#18869
bdmorgan merged 5 commits intomainfrom
fix/maintainer-pr-closure

Conversation

@bdmorgan
Copy link
Collaborator

Summary

This PR improves the maintainer detection logic in the .github/workflows/gemini-scheduled-stale-pr-closer.yml and .github/workflows/pr-contribution-guidelines-notifier.yml workflows. It addresses an issue where PRs from maintainers (specifically Googlers or members of other maintainer teams) were being incorrectly identified as community contributions and, in some cases, automatically closed.

Details

  • Expanded Team Verification: Added gemini-cli-askmode-approvers and gemini-cli-docs to the list of teams checked for maintainer status in the stale PR closer.
  • Googler Verification: Implemented a check for membership in the googlers or google organizations. This ensures that PR authors from the core team are correctly identified as maintainers even if they aren't explicitly in a specific repository-level team.
  • Asynchronous Logic: Updated the isMaintainer function in the stale PR closer to be asynchronous and properly handled await across its usage.
  • Consistency: Applied similar Googler verification logic to the pr-contribution-guidelines-notifier.yml workflow to prevent sending unnecessary contribution guideline notifications to internal team members.

Related Issues

None (reported via chat).

How to Validate

Since these are GitHub Actions workflows, validation involves observing the workflow execution on GitHub:

  1. Trigger the Gemini Scheduled Stale PR Closer workflow manually or via a PR edit.
  2. Verify that PRs from members of the newly added teams or Googlers are correctly identified as maintainer PRs in the logs.
  3. Verify that these PRs are no longer closed for missing linked issues.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

Updated the PR closer to check multiple maintainer teams and verify Googler status.
This prevents incorrectly closing PRs from maintainers who may not be in the primary maintainers team but are Googlers or members of other relevant teams.
Added Googler status verification to the PR guidelines notifier to prevent
sending unnecessary notifications to maintainers who are Googlers.
@bdmorgan bdmorgan requested a review from a team as a code owner February 12, 2026 01:15
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Size Change: -2 B (0%)

Total Size: 24.3 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 24.3 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 12, 2026
@bdmorgan bdmorgan merged commit a1148ea into main Feb 12, 2026
27 checks passed
@bdmorgan bdmorgan deleted the fix/maintainer-pr-closure branch February 12, 2026 01:56
krsjenmt added a commit to krsjenmt/gemini-cli that referenced this pull request Feb 12, 2026
…ini/gemini-cli (#37)

* fix(cli): resolve double rendering in shpool and address vscode lint warnings (google-gemini#18704)

* feat(plan): document and validate Plan Mode policy overrides (google-gemini#18825)

* Fix pressing any key to exit select mode. (google-gemini#18421)

* fix(cli): update F12 behavior to only open drawer if browser fails (google-gemini#18829)

* feat(plan): allow skills to be enabled in plan mode (google-gemini#18817)

Co-authored-by: Jerop Kipruto <jerop@google.com>

* docs(plan): add documentation for plan mode tools (google-gemini#18827)

* Remove experimental note in extension settings docs (google-gemini#18822)

* Update prompt and grep tool definition to limit context size (google-gemini#18780)

* docs(plan): add `ask_user` tool documentation (google-gemini#18830)

* Revert unintended credentials exposure (google-gemini#18840)

* feat(core): update internal utility models to Gemini 3 (google-gemini#18773)

* feat(a2a): add value-resolver for auth credential resolution (google-gemini#18653)

* Removed getPlainTextLength (google-gemini#18848)

* More grep prompt tweaks (google-gemini#18846)

* refactor(cli): Reactive useSettingsStore hook (google-gemini#14915)

* fix(mcp): Ensure that stdio MCP server execution has the `GEMINI_CLI=1` env variable populated. (google-gemini#18832)

* fix(core): improve headless mode detection for flags and query args (google-gemini#18855)

* refactor(cli): simplify UI and remove legacy inline tool confirmation logic (google-gemini#18566)

* feat(cli): deprecate --allowed-tools and excludeTools in favor of policy engine (google-gemini#18508)

* fix(workflows): improve maintainer detection for automated PR actions (google-gemini#18869)

* refactor(cli): consolidate useToolScheduler and delete legacy implementation (google-gemini#18567)

* Update changelog for v0.28.0 and v0.29.0-preview0 (google-gemini#18819)

* fix(core): ensure sub-agents are registered regardless of tools.allowed (google-gemini#18870)

---------

Co-authored-by: Brad Dux <959674+braddux@users.noreply.github.com>
Co-authored-by: Jerop Kipruto <jerop@google.com>
Co-authored-by: Jacob Richman <jacob314@gmail.com>
Co-authored-by: Sandy Tao <sandytao520@icloud.com>
Co-authored-by: Adib234 <30782825+Adib234@users.noreply.github.com>
Co-authored-by: christine betts <chrstn@uw.edu>
Co-authored-by: Christian Gunderman <gundermanc@gmail.com>
Co-authored-by: Adam Weidman <65992621+adamfweidman@users.noreply.github.com>
Co-authored-by: Dev Randalpura <devrandalpura@google.com>
Co-authored-by: Pyush Sinha <pyushsinha20@gmail.com>
Co-authored-by: Richie Foreman <richie.foreman@gmail.com>
Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Co-authored-by: Abhi <43648792+abhipatel12@users.noreply.github.com>
Co-authored-by: Abhijit Balaji <abhijitbalaji@google.com>
Co-authored-by: Bryan Morgan <bryanmorgan@google.com>
Co-authored-by: g-samroberts <158088236+g-samroberts@users.noreply.github.com>
Co-authored-by: matt korwel <matt.korwel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant