Backport of added imagePullPolicy for images in values.yaml into release/1.2.x #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Went through old PRs to make sure they were in the list. - Removed beta sections.
On a non-default partition with ACLs and peering and partitions are all enabled. add a condition to the partition_prefix rule to avoid this error: ``` Failure: creating mesh-gateway-policy policy: err="Unexpected response code: 500 (rpc error making call: Invalid policy rules: partitioned policy cannot use partition_prefix rules)" ```
* Update readme for 1.0 GA
- use ubuntu based image for static-client in acceptance tests because alpine images are known to be flakey with DNS on kubernetes: https://stackoverflow.com/questions/65181012/does-alpine-have-known-dns-issue-within-kubernetes - Fix ACL permissions for the connect injector to make wan federations tests pass. Previously, injector only needed the global auth method when namespaces are enabled. Now that we've joined it with the controller, it needs global auth method in the secondary all the time. - Fix debug info from envoy (previously we were assuming there's consul-sidecar). This change also adds debugging info to all pods that use envoy. Co-authored-by: Nitya Dhanushkodi <nitya@hashicorp.com> Co-authored-by: Ashwin Venkatesh <ashwin.what@gmail.com>
Add fix for api-gateway when using system-wide trusted CAs for external servers
…aml (#1740) * remove controller webhook cert roles from vault test and the values.yaml
* add discover binary to control-plane image
- fixed changelog
#1756) * Add support for setting the namespace that the CNI plugin is installed into
* Fix name of autoencrypt cert * Update BATS * Update CHANGELOG * Remove HOST_IP * Don't mount consul-ca-cert when using system roots and external servers * Remove timeout and partition flags' * Don't mount consul-ca-cert when using system roots and external servers on main container
Mount certs when using clients even with external servers
* Remove controller from preset values file in CLI
* Update to consuls latest versions * go mod tidy
* Add global.extraLabels values.yaml setting This setting lets you apply a set of labels to all pods created by the consul-k8s helm chart. * Also apply global extra labels to deployments/daemonsets/statefulsets/jobs * Add global extraLabels to sync catalog deployment
Co-authored-by: Alvin Huang <17609145+alvin-huang@users.noreply.github.com>
* update changelog files * update for release 1.2-rc1 * fix RateLimitIPConfig tests * pinning version temporarily for testing
Add rc1
hc-github-team-consul-core
force-pushed
the
backport/aahel/added-imagPullPolicy/literally-helped-hippo
branch
from
3aa4569
to
0779d1d
Compare
hc-github-team-consul-core
force-pushed
the
backport/aahel/added-imagPullPolicy/literally-helped-hippo
branch
from
0779d1d
to
3aa4569
Compare
|
|
aahel
approved these changes
Jun 13, 2023
|
@aahel Looks like this requires a manual git cherry-pick from the original git merge commit. |
aahel
approved these changes
Jun 14, 2023
|
@thisisnotashwin |
|
@aahel in this case, you copuld close this PR, and create another one yourself. you can still use the same PR i think but use |
* added imagePullPolicy for images in values.yaml * fix: renamed pullPolicy key according to image * fixed dafault always in tmpl * changed structure of image in yaml * revert changes * added global imagePullPolicy * fixed typo * added changelog file
aahel
force-pushed
the
backport/aahel/added-imagPullPolicy/literally-helped-hippo
branch
from
0b71c5c
to
c370f60
Compare
aahel
deleted the
backport/aahel/added-imagPullPolicy/literally-helped-hippo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2310 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
🚨
The person who merged in the original PR is:
@aahel
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
How I've tested this PR:
rendered helm template and test by passing different values of imagePullPolicy
How I expect reviewers to test this PR:
eg:-
cd charts/consul
helm template
-s templates/api-gateway-controller-deployment.yaml
--set 'apiGateway.enabled=true'
--set 'global.imagePullPolicy="Always"'
--set 'apiGateway.image=bar'
--set 'global.enableConsulNamespaces=true'
. | tee /dev/stderr
Checklist:
Overview of commits