Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dirty] d/aws_s3_bucket: get default encryption configuration #2300

Closed
wants to merge 275 commits into from
Closed

[dirty] d/aws_s3_bucket: get default encryption configuration #2300

wants to merge 275 commits into from

Conversation

trung
Copy link
Contributor

@trung trung commented Nov 15, 2017 •
edited
Loading

Fix #2217 and #2196

  • Modify aws_s3_bucket data source
  • Add acceptance tests
  • Write documentation

@radeksimko radeksimko added new-data-source Introduces a new data source. enhancement Requests to existing resources that expand the functionality or scope. and removed new-data-source Introduces a new data source. labels Nov 15, 2017
@radeksimko
Merge pull request hashicorp#2301 from jurajseffer/codebuild_ip_range
230fe59 
Docs: Added codebuild as a possible service name for aws_ip_ranges
@radeksimko radeksimko added the size/M Managed by automation to categorize the size of a PR. label Nov 15, 2017
radeksimko and others added 15 commits November 15, 2017 13:07
@radeksimko
Merge pull request hashicorp#2207 from bflad/ec2-iam-role-permissions
2e52315 
Additional EC2 instance resource documentation surrounding iam_instance_profile permissions
@radeksimko
Merge pull request hashicorp#2250 from pdecat/patch-1
04b31ad 
Explicitely state that updates to instance_type field will trigger a stop/start of the EC2 instance
@radeksimko
Merge pull request hashicorp#2262 from seriousben/support-update-cf-s…
84dcbf9 
…tack-tags

resource/aws_cloudformation_stack: Support updating tags
@radeksimko
Update CHANGELOG.md
036a42e
@bflad @radeksimko
Adjust aws_dynamodb_table CreateTable LimitExceededException handling…
22b2c68 
… for different error messaging (hashicorp#2274)

* Adjust aws_dynamodb_table CreateTable LimitExceededException handling for different error messaging

* hashicorp#2274 review: r/aws_dynamodb_table: Update LimitExceededException retry message handling
@radeksimko
Update CHANGELOG.md
93b7cbc
@bflad @radeksimko
Add arn attribute to aws_elb resource (hashicorp#2272)
7960eea 
* Add arn attribute to aws_elb resource

* hashicorp#2272 review: r/aws_elb: Remove Optional from arn attribute
@radeksimko
Update CHANGELOG.md
c303d11
@bflad @radeksimko
Add arn attribute to aws_ebs_volume resource and datasource (hashicor…
d7b303e 
…p#2271)

* Add arn attribute to aws_ebs_volume resource and datasource

* hashicorp#2271 PR review: d/aws_ebs_volume and r/aws_ebs_volume: remove Optional from arn attribute and reduce full meta interface usage
@radeksimko
Update CHANGELOG.md
7c14a34
@radeksimko
New Data Source: aws_instances
ccf26c7
@radeksimko
Merge pull request hashicorp#2266 from terraform-providers/f-d-instances
b6b32d5 
New Data Source: aws_instances
@radeksimko
Update CHANGELOG.md
b59fa96
@trung
hashicorp#2217: added acceptance test for basic case
d7658da
@trung
hashicorp#2217: documentation
6a2fdd9
@trung trung changed the title [WIP] d/aws_s3_bucket: get default encryption configuration d/aws_s3_bucket: get default encryption configuration Nov 16, 2017
radeksimko and others added 8 commits November 16, 2017 09:09
@radeksimko
t/lb_target_group: Add missing matcher in acc test
0f72ca7 
We no longer set default matcher b/c there's no matcher for network LBs
@radeksimko
t/ecr_lifecycle_policy: Randomize repo name
a56feae
@shibataka000
Fix bug that not waiting batch_job_queue deleted.
51651a5 
Deleting compute environment with job queue failed because of this.
@catsby
r/aws_lb: mark subnets as ForceNew for network load balancers (hashic…
cf42ac1 
…orp#2310)

* Add test verifying broken subnet setting for aws_lb

- subnets can't be updated for lbs of type `network`
- the `UPDATE` method tries to update the `subnets`, which fails, even
on first apply

* fix ordering

* Mark Subnets as forcenew for network load balancers
@catsby
Update CHANGELOG.md
db3c17e
@darend
Update acceptance test with new attributes
b4d7dd7
@radeksimko
r/lb+elb: Suppress diff for LBs w/ empty name (hashicorp#2314)
33df43f 
* r/lb+elb: Suppress diff for LBs w/ empty name

* Add explanatory comments
@radeksimko
Make acceptance test more thorough
aab14f9
Puneeth-n and others added 12 commits December 16, 2017 23:55
@trung
Copy link
Contributor Author

trung commented Dec 17, 2017

as #2472 has been closed, i'll write additional test for this PR

@trung
Copy link
Contributor Author

trung commented Dec 17, 2017

Done!

❯ make testacc TESTARGS="-run=TestAccDataSourceS3Bucket_*"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccDataSourceS3Bucket_* -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccDataSourceS3Bucket_basic
--- PASS: TestAccDataSourceS3Bucket_basic (36.01s)
=== RUN   TestAccDataSourceS3Bucket_website
--- PASS: TestAccDataSourceS3Bucket_website (35.32s)
=== RUN   TestAccDataSourceS3Bucket_whenDefaultEncryptionNotEnabled
--- PASS: TestAccDataSourceS3Bucket_whenDefaultEncryptionNotEnabled (32.70s)
=== RUN   TestAccDataSourceS3Bucket_whenDefaultEncryptionEnabledWithAES256
--- PASS: TestAccDataSourceS3Bucket_whenDefaultEncryptionEnabledWithAES256 (34.60s)
=== RUN   TestAccDataSourceS3Bucket_whenDefaultEncryptionEnabledWithAWSKMS
--- PASS: TestAccDataSourceS3Bucket_whenDefaultEncryptionEnabledWithAWSKMS (64.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	202.787s

@radeksimko
Copy link
Member

Hi @trung
do you mind resolving conflicts and cleaning up the git log?

Thanks.

@radeksimko radeksimko added the waiting-response Maintainers are waiting on response from community or contributor. label Jan 12, 2018
@trung
Copy link
Contributor Author

trung commented Jan 12, 2018

sorry for the mess, i'll clean it up and submit a new PR.

@trung
Copy link
Contributor Author

trung commented Jan 17, 2018

Closed this to raise another one

@trung trung closed this Jan 17, 2018
@trung trung changed the title d/aws_s3_bucket: get default encryption configuration [dirty] d/aws_s3_bucket: get default encryption configuration Jan 17, 2018
@trung trung mentioned this pull request Jan 17, 2018
Closed
@trung trung deleted the f-d-2217 branch January 17, 2018 03:19
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnjelinek johnjelinek johnjelinek approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: New S3 encryption support