Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoped token access #441

Merged
merged 36 commits into from
May 19, 2023
Merged

Scoped token access #441

merged 36 commits into from
May 19, 2023

Conversation

TomNorth
Copy link
Contributor

This PR is to address #352

Optionally sets vault_token output to the action, so that we can use it in our workflows after authenticating in a scoped fashion.

Apologies I borked my fork while working on #353 while doing the requested changes and accidentally close the PR.

This is a PR with the required changes and tests updated to reflect. I've since moved on from my previous employer and no longer use Vault, but I suppose this might still be handy for others.

Thomas and others added 30 commits August 3, 2022 15:02
feat: Always allow scoped access to vault token through outputs
e92c090
Make optional instead of always, in case of untrusted steps
f93ffc6
@benashz @TomNorth
Update jira sync (hashicorp#354)
2ece997
@vinay-gopalan @TomNorth
Update to v2.4.2 (hashicorp#357)
e80ba87
@prizov @TomNorth
use node16 in action.yml (hashicorp#375)
abcf1af
@dependabot @TomNorth
chore(deps-dev): bump @actions/core from 1.9.0 to 1.10.0 (hashicorp#371)
0ee99d2 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tvoran @TomNorth
jira-sync: update the team to applications (hashicorp#380)
ed25dde
@vinay-gopalan @TomNorth
update changelog (hashicorp#386)
60afd37
@tvoran @TomNorth
change example to vault-action@v2 (hashicorp#391)
bd146e6 
so we don't have to keep remembering to update the version tag in the
readme.
@dependabot @TomNorth
chore(deps): bump jsrsasign from 10.5.25 to 10.5.27 (hashicorp#358)
392e105 
Bumps [jsrsasign](https://github.com/kjur/jsrsasign) from 10.5.25 to 10.5.27.
- [Release notes](https://github.com/kjur/jsrsasign/releases)
- [Changelog](https://github.com/kjur/jsrsasign/blob/master/ChangeLog.txt)
- [Commits](kjur/jsrsasign@10.5.25...10.5.27)

---
updated-dependencies:
- dependency-name: jsrsasign
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @TomNorth
chore(deps-dev): bump semantic-release from 19.0.3 to 19.0.5 (hashico…
7e6c495 
…rp#360)

Bumps [semantic-release](https://github.com/semantic-release/semantic-release) from 19.0.3 to 19.0.5.
- [Release notes](https://github.com/semantic-release/semantic-release/releases)
- [Commits](semantic-release/semantic-release@v19.0.3...v19.0.5)

---
updated-dependencies:
- dependency-name: semantic-release
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @TomNorth
chore(deps-dev): bump jest-when from 3.5.1 to 3.5.2 (hashicorp#388)
43ffcb5 
Bumps [jest-when](https://github.com/timkindberg/jest-when) from 3.5.1 to 3.5.2.
- [Release notes](https://github.com/timkindberg/jest-when/releases)
- [Commits](timkindberg/jest-when@v3.5.1...v3.5.2)

---
updated-dependencies:
- dependency-name: jest-when
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@austingebauer @TomNorth
Update to v2.4.3 (hashicorp#395)
9bd8f6d
@ltcarbonell @TomNorth
Add Decoding to Secrets (hashicorp#408)
2552fe6 
* Add decoding to secrets

* remove index.js

* Add test case, and other updates
@dependabot @TomNorth
chore(deps-dev): bump jest and @types/jest (hashicorp#397)
12b0f47 
Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) and [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest). These dependencies needed to be updated together.

Updates `jest` from 28.1.1 to 29.3.1
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v29.3.1/packages/jest)

Updates `@types/jest` from 28.1.3 to 29.2.2
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

---
updated-dependencies:
- dependency-name: jest
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: "@types/jest"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @TomNorth
chore(deps): bump jsrsasign from 10.5.27 to 10.6.1 (hashicorp#401)
0fb5e2f 
Bumps [jsrsasign](https://github.com/kjur/jsrsasign) from 10.5.27 to 10.6.1.
- [Release notes](https://github.com/kjur/jsrsasign/releases)
- [Changelog](https://github.com/kjur/jsrsasign/blob/master/ChangeLog.txt)
- [Commits](kjur/jsrsasign@10.5.27...10.6.1)

---
updated-dependencies:
- dependency-name: jsrsasign
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @TomNorth
chore(deps): bump json5 from 2.2.1 to 2.2.3 (hashicorp#404)
dc840fd 
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @TomNorth
chore(deps): bump minimatch from 3.0.4 to 3.1.2 (hashicorp#410)
2e2fe25 
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kevinschoonover @austingebauer @TomNorth
print vault error message on authentication failure (hashicorp#409)
3e5da66 
Co-authored-by: Austin Gebauer <34121980+austingebauer@users.noreply.github.com>
@dependabot @TomNorth
chore(deps-dev): bump @types/jest from 29.2.2 to 29.2.6 (hashicorp#413)
a3c66b0 
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 29.2.2 to 29.2.6.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

---
updated-dependencies:
- dependency-name: "@types/jest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @TomNorth
chore(deps-dev): bump semantic-release from 19.0.5 to 20.0.4 (hashico…
bd96e45 
…rp#415)

Bumps [semantic-release](https://github.com/semantic-release/semantic-release) from 19.0.5 to 20.0.4.
- [Release notes](https://github.com/semantic-release/semantic-release/releases)
- [Commits](semantic-release/semantic-release@v19.0.5...v20.0.4)

---
updated-dependencies:
- dependency-name: semantic-release
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@austingebauer @TomNorth
Removes unused devDependencies from package.json (hashicorp#416)
ffdc17b 
* Removes unused devDependencies from package.json

* Removes release section of package.json
@austingebauer @TomNorth
Update to v2.5.0 (hashicorp#419)
1cdca67
@dependabot @maxcoulombe @TomNorth
chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (hashicorp…
d004239 
…#422)

* chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1

Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* * built change

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: maxcoulombe <max.coulombe@hashicorp.com>
@dependabot @TomNorth
chore(deps-dev): bump jest from 29.3.1 to 29.4.3 (hashicorp#425)
1af2979 
Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) from 29.3.1 to 29.4.3.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v29.4.3/packages/jest)

---
updated-dependencies:
- dependency-name: jest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @TomNorth
chore(deps-dev): bump @vercel/ncc from 0.36.0 to 0.36.1 (hashicorp#417)
64a5662 
Bumps [@vercel/ncc](https://github.com/vercel/ncc) from 0.36.0 to 0.36.1.
- [Release notes](https://github.com/vercel/ncc/releases)
- [Commits](vercel/ncc@0.36.0...0.36.1)

---
updated-dependencies:
- dependency-name: "@vercel/ncc"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @maxcoulombe @TomNorth
chore(deps): bump jsonata from 1.8.6 to 2.0.2 (hashicorp#426)
ffb39fb 
* chore(deps): bump jsonata from 1.8.6 to 2.0.2

Bumps [jsonata](https://github.com/jsonata-js/jsonata) from 1.8.6 to 2.0.2.
- [Release notes](https://github.com/jsonata-js/jsonata/releases)
- [Changelog](https://github.com/jsonata-js/jsonata/blob/master/CHANGELOG.md)
- [Commits](jsonata-js/jsonata@v1.8.6...v2.0.2)

---
updated-dependencies:
- dependency-name: jsonata
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* * waiting for result of evaluate to account for jsonata v2 changes

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: maxcoulombe <max.coulombe@hashicorp.com>
@maxcoulombe @TomNorth
Development flow enhancements (hashicorp#430)
1b1f02e 
+ added a contribution section to the readme
+ added a local workflow to test changes
+ made the vault token configurable for tests
* bumped action/checkout
@mldahl @TomNorth
handle undefined response in getSecrets error handler (hashicorp#431)
e5f1a49
@maxcoulombe @TomNorth
Enhanced "Example Usage" section (hashicorp#435)
fc1e2ce 
+added documentation on how to use the retrieved secrets
+ added an example of converting the vault-action outputs to json
* fix e2e test setup
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 25, 2023 •
edited by hashicorp-cla-app bot
Loading

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

10 out of 11 committers have signed the CLA.

  • tvoran
  • benashz
  • austingebauer
  • prizov
  • vinay-gopalan
  • maxcoulombe
  • mldahl
  • kevinschoonover
  • ltcarbonell
  • TomNorth
  • Thomas

Thomas seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@maxcoulombe maxcoulombe mentioned this pull request May 19, 2023
Closed
@maxcoulombe
Copy link
Contributor

Small note, we are merging this PR even if the CLA is not completely signed with the understanding that Thomas is a user that no longer exists thus cannot sign it and all their commits are done in the name of TomNorth who is the same person as mentioned in the comment from the original issue found here.

Thanks for this contribution!

@maxcoulombe maxcoulombe merged commit cd5a899 into hashicorp:main May 19, 2023
@maxcoulombe maxcoulombe mentioned this pull request May 26, 2023
Closed
@andreaso andreaso mentioned this pull request Jun 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcoulombe maxcoulombe maxcoulombe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.