Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from CLV Study #91

Draft
wants to merge 10 commits into
base: vinitha/firebase
Choose a base branch
from
Draft

Changes from CLV Study #91

wants to merge 10 commits into from

Conversation

hello-amal
Copy link
Collaborator

Description

Eventually, we should merge all these changes into master. Some that may require additional work include:

  • Just like in click-to-pregrasp we rotate the yaw first and then the pitch+roll when deploying the wrist, we should consider adding that to the web app for "center wrist."
  • As opposed to hardcoding gTTS audio to 400%, we should add it to the configuration of the engine (and, hence, the ROS message), just like is_slow or voice_id. This change should also be mirrored in stretchpy#61 and stretch_ai#57

Testing procedure

Before opening a pull request

From the top-level of this repository, run:

  • pre-commit run --all-files

To merge

  • Squash & Merge

@hello-amal hello-amal marked this pull request as draft August 1, 2024 15:13
@hello-amal hello-amal force-pushed the studies/clv branch 2 times, most recently from a3ae2f5 to 34b8b85 Compare August 2, 2024 22:50
@hello-amal hello-amal changed the base branch from master to vinitha/firebase August 6, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant