Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/sentry] Support loadBalancerSourceRanges on Service template #13665

Merged
merged 12 commits into from
Jun 1, 2019
Merged

[stable/sentry] Support loadBalancerSourceRanges on Service template #13665

merged 12 commits into from
Jun 1, 2019

Conversation

wvidana
Copy link
Collaborator

@wvidana wvidana commented May 9, 2019 •
edited
Loading

What this PR does / why we need it:

Support loadBalancerSourceRanges on Service template.

Needed for people that want to restrict network access to their on-prem Sentry.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

wvidana added 3 commits May 9, 2019 13:46
@wvidana
Support loadBalancerSourceRanges on Service
d555c06 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Chart version bump
86209bc 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Adding default values and README
940f3e2 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @wvidana. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2019
@wvidana
Copy link
Collaborator Author

wvidana commented May 9, 2019

On a second thought maybe we don't want the variable default in here https://github.com/helm/charts/pull/13665/files#diff-14be7de4a18363a90b2ca1ecb9dfe3f4R108

That way we can avoid the whole block if not provided (backwards compatible)

@wvidana
Revert "Adding default values and README"
6dbb7ed 
This reverts commit 940f3e2.

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Copy link
Collaborator Author

wvidana commented May 10, 2019

/assign @sameersbn

@wvidana
Copy link
Collaborator Author

wvidana commented May 15, 2019

/assign @davidkarlsen

@wvidana
Copy link
Collaborator Author

wvidana commented May 16, 2019

@sameersbn can you please review?

@davidkarlsen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2019
@wvidana
Copy link
Collaborator Author

wvidana commented May 20, 2019

/retest

@wvidana
Copy link
Collaborator Author

wvidana commented May 20, 2019

/test pull-charts-e2e

wvidana added 2 commits May 20, 2019 13:29
@wvidana
Version bump
3954344 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Merge branch 'master' into sentry
a5e6ad0 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 20, 2019
wvidana added 2 commits May 20, 2019 19:14
@wvidana
Merge branch 'master' into sentry
a67c4c2 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Another version bump
3f7d174 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2019
@wvidana
Copy link
Collaborator Author

wvidana commented May 21, 2019

@davidkarlsen Looks like I need approval again. Seems that 2 other sentry PRs where merged today and I had to bump the chart version twice

wvidana added 2 commits May 28, 2019 11:02
@wvidana
Merge branch 'master' into sentry
ce6d5e4 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Version bump
7e513bb 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Copy link
Collaborator Author

wvidana commented May 28, 2019

ping @davidkarlsen

@wvidana
Copy link
Collaborator Author

wvidana commented May 31, 2019

/assign @okgolove

@okgolove
Copy link
Collaborator

okgolove commented May 31, 2019 •
edited
Loading

@wvidana hello! Thank you for the PR.
First of all, I don't see the modified documentation (as and default values for loadBalancerSourceRanges).

Could you fix it?

wvidana added 2 commits May 31, 2019 14:44
@wvidana
Merge branch 'master' into sentry
78d66de 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Add documentation on values and README
2838338 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2019
@wvidana
Copy link
Collaborator Author

wvidana commented May 31, 2019

sorry about that @okgolove , completely forgot about it, good catch!

@okgolove
Copy link
Collaborator

/retest

@okgolove
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, okgolove, wvidana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@okgolove
Copy link
Collaborator

/retest

1 similar comment
@wvidana
Copy link
Collaborator Author

wvidana commented May 31, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 576a3aa into helm:master Jun 1, 2019
rvdh pushed a commit to rvdh/charts that referenced this pull request Jun 3, 2019
@wvidana @rvdh
[stable/sentry] Support loadBalancerSourceRanges on Service template (h…
851bc0a 
…elm#13665)

* Support loadBalancerSourceRanges on Service

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Chart version bump

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Adding default values and README

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Revert "Adding default values and README"

This reverts commit 940f3e2.

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Version bump

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Another version bump

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Version bump

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Add documentation on values and README

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
wvidana added a commit to wvidana/charts that referenced this pull request Sep 5, 2019
@wvidana
Adding wvidana as collaborator
0d107ff 
Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665
@wvidana wvidana mentioned this pull request Sep 5, 2019
Merged
wvidana added a commit to wvidana/charts that referenced this pull request Sep 5, 2019
@wvidana
Adding wvidana as collaborator
46aae01 
Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>
k8s-ci-robot pushed a commit that referenced this pull request Nov 7, 2019
@wvidana @k8s-ci-robot
[stable/cerebro] Adding wvidana as collaborator (#16909)
6fb92f2 
* Adding wvidana as collaborator

Volunteering from issue #13867

Past contributions to cerebro chart:
  - #14506

Past contributions to other helm charts:
  - #14196
  - #14189
  - #13667
  - #13666
  - #13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
@wvidana
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
22148f5 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@wvidana
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
245f178 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@wvidana @dargolith
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
51e7345 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lachie83 lachie83 Awaiting requested review from lachie83

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees

@davidkarlsen davidkarlsen

@sameersbn sameersbn

@okgolove okgolove

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wvidana @k8s-ci-robot @davidkarlsen @okgolove @sameersbn @helm-bot