This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/atlantis] Rename vcsSecretsName to vcsSecretName #14196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
helm-bot
added
the
Contribution Allowed
helm-bot
added
the
size/S
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @wvidana. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
|
/assign @lkysow |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkysow, wvidana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rvdh
pushed a commit
to rvdh/charts
that referenced
this pull request
Jun 3, 2019
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
wvidana
added a commit
to wvidana/charts
that referenced
this pull request
Sep 5, 2019
Volunteering from issue helm#13867 Past contributions to cerebro chart: - helm#14506 Past contributions to other helm charts: - helm#14196 - helm#14189 - helm#13667 - helm#13666 - helm#13665
wvidana
added a commit
to wvidana/charts
that referenced
this pull request
Sep 5, 2019
Volunteering from issue helm#13867 Past contributions to cerebro chart: - helm#14506 Past contributions to other helm charts: - helm#14196 - helm#14189 - helm#13667 - helm#13666 - helm#13665 Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 7, 2019
* Adding wvidana as collaborator Volunteering from issue #13867 Past contributions to cerebro chart: - #14506 Past contributions to other helm charts: - #14196 - #14189 - #13667 - #13666 - #13665 Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com> * Adding the OWNERS file to .helmignore Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
JoseAlban
pushed a commit
to JoseAlban/charts
that referenced
this pull request
Nov 22, 2019
* Adding wvidana as collaborator Volunteering from issue helm#13867 Past contributions to cerebro chart: - helm#14506 Past contributions to other helm charts: - helm#14196 - helm#14189 - helm#13667 - helm#13666 - helm#13665 Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com> * Adding the OWNERS file to .helmignore Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
hakman
pushed a commit
to hakman/charts
that referenced
this pull request
Dec 5, 2019
* Adding wvidana as collaborator Volunteering from issue helm#13867 Past contributions to cerebro chart: - helm#14506 Past contributions to other helm charts: - helm#14196 - helm#14189 - helm#13667 - helm#13666 - helm#13665 Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com> * Adding the OWNERS file to .helmignore Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
dargolith
pushed a commit
to dargolith/charts
that referenced
this pull request
Jan 10, 2020
* Adding wvidana as collaborator Volunteering from issue helm#13867 Past contributions to cerebro chart: - helm#14506 Past contributions to other helm charts: - helm#14196 - helm#14189 - helm#13667 - helm#13666 - helm#13665 Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com> * Adding the OWNERS file to .helmignore Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wilfrido Vidana wvidanas@gmail.com
What this PR does / why we need it:
Rename vcsSecretsName to vcsSecretName
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart])