Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/cerebro] Enables use of Cerebro provided auth #14506

Merged
merged 5 commits into from
Jun 17, 2019
Merged

[stable/cerebro] Enables use of Cerebro provided auth #14506

merged 5 commits into from
Jun 17, 2019

Conversation

wvidana
Copy link
Collaborator

@wvidana wvidana commented Jun 4, 2019 •
edited
Loading

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

wvidana added 4 commits June 4, 2019 14:40
@wvidana
Adding auth options, based on env vars
6e6c09c 
Imported from app, https://github.com/lmenezes/cerebro/blob/f2ed031fd89258c6ad85d40d846f5ff1f610fe73/conf/application.conf

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Ability to use env vars from a secret reference
587f063 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Update README with more info
0eacbbd 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Verison bump - new functionality
34a01b6 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @wvidana. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 4, 2019
@wvidana
Copy link
Collaborator Author

wvidana commented Jun 4, 2019

/assign @davidkarlsen

davidkarlsen
davidkarlsen suggested changes Jun 4, 2019
View reviewed changes
@davidkarlsen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2019
@wvidana @davidkarlsen
Update stable/cerebro/Chart.yaml
c707b0e 
Co-Authored-By: David J. M. Karlsen <davidkarlsen@gmail.com>
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Copy link
Collaborator Author

wvidana commented Jun 6, 2019

@davidkarlsen changes pushed per suggestions #14506 (review)

@wvidana
Copy link
Collaborator Author

wvidana commented Jun 12, 2019

@davidkarlsen ping

@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, wvidana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7897a36 into helm:master Jun 17, 2019
fooka03 pushed a commit to fooka03/charts that referenced this pull request Jun 17, 2019
@wvidana @davidkarlsen @fooka03
[stable/cerebro] Enables use of Cerebro provided auth (helm#14506)
cf7b278 
* Adding auth options, based on env vars

Imported from app, https://github.com/lmenezes/cerebro/blob/f2ed031fd89258c6ad85d40d846f5ff1f610fe73/conf/application.conf

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Ability to use env vars from a secret reference

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Update README with more info

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Verison bump - new functionality

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Update stable/cerebro/Chart.yaml

Co-Authored-By: David J. M. Karlsen <davidkarlsen@gmail.com>
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
Signed-off-by: Nigel Foucha <nigel.foucha@gmail.com>
anasinnyk pushed a commit to MacPaw/charts that referenced this pull request Jun 29, 2019
@wvidana @davidkarlsen @anasinnyk
[stable/cerebro] Enables use of Cerebro provided auth (helm#14506)
451e241 
* Adding auth options, based on env vars

Imported from app, https://github.com/lmenezes/cerebro/blob/f2ed031fd89258c6ad85d40d846f5ff1f610fe73/conf/application.conf

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Ability to use env vars from a secret reference

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Update README with more info

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Verison bump - new functionality

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Update stable/cerebro/Chart.yaml

Co-Authored-By: David J. M. Karlsen <davidkarlsen@gmail.com>
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
Signed-off-by: Andrii Nasinnyk <anasinnyk@macpaw.com>
wvidana added a commit to wvidana/charts that referenced this pull request Sep 5, 2019
@wvidana
Adding wvidana as collaborator
0d107ff 
Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665
@wvidana wvidana mentioned this pull request Sep 5, 2019
Merged
wvidana added a commit to wvidana/charts that referenced this pull request Sep 5, 2019
@wvidana
Adding wvidana as collaborator
46aae01 
Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>
k8s-ci-robot pushed a commit that referenced this pull request Nov 7, 2019
@wvidana @k8s-ci-robot
[stable/cerebro] Adding wvidana as collaborator (#16909)
6fb92f2 
* Adding wvidana as collaborator

Volunteering from issue #13867

Past contributions to cerebro chart:
  - #14506

Past contributions to other helm charts:
  - #14196
  - #14189
  - #13667
  - #13666
  - #13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
@wvidana
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
22148f5 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@wvidana
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
245f178 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@wvidana @dargolith
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
51e7345 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidkarlsen davidkarlsen davidkarlsen approved these changes

@scottrigby scottrigby Awaiting requested review from scottrigby

Assignees

@davidkarlsen davidkarlsen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wvidana @k8s-ci-robot @davidkarlsen @helm-bot