Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/cerebro] Adding wvidana as collaborator #16909

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @wvidana. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Sep 5, 2019
@wvidana
Copy link
Collaborator Author

wvidana commented Sep 5, 2019

/assign @davidkarlsen

@wvidana
Copy link
Collaborator Author

wvidana commented Sep 5, 2019

@davidkarlsen This PR is to volunteer as collaborator per issue #13867

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 5, 2019
@stale
Copy link

stale bot commented Oct 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 5, 2019
@wvidana
Copy link
Collaborator Author

wvidana commented Oct 6, 2019

@davidkarlsen ping

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 6, 2019
@stale
Copy link

stale bot commented Nov 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2019
@davidkarlsen
Copy link
Member

See "Owning and maintaining a chart" at https://github.com/helm/charts - step 3) add OWNERS to .helmignore file (and then I don't think the chart-version needs to be bumped).

Did you receive an invite from github?

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2019
@davidkarlsen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2019
@davidkarlsen
Copy link
Member

/verify-owners

1 similar comment
@wvidana
Copy link
Collaborator Author

wvidana commented Nov 6, 2019

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 6, 2019
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, wvidana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6fb92f2 into helm:master Nov 7, 2019
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants