…ng-Complete

Rather than clear the linking mode command when the device ACKs, wait to clear the message until the PLM reports the linking success.

…sponder Hash

Attempted to make the code more readable by using more descriptive variable names.

Created a responders and controllers hash, this makes the looping of the hash members a bit more straightforward at the cost of adding another global variable.  Alternatively, another level of keys could be added to global scene hash to decrease the number of global variables

Oops, forgot to declare the new hashes as globals

…p_Count

Moved per device setting outside of logic so that they are checked even if a hop_count is not passed.

Insteon_Scene_Build: Attempt to Make Code More Readable

Scene Build

Only Cooling and Heating statuses appear to be supported.  Bits 4 and 6 are also always enabled, I don't currently know what these are.  Sadly, humidifying and dehumidifying do not appear to be supported.

This allows for per device _process_message subs to exist without needing to reproduce all of the eval code.

…h Request_Status

This more closely matches what the user would expect

Conflicts:
	lib/Insteon.pm
	lib/Insteon/BaseInsteon.pm
	lib/Insteon_PLM.pm

…Nomenclature

Heating, Cooling, ... should be humidifying and the like

There does not appear to be any request which can be made to the device to get the status of the Humidifying or Dehumidifying group (perhaps a direct request to each device->group would work)

But in order to make sure that the two groups are in the proper state after a call to request_status we just manually set them inside the code

…essage ACK

… Pending Flag

Closes hollie#230

html_alias_cache is defined as data_dir/cache by default.  Most installations will only require the data_dir to be defined, only those with special installations would need the cache dir to be outside the data_dir.

Closes hollie#229

Basically just a copy of code for RemoteLincs, however, TriggerLincs support even fewer commands so much of the code was cut down.

I put the code in the Security.pm file as these are ostensible security devices, however as noted above, these are very similar to RemoteLincs.  Although, they are not that dissimilar from Motion sensors which are also in this file.

I don't own a TriggerLinc so this coding is all done blind.

Thanks to @JaredF for his testing work.

Closes hollie#245

Closes hollie#271

…a Scene

If no contoller existed, prior code would throw a recoverable error.

This addition prevents the error and provides a readable error message in the print_log

Insteon_ApplianceLink: Add DeviceController to Allow for Sync_Links

Insteon_Scene_Builder: Make Sure a Controller Exists Before Creating a Scene

Fix Nabble Links in MailList Page

…ral lines

If flag not cleared, all messages to that device will stall

Generate Voice Commands needed to be called after the thermo version is set

Enabled group and data3 determination if not specified.

Based off of Insteon_I2CS_Linking Branch so as not to require a manual merge.  Need to merge that branch first.

Closed hollie#274

No longer needed as all functions are condensed into BaseDevice link_to_interface function.

…ng cepstral swift for voice

…ze on arrow notation for parms.

…ects

Used a similar step method as found in link_to_interface to make the code more readable

Removed DeviceController unlink_to_interface routine as no longer needed

Previously we reset when we started a scan

Now we reset when a scan has completed successfully and each time when the device tells us that the ALDB Delta has not changed.

We also reset if serial query_aldb_delta requests are received in less than 2 seconds.  This allows for sequentail aldb actions without slowing down to send a request to the device for its ALDB Delta when it is unlikely that it changed.

Surrogate links allow the KPL light buttons to be directly controlled from MH.  In the future other similar surrogates may exist.

The Link_to_Interface routine now syncs these links if a surrogate is defined.

Also cut out the duplicate logic in Link_to_Interface_i2CS and instead sent the callbacks to Link_to_Interface since the functions are the same after the initial link.

Insteon: Reset ALDB Scan Time on Completed Successful Scan Only

Minor addition.

The companion function to the recently added feature in Link_to_Interface

Removed root finding code, as _aldb always returns the root object

Insteon: Add Delete All-Link Record Descriptor

Insteon:  Add Link_to_Interface for I2CS Devices

Insteon: Pass Message Clearing Decision to on_read_write_aldb

Change Referenced to Web Cache Directory to html_alias_cache

Routine was removed in favor of child battery object

Insteon_RemoteLinc: Remove Arcane Reference to is_battery_low

Insteon_TriggerLinc: Add Initial Support for TriggerLinc Devices

Insteon: Enabling Link_To_Interfaces for Child Objects in BaseDevice

Needed to set DeviceController as the primary, this underscores the need to get rid of that package.

Insteon_RemoteLinc: Fix for Setting Linked Devices

Closed hollie#279

Fix Delete Orphans Logic, had that backwards.

Reminder to self: don't use find and replace

The old routine contained a lot of unnecessary logic that made it difficult to parse.  Indeed, I am not sure I understand everything that it was doing.

A number of functions which were handled by the set routine in BaseDevice were also copied over.

A confusing routine that took me a while to decode.

Add Details for Set_By_To_Target Routine

Insteon:  Add Support for Thermostat i2 Devices

Many devices had their own set routines that duplicated the functionality of the BaseObject routine.

Insteon: Only Call Success_Callback if Active_Message Exists

…they were on before starting speech.

Before calling setby on the active_message, make sure that an active message exists.

Insteon: All_Link Cleanup Check for Active Message

Rather than testing and running derive_link_state only if a device is not_dimmable, call derive_link_state for all objects.

BaseObject::Derive_Link_State remains the same

DimmableLight::Derive_Link_State will return on,off, or 0%-100% from the input link_state.

Remove all logic which selectively ran derive_link_state

Necessary in order to cause set_linked_devices to run

Add logic to BaseObject::Set to test is_responder before trying to send set command.

Makes the code easier to read.

Also allows for non standard link_states (0%-100%) to be passed to linked devices.

Individual object routines are not needed, just set the flag on creating the object.

Bright and Dim are not valid states for non-dimmable devices and will be rejected.

Toggle state rewritten to be much more condensed.

…ontroller

InterfaceController will defer to BaseObject

No need for routine in BaseController

InterfaceController is different in that when its state is set by an outside object, MH needs to update the linked devices.  By moving this to is_acknowledged, the states of the linked devices will only be updated if the scene command was successfull.

Is_responder also always needs to be set to true for interfacecontroller even though it is not a root device.

Trying to keep the code in the two set routines in sync is just asking for trouble.

Derive Message allows MH to insert a specialized message into the set command.

Trying to keep the code in the routine in sync with the BaseObject code is a bad idea.

Instead just tie_events to each of the subgroup objects

No way to avoid hijacking BaseObject::Set

It did absolutely nothing

Determine relative percentage change based on interval between start and stop manual changes

Set device's state based on relative change, no longer request state after change, cuts down on excess messages

Set linked device states based on relative change, this permits more accurate representation of dimming of a scene with varying on_levels.  For Example, imagine a Scene where Light1 is linked to Light2 such that Light2's on_level is 75%.

After the scene is turned on, Light1 is then manually dimmed by 15%, Light2 will then dim by 15% as well and its state will be updated.

The resulting states would be Light1 85% and Light2 60%.

…oneous code comment.

Cuts down on duplication of code

Otherwise calling the set commands on these objects results in calling the Generic_Item::Set command.

Convert @lights[0] code to $lights[0] to get rid of perl warning.

Add space in a debug print log.

Ger rid of unnecessary if statement.

Prior commit inserted a bug where the state of linked devices was always set to on.

…evices on PLM Status Request

Need to set the main device state first before setting linked devices, otherwise you can get set_by loop errors if you have a three way controller.

Don't change the state of linked devices if the PLM requested the status. As turning off the linked devices would not always make sense.