-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake updates #1181
CMake updates #1181
Conversation
Thanks for the input, Rob!
Good catch! Sorry for this. I updated |
I am fixing the autotest stuff, so don't work on this until I commit my changes. I was done, but have a conflict to fix now. :) |
Okay, this is all good now. Autotest is fixed and tested as well. I've removed all mention of 'cmbuild' in the repo except for one occurence in |
Sounds great, thanks for the work, Rob! Let me relaunch all tests again with this newest version before merging this branch into master |
HYPRE_FMANGLE controls how symbols for Fortran are mangled. This can be changed via the configure script, but could not be configured during a CMake build. This change adds 3 options to CMakeLists.txt exposing HYPRE_FMANGLE, HYPRE_FMANGLE_BLAS, and HYPRE_FMANGLE_LAPACK such that they can be configured during a CMake build.
@rfalgout regression tests are passing. Would you like to take a final look before we merge this PR? Thank you! |
Everything looks great, @victorapm ! I only have the question about checktest.sh. |
Thanks Rob and everyone for helping with this PR! |
HYPRE_SetupGPUToolkit.cmake
to manage GPU options in cmake buildCMakeLists
and moved helper functions toHYPRE_CMakeUtilities.cmake
, e.g.,setup_git_version_info
for configuring and displaying hypre version using git version infoSOVERSION
field to CMake buildHYPRE_INSTALL_PATH
in favor of the commonly usedCMAKE_INSTALL_PATH
HYPRE_BUILD_TYPE
in favor of the commonly usedCMAKE_BUILD_TYPE
HYPRE_ENABLE_SHARED
in favor of the commonly usedBUILD_SHARED_LIBS
machine-tioga
HYPRE_ENABLE_LTO
option to turn on link-time optimizationHYPRE_MAYBE_UNUSED_FUNC
to mark functions as possibly unused, e.g.,static inline
functions defined in header files.Closes #1104
Closes #673
Closes #1084
Closes #1073
Closes #1072
Closes #1039
Closes #907
Closes #767
Closes #757
Closes #771
Closes #501
Closes #473
Closes #228
Closes #928
Closes #508
Closes #555
Closes #502
Closes #464