Devel #79
Merged
Devel #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merges manubot/rootstock#409 * moves repeated and shared/generic functions to separate "core" plugin * reorganizes html.yaml config into first and third party plugins * removes functionality to set plugin options from url * reformats plugins with Prettier (eg 4 space tabs to 2 space) * removes anonymizer wrapper. Just make <script> tag into module to keep scope local and avoid function name conflicts. this reduces the indent of the whole script by one level. * moves plugin specific CSS to plugins themselves * adds scite plugin (uncomment to enable)
merges manubot/rootstock#419 closes manubot/rootstock#418 Co-authored-by: Daniel Himmelstein <daniel.himmelstein@gmail.com> Co-authored-by: Anthony Gitter <agitter@users.noreply.github.com>
merges manubot/rootstock#427 Co-authored-by: Daniel Himmelstein <daniel.himmelstein@gmail.com> Co-authored-by: Anthony Gitter <agitter@users.noreply.github.com>
|
LGTM. Just a minor thing: [QC.Del02] Uses the term "builded" while [QC.Del01] and [QC.Del01.1] use "built". I suggest using always the later. |
|
add authors: German, Isabel, Slava |
fixed |
orviz
requested changes
Feb 3, 2022
orviz
reviewed
Feb 3, 2022
|
agree with Pablo's changes |
orviz
approved these changes
Feb 3, 2022
jorge-lip
approved these changes
Feb 4, 2022
gmolto
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: This project requires an associated issue before creating the pull request.
Description of the contribution
Major change in the document, see issues
Add annex, spell check
Related Issue/s
Resolves issues; #7, #35, #50, #57, #59, #60, #61, #63, #64, #65, #66, #67, #69, #70, #71, #72, #73, #74, #75, #76, #77, #78