[SYCL-PTX] Add builtins for the relational category #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naghasan
changed the title
Naghasan
force-pushed
the
victor/spirv-ptx-relational
branch
from
aaf44a8 to
a423507
Compare
Closed
bader
reviewed
Jun 11, 2020
libclc/utils/gen-libclc-test.py
Outdated
| @@ -13,11 +13,30 @@ | |||
|
|
|||
| def ignore_function(fun): | |||
| whitelist = [ | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
This should go away after rebasing to #1828.
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| // Autogenerated by gen-libclc-test.py |
There was a problem hiding this comment.
Should we keep auto-generated tests under version control or just the script which generates them?
There was a problem hiding this comment.
The script takes a while to generate everything, it is only not meant to be constantly rerun as the builtins are not meant to change.
|
Hi @Naghasan this is marked as WIP. Do you want me to review it now or wait for the next commit? |
Naghasan
force-pushed
the
victor/spirv-ptx-relational
branch
from
a423507 to
8bcbcf4
Compare
Signed-off-by: Victor Lomuller <victor@codeplay.com> Co-authored-by: David Wood <david.wood@codeplay.com>
Naghasan
force-pushed
the
victor/spirv-ptx-relational
branch
from
8bcbcf4 to
43b0fc2
Compare
|
@bader done :) |
Naghasan
changed the title
bader
approved these changes
Jun 19, 2020
|
@intel/llvm-reviewers-runtime, ping. |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jun 24, 2020
* upstream/sycl: [SYCL] Implement braced-init-list or a number as range for queue::parallel_for (intel#1931) [SYCL][Doc] Add SYCL_INTEL_accessor_properties extension specification (intel#1925) [SYCL-PTX] Add builtins for the relational category (intel#1831) [SYCL][CUDA] Remove unnecessary memfence (intel#1935) [SYCL] Add handling for wrapped sampler (intel#1942) [SYCL] Release notes for June'20 DPCPP implementation update (intel#1948) [SYCL] Fix assert when calling get_binaries() on host (intel#1944) [SYCL] Fix check for reqd_sub_group_size attribute mismatches (intel#1905)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old forward declared SPIR-V builtin from the relational category.
Update the binding file using the header generator.
Add relevant binding test.
Remove XFAIL from related SYCL tests.
Note there is a dependency with #1828 but can be reviewed independently.
Signed-off-by: Victor Lomuller victor@codeplay.com