Skip to content

Added an extension that introduces compile-time-constant properties t… #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

Added an extension that introduces compile-time-constant properties t… #1925

merged 1 commit into from
Jun 23, 2020

Conversation

GarveyJoe
Copy link
Contributor

…o property_list and accessor

@bader bader added the spec extension All issues/PRs related to extensions specifications label Jun 19, 2020
@bader
Copy link
Contributor

bader commented Jun 22, 2020

@GarveyJoe, I'd like to use following commit title:
"[SYCL][Doc] Add SYCL_INTEL_accessor_properties extension specification (#1925)"

And move current PR title to the commit message body:
"Added an extension that introduces compile-time-constant properties to property_list and accessor"

Are you okay with it?

@MrSidims
Copy link
Contributor

AFAIK Joe is on vacation. Readdressing the question to @mohammadfawaz

@mohammadfawaz
Copy link
Contributor

@GarveyJoe, I'd like to use following commit title:
"[SYCL][Doc] Add SYCL_INTEL_accessor_properties extension specification (#1925)"

And move current PR title to the commit message body:
"Added an extension that introduces compile-time-constant properties to property_list and accessor"

Are you okay with it?

On behalf of Joe. I believe this is reasonable. Thanks!

@bader bader merged commit 58fc414 into sycl Jun 23, 2020
@bader bader deleted the GarveyJoe-patch-2 branch June 23, 2020 17:05
@bader
Copy link
Contributor

bader commented Jun 23, 2020

@mohammadfawaz, thanks.

alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Jun 24, 2020
Merge remote-tracking branch 'upstream/sycl' into add_device_executable
d6d7815 
* upstream/sycl:
  [SYCL] Implement braced-init-list or a number as range for queue::parallel_for (intel#1931)
  [SYCL][Doc] Add SYCL_INTEL_accessor_properties extension specification (intel#1925)
  [SYCL-PTX] Add builtins for the relational category (intel#1831)
  [SYCL][CUDA] Remove unnecessary memfence (intel#1935)
  [SYCL] Add handling for wrapped sampler (intel#1942)
  [SYCL] Release notes for June'20 DPCPP implementation update (intel#1948)
  [SYCL] Fix assert when calling get_binaries() on host (intel#1944)
  [SYCL] Fix check for reqd_sub_group_size attribute mismatches (intel#1905)
keryell
keryell reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a good progress towards some ideas of P0367R0.
I hope to see some FPGA-related properties too.

@MrSidims MrSidims mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrodman jbrodman jbrodman approved these changes

@mkinsner mkinsner Awaiting requested review from mkinsner

+1 more reviewer

@keryell keryell keryell left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
spec extension All issues/PRs related to extensions specifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GarveyJoe @bader @MrSidims @mohammadfawaz @keryell @jbrodman