[SYCL] Implement braced-init-list or a number as range for queue::parallel_for #1931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarutyun
requested review from
Pennycook,
bader,
iburyl,
jbrodman,
romanovvlad and
sergey-semenov
…allel_for
Modification:
Make three different overloads for queue::parallel for to support
range implicit conversion from number or braced-init-list
Add tests for queue::parallel_for calls with generic lambda
Signed-off-by: Ruslan Arutyunyan <ruslan.arutyunyan@intel.com>
bader
reviewed
Jun 19, 2020
| // UNSUPPORTED: cuda | ||
| // CUDA does not support unnamed lambdas. | ||
| // | ||
| // RUN: %clangxx -fsycl -fsyntax-only -fsycl-unnamed-lambda %s -o %t.out |
Contributor
There was a problem hiding this comment.
Suggested change
| // RUN: %clangxx -fsycl -fsyntax-only -fsycl-unnamed-lambda %s -o %t.out | |
| // RUN: %clangxx -fsycl -fsyntax-only -fsycl-unnamed-lambda %s -c -o %t.out |
I guess linking can be omitted.
Contributor
Author
There was a problem hiding this comment.
It tells me that -c is unknown option. Anyway, we launch this test with syntax-only flag that doesn't spend run-time
Signed-off-by: Ruslan Arutyunyan <ruslan.arutyunyan@intel.com>
sergey-semenov
approved these changes
Jun 23, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jun 24, 2020
* upstream/sycl: [SYCL] Implement braced-init-list or a number as range for queue::parallel_for (intel#1931) [SYCL][Doc] Add SYCL_INTEL_accessor_properties extension specification (intel#1925) [SYCL-PTX] Add builtins for the relational category (intel#1831) [SYCL][CUDA] Remove unnecessary memfence (intel#1935) [SYCL] Add handling for wrapped sampler (intel#1942) [SYCL] Release notes for June'20 DPCPP implementation update (intel#1948) [SYCL] Fix assert when calling get_binaries() on host (intel#1944) [SYCL] Fix check for reqd_sub_group_size attribute mismatches (intel#1905)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification
queue::parallel_forto supportrangeimplicit conversion from number orbraced-init-listqueue::parallel_forcalls with generic lambdaImplement the following
queueextensionSigned-off-by: Ruslan Arutyunyan ruslan.arutyunyan@intel.com