[SYCL] Add handling for wrapped sampler #1942
Conversation
This adds proper initialization for sampler object that is wrapped by a struct. This is temporary change because it contradicts the OpenCL and SPIR-V spec, since the struct with sampler opaque type field appears as kernel argument. We need it now to fix crashes in OpenCL backends.
Fznamznon
requested review from
elizabethandrews,
premanandrao and
a team
as code owners
|
Should a Sema test be added as well? |
Not sure that this AST test has value, first because handling of wrapped sampler that I'm adding is fully identical to wrapped accessor handling (and we have a test for this case). Second, this solution is temporary and intended to fix crashes in OpenCL backends caused by missing raw sampler argument, that I'm checking in CodeGen test. |
|
Frontend changes LGTM. I am not familiar with runtime tests so I defer the review of test to someone more familiar. |
* upstream/sycl: [SYCL] Implement braced-init-list or a number as range for queue::parallel_for (intel#1931) [SYCL][Doc] Add SYCL_INTEL_accessor_properties extension specification (intel#1925) [SYCL-PTX] Add builtins for the relational category (intel#1831) [SYCL][CUDA] Remove unnecessary memfence (intel#1935) [SYCL] Add handling for wrapped sampler (intel#1942) [SYCL] Release notes for June'20 DPCPP implementation update (intel#1948) [SYCL] Fix assert when calling get_binaries() on host (intel#1944) [SYCL] Fix check for reqd_sub_group_size attribute mismatches (intel#1905)
|
If you have some ideas on how to solve this in the general OpenCL/SPIR-V case, participate to the Khronos OpenCL tooling meetings. |
This adds proper initialization for sampler object that is wrapped by a
struct. This is temporary change because it contradicts the OpenCL and
SPIR-V spec, since the struct with sampler opaque type field appears as
kernel argument. We need it now to fix crashes in OpenCL backends.