Skip to content

Updated PR template#849

Closed
regulartim wants to merge 18 commits intomainfrom
new_pr_template
Closed

Updated PR template#849
regulartim wants to merge 18 commits intomainfrom
new_pr_template

Conversation

@regulartim
Copy link
Collaborator

@regulartim regulartim commented Feb 20, 2026

Hey Matteo,
as new contributors always seem to fall into the same traps, I was thinking that maybe a more clearly structured PR template would help (them and us). Here it is. What do you think?

Description

Please include a short summary of the change. Don't just paste LLM output here.

Related issues

Please add related issues: the issues you are trying to solve as well as other issues that are important in the context of this pull request.

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Chore (refactoring, dependency updates, CI/CD changes, code cleanup, docs-only changes).

Checklist

Please complete this checklist carefully. It helps guide your contribution and lets maintainers verify that all requirements are met.

Formalities

  • I have read and understood the rules about how to Contribute to this project.
  • I chose an appropriate title for the pull request in the form: <feature name>. Closes #999
  • My branch is based on develop.
  • The pull request is for the branch develop.
  • I have reviewed and verified any LLM-generated code included in this PR.

Docs and tests

  • I documented my code changes with docstrings and/or comments.
  • I have checked if my changes affect user-facing behavior that is described in the docs. If so, I also created a pull request in the docs repository.
  • Linter (Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved.
  • All the tests gave 0 errors.

GUI changes

Ignore this section if you did not make any changes to the GUI.

  • I have provided a screenshot of the result in the PR.
  • I have created new frontend tests for the new component or updated existing ones.

Review process

  • We encourage you to create a draft PR first, even when your changes are incomplete. This way you refine your code while we can track your progress and actively review and help.
  • If you think your draft PR is ready to be reviewed by the maintainers, click the corresponding button. Your draft PR will become a real PR.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem.
  • Every time you make changes to the PR and you think the work is done, you should explicitly ask for a review. After receiving a "change request", address the feedback and click "request re-review" next to the reviewer's profile picture at the top right.

opbot-xd and others added 18 commits February 16, 2026 16:54
@opbot-xd @regulartim
Migrate from RabbitMQ/Celery to Django Q2. Closes #778 (#789)
2e29748 
* Migrate from RabbitMQ/Celery to Django Q2

* Replace RabbitMQ/Celery with Django Q2 in deployment scripts and Docker configs

* Make createcachetable idempotent in entrypoint script

* test: add tests for setup_schedules management command

- Add comprehensive tests for EXTRACTION_INTERVAL handling
- Fix setup_schedules to read settings at runtime for testability
- Add minute clamping to prevent invalid cron values

* fix: improve test robustness and cache table creation

- Use name-based assertion instead of positional indexing in tests
- Fix misleading docstring about minute clamping
- Explicitly create greedybear_cache table in entrypoint to match settings

* refactor: Improve Django-Q schedule management and deployment

- Separated schedule setup logic into greedybear/cronjobs/schedules.py
- Added automatic cleanup of orphaned schedules from database
- Simplified cache table creation (removed || true, uses Django idempotent command)
- Fixed qcluster Docker health check to wait for uwsgi
- Added validation: EXTRACTION_INTERVAL must be divisor of 60
- Fixed django-q2 version pinning (== instead of ~=)
- Code cleanup: removed extra blank lines in tasks.py

* chore: update django-q2 version to 1.9.0 in project requirements

* fix: update service condition for uwsgi and enhance test mocks in setup_schedules tests

* feat: add healthcheck for uwsgi service and adjust worker count in Q_CLUSTER

* fix: disable RabbitMQ usage and enhance schedule management in setup_schedules

* refactor: replace custom uWSGI healthcheck script with a simpler network check and increase healthcheck retries.

* fix: remove unused healthcheck script for uwsgi service

* chore: Add `__init__.py` to `tests/greedybear/management` to enable test discovery.

* Fix log file ownership

* Add exec before qcluster command to allow qcluster to shut down gracefully

---------

Co-authored-by: tim <46972822+regulartim@users.noreply.github.com>
@R1sh0bh-1
Migrate frontend from Create React App to Vite. Closes #783 (#807)
19a4ce5 
* feat(frontend): migrate from Create React App to Vite

* fix: correct localStorage.getItem() argument order in Register.jsx

* chore: update to v3.1.0 and align env vars with Vite migration

* chore: clean up config per review - remove CRA proxy field, no-op rewrite function, and meta description tag

* test: add Jest mock for environment.js to fix import.meta.env compatibility

* fix(auth):  confirmPassword is undefined error

* final cleanup

* revert some of the renaming as suggested
@regulartim
Fix and update watchman. Closes #818 (#819)
14402cd 
* install required packages

* update watchman to most recent version

* update URL
@rootp1 @regulartim
NEW Docker Compose native healthcheck. Closes #809 (#821)
e7017ed 
* NEW Docker Compose native healthcheck. Closes #809

* unnecesary username

* add username and database name explicitly

---------

Co-authored-by: tim <46972822+regulartim@users.noreply.github.com>
@R1sh0bh-1 @regulartim
Migration of frontend tests from Jest to Vitest. Closes #817 (#820)
f931ac7 
* chore(migration): migrate frontend tests from Jest to Vitest

* fix(test): mock zustand to resolve version conflict with certego-ui

* refactor(test): remove jest polyfill and use vi natively

* fix(ci): remove duplicate input definition

* fix(test): add missing coverage dependency

* implemented maintainer feedback

* fix(ci): remove undefined input use_jest

* fix coverage report in CI

---------

Co-authored-by: tim <46972822+regulartim@users.noreply.github.com>
@remo-lab
Add missing HTTP error handling in MassScannersCron and WhatsMyIPCron. …
3715184 
…Closes #814 (#816)

Signed-off-by: remo-lab <remopanda7@gmail.com>
@dependabot
build(deps): bump slack-sdk from 3.39.0 to 3.40.0 in /requirements (#826
4b152de 
)

Bumps [slack-sdk](https://github.com/slackapi/python-slack-sdk) from 3.39.0 to 3.40.0.
- [Release notes](https://github.com/slackapi/python-slack-sdk/releases)
- [Commits](slackapi/python-slack-sdk@v3.39.0...v3.40.0)

---
updated-dependencies:
- dependency-name: slack-sdk
  dependency-version: 3.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@drona-gyawali
refactor(setup_schedules): Reduce duplication and improve maintainabi…
74f50a4 
…lity. Closes #822 (#824)

* enh: file based config for cron jobs

* refactor infile schedules defination

* added code comment
@armoredvortex
Add Enrichment Lookup component. Closes #436 (#827)
d539c1e 
* Add Enrichment Lookup component

* run prettier

* fix wrong field name for ioc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* handle null values in expected_interactions

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* firehol_category -> firehol_categories

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix enrichment error handling to use DRF error format

* linter

* test: add tests for Enrichment Lookup functionality

* fix: changes requested in review; handle null values; fix typos; remove redundant loding state from button;

* disable user input when not authenticated

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@R1sh0bh-1
Allow special characters in passwords and update validation logic. Cl…
b370b90 
…oses #812 (#829)

* fix: Allow special characters in passwords and update validation logic

* fix: Add missing profile field to backend test payload

* fix(tests): resolve CI failure in backend test

* fix: added a more stricter regex to be on safer side
@regulartim
Remove orphaned containers in gbctl update. Closes #832 (#833)
9107676
@armoredvortex
Fix changing the prioritization not resetting the ordering indicator. C…
b012752 
…loses #782
@remo-lab
fix: prevent ML training pipeline crash on zero-positive test sets. C…
482a05e 
…loses #823 (#830)

Signed-off-by: remo-lab <remopanda7@gmail.com>
@regulartim
Use npm ci in the Dockerfile. Closes #840 (#841)
360ad90
@regulartim
Refactor training scheduling. Closes #835 (#836)
94386f6 
* call training task from extraction task if run at midnight

* remove training task from schedules

* add comments

* remove calculation checks from existing tests

* fix formatting

* add tests for new scheduling logic
@rootp1
Prettier formatting fixes. Closes #842
2cc65b9
@regulartim
update PR template
3ce3408
@regulartim
change heading
e563c24
@regulartim regulartim closed this Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drosetti drosetti Awaiting requested review from drosetti drosetti will be requested when the pull request is marked ready for review drosetti is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@regulartim @opbot-xd @R1sh0bh-1 @rootp1 @remo-lab @drona-gyawali @armoredvortex