Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvc>=2.7.3 is incompatible with tensorflow because of typing-extensions #6731

Closed
gcoter opened this issue Oct 3, 2021 · 3 comments · Fixed by #6732
Closed

dvc>=2.7.3 is incompatible with tensorflow because of typing-extensions #6731

gcoter opened this issue Oct 3, 2021 · 3 comments · Fixed by #6732
Labels
maintenance

Comments

@gcoter
Copy link
Contributor

gcoter commented Oct 3, 2021

Hello,

It is not really a feature request but not really a bug neither. Feel free to tell me if I should post this elsewhere.

I work on a project with dvc and tensorflow. I noticed that I did not have the last version (2.7.2 instead of 2.7.4) so I tried to upgrade.

I use Poetry to manage the dependencies of the project. It is quite good to handle incompatibilities. When I ask it to install dvc, it chooses version 2.7.2. When I force it to install version 2.7.4, I get this incompatibility error:

$ poetry add "dvc[ssh]==2.7.4"

Updating dependencies
Resolving dependencies... (0.3s)

  SolverProblemError

  Because no versions of tensorflow match >2.6.0,<3.0.0
   and tensorflow (2.6.0) depends on typing-extensions (>=3.7.4,<3.8.0), tensorflow (>=2.6.0,<3.0.0) requires typing-extensions (>=3.7.4,<3.8.0).
  And because dvc (2.7.4) depends on typing-extensions (>=3.10.0.2), tensorflow (>=2.6.0,<3.0.0) is incompatible with dvc (2.7.4).
  So, because music-generation-v2 depends on both dvc (2.7.4) and tensorflow (^2.6.0), version solving failed.

In other words, tensorflow requires a version of typing-extensions which is lower than the one required by dvc (since version 2.7.3). For now, I could not find a recent tensorflow version which would be compatible with this requirement.

I found that the requirement was modified in this commit on your side: ef017be#diff-8a5e2e65dfa49c67096312e68e6620b20055b720b11bcdf44aa003ff02103af2

So my question is: would it be possible to relax this requirement on typing-extensions?
@efiop
Copy link
Contributor

efiop commented Oct 3, 2021

Looks like we could exclude 3.10.0.1 and relax the rest to be >= 3.7.4 CC @skshetry wdyt?

@skshetry
Copy link
Member

skshetry commented Oct 3, 2021 •
edited
Loading

@efiop, we can just set it to >=3.7.4. On other installations (including 3.10), it'll install the latest version anyway.

@gcoter PRs are welcome.

@gcoter
Copy link
Contributor Author

gcoter commented Oct 3, 2021

@skshetry I will make a PR then 🙂

gcoter added a commit to gcoter/dvc that referenced this issue Oct 3, 2021
@gcoter
Bump typing_extensions to >=3.7.4 (iterative#6731)
060a3b9
@gcoter gcoter mentioned this issue Oct 3, 2021
Merged
2 tasks
skshetry pushed a commit that referenced this issue Oct 3, 2021
@gcoter
Bump typing_extensions to >=3.7.4 (#6731) (#6732)
ec72866
skshetry added a commit to endremborza/dvc that referenced this issue Oct 8, 2021
@skshetry
Merge branch 'master' into endremborza/master
9c7f86b 
* master: (47 commits)
  make dependabot updates work (iterative#6760)
  move defaults to the class level (iterative#6762)
  build(deps): Bump dvclive from 0.3.0 to 0.4.0 (iterative#6753)
  move requirements to setup.cfg (iterative#6758)
  gha: cancel previous workflows (iterative#6756)
  pyinstaller: hooks: remove webhdfs
  webhdfs: migrate to fsspec (iterative#6662)
  gha: benchmarks: fix pytest flags (iterative#6749)
  hdfs: migrate to fsspec (iterative#6604)
  Pin dvclive to 0.3.0
  command: Should not consume 'print' to output default remote info (iterative#6650)
  command: output prettify json in tty (iterative#6743)
  gha: run benchmarks on PRs (iterative#6733)
  Run on Python3.10 (iterative#6745)
  Fix dvclive running subdir (iterative#6740)
  exp init: only ask for that are not provided in an interactive mode (iterative#6739)
  move exp init logic to dvc.repo.experiments.init (iterative#6738)
  build(deps): Bump jaraco-windows from 5.6.0 to 5.7.0 (iterative#6735)
  build(deps): Bump pytest-cov from 2.12.1 to 3.0.0 (iterative#6736)
  Bump typing_extensions to >=3.7.4 (iterative#6731) (iterative#6732)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump typing_extensions to >=3.7.4 gcoter/dvc
3 participants
@efiop @gcoter @skshetry