Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: benchmarks: fix pytest flags #6749

Merged
merged 1 commit into from
Oct 6, 2021
Merged

gha: benchmarks: fix pytest flags #6749

merged 1 commit into from
Oct 6, 2021

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Oct 6, 2021

Kudos @skshetry for catching.

@efiop efiop requested a review from a team as a code owner October 6, 2021 12:55
@efiop efiop requested a review from pmrowla October 6, 2021 12:55
@efiop efiop added bug Did we break something? maintenance skip-changelog Skips changelog github_actions Pull requests that update Github_actions code labels Oct 6, 2021
@efiop efiop changed the title gha: benchmarks: fix pytest flags [WIP] gha: benchmarks: fix pytest flags Oct 6, 2021
@@ -15,5 +15,5 @@ jobs:
python-version: 3.7
- uses: iterative/dvc-bench@master
with:
pytest_options: "${{ github.event_name == 'workflow_dispatch' && '' || '-k test_init -k test_help' }}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the difference with workflow_dispatch for now, as it seems redundant and confusing to run full test suit.

@efiop efiop changed the title [WIP] gha: benchmarks: fix pytest flags gha: benchmarks: fix pytest flags Oct 6, 2021
@efiop efiop merged commit 32f435c into master Oct 6, 2021
@efiop efiop deleted the efiop-patch-1 branch October 6, 2021 14:07
skshetry added a commit to endremborza/dvc that referenced this pull request Oct 8, 2021
* master: (47 commits)
  make dependabot updates work (iterative#6760)
  move defaults to the class level (iterative#6762)
  build(deps): Bump dvclive from 0.3.0 to 0.4.0 (iterative#6753)
  move requirements to setup.cfg (iterative#6758)
  gha: cancel previous workflows (iterative#6756)
  pyinstaller: hooks: remove webhdfs
  webhdfs: migrate to fsspec (iterative#6662)
  gha: benchmarks: fix pytest flags (iterative#6749)
  hdfs: migrate to fsspec (iterative#6604)
  Pin dvclive to 0.3.0
  command: Should not consume 'print' to output default remote info (iterative#6650)
  command: output prettify json in tty (iterative#6743)
  gha: run benchmarks on PRs (iterative#6733)
  Run on Python3.10 (iterative#6745)
  Fix dvclive running subdir (iterative#6740)
  exp init: only ask for that are not provided in an interactive mode (iterative#6739)
  move exp init logic to dvc.repo.experiments.init (iterative#6738)
  build(deps): Bump jaraco-windows from 5.6.0 to 5.7.0 (iterative#6735)
  build(deps): Bump pytest-cov from 2.12.1 to 3.0.0 (iterative#6736)
  Bump typing_extensions to >=3.7.4 (iterative#6731) (iterative#6732)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? github_actions Pull requests that update Github_actions code maintenance skip-changelog Skips changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant