make dependabot updates work #6760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot was throwing Illformed requirements `"< '3.10'"` for the hdfs. But I noticed that it did accept other requirements where we do similar. So it seems the indentation fixes it. Even then, dependabot did not update any dependencies. I removed setup.py file, after which immediately it started creating PRs. So, I recknoed that it must have been due to some mechanism in place from dependabot to disallow execution, so I tried to remove few blocks of code from setup.py. And, I was eventually able to figure out that it was from the block where we import version. So, I added a try-except block and it magically again worked. :) Let's see how it goes.
skshetry
commented
Oct 8, 2021
Comment on lines
+21
to
+26
| pkg_dir = os.path.dirname(os.path.abspath(__file__)) | ||
| version_path = os.path.join(pkg_dir, "dvc", "version.py") | ||
| spec = importlib.util.spec_from_file_location("dvc.version", version_path) | ||
| dvc_version = importlib.util.module_from_spec(spec) | ||
| spec.loader.exec_module(dvc_version) | ||
| version = dvc_version.__version__ # noqa: F821 |
There was a problem hiding this comment.
I'd prefer getting rid of the version altogether and just use the version that we set in _BASE_VERSION, as it makes setup.py more static here (all of the code here is just to get version).
There was a problem hiding this comment.
Agreed. I'd also say that _BASE_VERSION should be defined here (or even in setup.cfg to be completely declarative) and in dvc/version.py we can retrieve it from the package metadata.
isidentical
approved these changes
Oct 8, 2021
skshetry
added a commit
to endremborza/dvc
that referenced
this pull request
Oct 8, 2021
* master: (47 commits) make dependabot updates work (iterative#6760) move defaults to the class level (iterative#6762) build(deps): Bump dvclive from 0.3.0 to 0.4.0 (iterative#6753) move requirements to setup.cfg (iterative#6758) gha: cancel previous workflows (iterative#6756) pyinstaller: hooks: remove webhdfs webhdfs: migrate to fsspec (iterative#6662) gha: benchmarks: fix pytest flags (iterative#6749) hdfs: migrate to fsspec (iterative#6604) Pin dvclive to 0.3.0 command: Should not consume 'print' to output default remote info (iterative#6650) command: output prettify json in tty (iterative#6743) gha: run benchmarks on PRs (iterative#6733) Run on Python3.10 (iterative#6745) Fix dvclive running subdir (iterative#6740) exp init: only ask for that are not provided in an interactive mode (iterative#6739) move exp init logic to dvc.repo.experiments.init (iterative#6738) build(deps): Bump jaraco-windows from 5.6.0 to 5.7.0 (iterative#6735) build(deps): Bump pytest-cov from 2.12.1 to 3.0.0 (iterative#6736) Bump typing_extensions to >=3.7.4 (iterative#6731) (iterative#6732) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot was throwing Illformed requirements
"< '3.10'"for thehdfs. But I noticed that it did accept other requirements where we
do similar. So it seems the indentation fixes it.
Even then, dependabot did not update any dependencies. I removed
setup.py file, after which immediately it started creating PRs.
So, I reckoned that it must have been due to some mechanism
in place from dependabot to disallow execution, so I tried to
remove few blocks of code from setup.py. And, I was eventually
able to figure out that it was from the block where we import version.
So, I added a try-except block and it magically worked again. :)