webhdfs: migrate to fsspec #6662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
Sep 21, 2021
dvc/fs/webhdfs.py
Outdated
Comment on lines
41
to
43
| try: | ||
| return hdfs.config.Config(self.hdfscli_config).get_client( | ||
| self.alias | ||
| ) | ||
| except hdfs.util.HdfsError as exc: | ||
| exc_msg = str(exc) | ||
| errors = ( | ||
| "No alias specified", | ||
| "Invalid configuration file", | ||
| f"Alias {self.alias} not found", | ||
| ) | ||
| if not any(err in exc_msg for err in errors): | ||
| raise | ||
|
|
||
| http_url = f"http://{self.host}:{self.port}" | ||
| logger.debug("URL: %s", http_url) | ||
|
|
||
| if self.token is not None: | ||
| client = hdfs.TokenClient(http_url, token=self.token, root="/") | ||
| else: | ||
| client = hdfs.InsecureClient( | ||
| http_url, user=self.user, root="/" | ||
| config = Config(path) | ||
| except HdfsError: | ||
| return None |
There was a problem hiding this comment.
For the record: discussed that we might just drop hdfscli config, since we are no longer using it as a backend.
There was a problem hiding this comment.
@isidentical Wdyt, removing it or not?
efiop
reviewed
Sep 21, 2021
efiop
reviewed
Sep 21, 2021
efiop
approved these changes
Sep 21, 2021
isidentical
force-pushed
the
migrate-webhdfs
branch
from
d3c371a to
2bc6ca6
Compare
|
@Mergifyio rebase |
skshetry
force-pushed
the
migrate-webhdfs
branch
from
2bc6ca6 to
d2a74c2
Compare
|
Command
|
efiop
suggested changes
Oct 6, 2021
dvc/fs/webhdfs.py
Outdated
Comment on lines
41
to
43
| try: | ||
| return hdfs.config.Config(self.hdfscli_config).get_client( | ||
| self.alias | ||
| ) | ||
| except hdfs.util.HdfsError as exc: | ||
| exc_msg = str(exc) | ||
| errors = ( | ||
| "No alias specified", | ||
| "Invalid configuration file", | ||
| f"Alias {self.alias} not found", | ||
| ) | ||
| if not any(err in exc_msg for err in errors): | ||
| raise | ||
|
|
||
| http_url = f"http://{self.host}:{self.port}" | ||
| logger.debug("URL: %s", http_url) | ||
|
|
||
| if self.token is not None: | ||
| client = hdfs.TokenClient(http_url, token=self.token, root="/") | ||
| else: | ||
| client = hdfs.InsecureClient( | ||
| http_url, user=self.user, root="/" | ||
| config = Config(path) | ||
| except HdfsError: | ||
| return None |
There was a problem hiding this comment.
@isidentical Wdyt, removing it or not?
isidentical
force-pushed
the
migrate-webhdfs
branch
from
d2a74c2 to
5ed9be5
Compare
|
It seems like the docker is randomly failing on some runs with timeouts. I've increased the timeout from 30 to 60 seconds, hopefully that will solve it. (In the past we were mocking hdfs-cli's InsecureClient, so we weren't using the real hdfs server). |
efiop
reviewed
Oct 7, 2021
isidentical
force-pushed
the
migrate-webhdfs
branch
from
d243e9d to
25f4e79
Compare
efiop
reviewed
Oct 7, 2021
efiop
reviewed
Oct 7, 2021
efiop
reviewed
Oct 7, 2021
isidentical
force-pushed
the
migrate-webhdfs
branch
from
25f4e79 to
cd0433a
Compare
efiop
approved these changes
Oct 7, 2021
skshetry
added a commit
to endremborza/dvc
that referenced
this pull request
Oct 8, 2021
* master: (47 commits) make dependabot updates work (iterative#6760) move defaults to the class level (iterative#6762) build(deps): Bump dvclive from 0.3.0 to 0.4.0 (iterative#6753) move requirements to setup.cfg (iterative#6758) gha: cancel previous workflows (iterative#6756) pyinstaller: hooks: remove webhdfs webhdfs: migrate to fsspec (iterative#6662) gha: benchmarks: fix pytest flags (iterative#6749) hdfs: migrate to fsspec (iterative#6604) Pin dvclive to 0.3.0 command: Should not consume 'print' to output default remote info (iterative#6650) command: output prettify json in tty (iterative#6743) gha: run benchmarks on PRs (iterative#6733) Run on Python3.10 (iterative#6745) Fix dvclive running subdir (iterative#6740) exp init: only ask for that are not provided in an interactive mode (iterative#6739) move exp init logic to dvc.repo.experiments.init (iterative#6738) build(deps): Bump jaraco-windows from 5.6.0 to 5.7.0 (iterative#6735) build(deps): Bump pytest-cov from 2.12.1 to 3.0.0 (iterative#6736) Bump typing_extensions to >=3.7.4 (iterative#6731) (iterative#6732) ...
29 tasks
This was referenced Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6583, awaiting an fsspec release.