This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
implemented futures::Sink for parquet async writer
#877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pre-calculating the null_count on a Bitmap we need to start from the correct place in the underlying byte-array (i.e. take into account that we may already be looking at a slice). Currently, when we slice of a small part (so that we enter the first branch of the null_count choice), the null_count assumes that the current offset is 0, but it should not. This adds a test for this situation and fixes the issue.
Codecov Report
@@ Coverage Diff @@
## main #877 +/- ##
==========================================
+ Coverage 71.50% 71.67% +0.17%
==========================================
Files 335 335
Lines 18147 18206 +59
==========================================
+ Hits 12976 13050 +74
+ Misses 5171 5156 -15
Continue to review full report at Codecov.
|
jorgecarleitao
changed the title
futures::Sink for parquet async writer
jorgecarleitao
added
feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parquet component of this PR: #876.
Adds
io::parquet::write::FileSinkwhich implementsfutures::Sink.Removes
io::parquet::write::FileStreamer.