-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pr2eus] Add correction arg in :move-to-wait #418
Conversation
57d4d29
to
ba01746
Compare
How about add correction argument in because in #406 case, we also have to override |
jsk_pr2eus/pr2eus/robot-interface.l Lines 1336 to 1340 in ba01746
all args is passed to :move-to-wait , so you can pass :correction arg in :move-to function as follows;(send *ri* :move-to coords :correction nil)
|
あ、すいません。勘違いしてました。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, btw could we add documentation to all move-base related function?
add
:correction
arg in:move-to-wait
if you set
:correction nil
, the correction step will be skipped.related #406