[jsk_fetch_startup] add more params in smach_to_mail #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 tasks
mqcmd196
force-pushed
the
fetch-smach-to-mail-param
branch
from
98ddbff
to
65159bc
Compare
tkmtnt7000
previously approved these changes
Oct 23, 2022
mqcmd196
force-pushed
the
fetch-smach-to-mail-param
branch
from
65159bc
to
5288d5e
Compare
tkmtnt7000
dismissed
their stale review
Cancel approvement because of test failing.
tkmtnt7000
reviewed
Oct 28, 2022
Comment on lines
+271
to
+272
| <rosparam command="load" | ||
| file="$(find jsk_fetch_startup)/config/$(arg hostname)_email_topic.yaml" /> |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds more params in
smach_to_mail.pythis PR also change the node name and fixes mail address parameter loading.