Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(routing): Integrate global success rates #6950

Merged
merged 19 commits into from
Jan 21, 2025
Merged

feat(routing): Integrate global success rates #6950

merged 19 commits into from
Jan 21, 2025

Conversation

Sarthak1799
Copy link
Contributor

@Sarthak1799 Sarthak1799 commented Dec 26, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Integrate global Success rates for dynamic routing

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  1. toggle success based routing with dynamic connector selection enabled
curl --location --request POST 'http://localhost:8080/account/sarthak2/business_profile/pro_F5mC1GGXHPLTtfcBnZEP/dynamic_routing/success_based/toggle?enable=dynamic_connector_selection' \
--header 'api-key: dev_RQxKf8JqHb5tTfTp13JMnI7TyWgXIHaa2AP5VkjLtst1CRJPArSfqasfGQI1oIAQ'
  1. Set volume split for dynamic routing
curl --location --request POST 'http://localhost:8080/account/sarthak2/business_profile/pro_F5mC1GGXHPLTtfcBnZEP/dynamic_routing/set_volume_split?split=80' \
--header 'api-key: dev_RQxKf8JqHb5tTfTp13JMnI7TyWgXIHaa2AP5VkjLtst1CRJPArSfqasfGQI1oIAQ'
  1. Make a payment
  2. Global SR connector should be populated in DB
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sarthak1799 Sarthak1799 self-assigned this Dec 26, 2024
@Sarthak1799 Sarthak1799 requested review from a team as code owners December 26, 2024 13:46
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Dec 26, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/routing/helpers.rs  14% smaller
  crates/openapi/src/openapi.rs  13% smaller
  crates/external_services/src/grpc_client/dynamic_routing/success_rate_client.rs  5% smaller
  api-reference/openapi_spec.json  0% smaller
  crates/api_models/src/routing.rs  0% smaller
  crates/diesel_models/src/dynamic_routing_stats.rs  0% smaller
  crates/diesel_models/src/schema.rs  0% smaller
  crates/diesel_models/src/schema_v2.rs  0% smaller
  migrations/2025-01-07-101337_global_sr_connector_dynamic_routing/down.sql Unsupported file format
  migrations/2025-01-07-101337_global_sr_connector_dynamic_routing/up.sql Unsupported file format
  proto/success_rate.proto Unsupported file format

@Chethan-rao
Copy link
Contributor

Chethan-rao commented Dec 30, 2024 •
edited
Loading

there's conflicts too. please add test cases as well

Chethan-rao
Chethan-rao requested changes Dec 30, 2024
View reviewed changes
crates/api_models/src/routing.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments/routing.rs Outdated Show resolved Hide resolved
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jan 2, 2025
@Sarthak1799 Sarthak1799 linked an issue Jan 3, 2025 that may be closed by this pull request
[FEATURE] Integrate global SR #6987
Closed
2 tasks
@hyperswitch-bot hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Jan 7, 2025
Chethan-rao
Chethan-rao previously approved these changes Jan 15, 2025
View reviewed changes
NishantJoshi00
NishantJoshi00 previously approved these changes Jan 16, 2025
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 39d2d6c Jan 21, 2025
17 of 19 checks passed
@likhinbopanna likhinbopanna deleted the global-sr-integration branch January 21, 2025 12:16
pixincreate added a commit that referenced this pull request Jan 24, 2025
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into refactor-ad…
cbe621c 
…d-memory-cache

* 'main' of github.com:juspay/hyperswitch: (38 commits)
  fix(cypress): uncaught exceptions thrown by `hyperswitch.io` (#7092)
  ci(workflows): Add code coverage reporting for v2 (#6884)
  chore(version): 2025.01.23.0
  refactor: [CYBERSOURCE, BANKOFAMERICA, WELLSFARGO] Move code to crate hyperswitch_connectors (#6908)
  Documentation edits made through Mintlify web editor
  chore: enable 128-column-tables feature for diesel crate (#6857)
  feat(connector): [ADYEN ] Consume transaction id for PaymentsPreProcessing error (#7061)
  chore(version): 2025.01.22.0
  feat(routing): Integrate global success rates (#6950)
  feat(email): Add mailhog by default in docker-compose for local smtp server (#6869)
  refactor: check allowed payment method types in enabled options (#7019)
  feat(router): add payment method-specific features to connector feature list (#6963)
  Refactor: Customer email and browser Information (#7034)
  feat(connectors): fiuu,novalnet,worldpay - extend NTI flows (#6946)
  fix(cypress): address cybersource redirection inconsistency (#7057)
  chore(version): 2025.01.21.0
  refactor(payment-link): use shouldRemoveBeforeUnloadEvents flag for handling removal of beforeunload events through SDK (#7072)
  refactor(router): refactor ctp flow to fetch mca_id and get the connector creds instead of connector_name (#6859)
  chore(version): 2025.01.20.0
  fix(relay): populate connector metadata in the refunds flow (#7045)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prajjwalkumar17 prajjwalkumar17 prajjwalkumar17 left review comments

@Chethan-rao Chethan-rao Chethan-rao approved these changes

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

Assignees

@Sarthak1799 Sarthak1799

Labels
M-api-contract-changes Metadata: This PR involves API contract changes M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Integrate global SR
5 participants
@Sarthak1799 @Chethan-rao @NishantJoshi00 @prajjwalkumar17 @likhinbopanna