-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(payment-link): use shouldRemoveBeforeUnloadEvents flag for handling removal of beforeunload events through SDK #7072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andling removal of beforeunload events through SDK
Changed Files |
PritishBudhiraja
approved these changes
Jan 20, 2025
hrithikesh026
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No core changes
pixincreate
added a commit
that referenced
this pull request
Jan 20, 2025
…urce-inconsistency * 'main' of github.com:juspay/hyperswitch: refactor(payment-link): use shouldRemoveBeforeUnloadEvents flag for handling removal of beforeunload events through SDK (#7072) refactor(router): refactor ctp flow to fetch mca_id and get the connector creds instead of connector_name (#6859)
14 tasks
14 tasks
pixincreate
added a commit
that referenced
this pull request
Jan 24, 2025
…d-memory-cache * 'main' of github.com:juspay/hyperswitch: (38 commits) fix(cypress): uncaught exceptions thrown by `hyperswitch.io` (#7092) ci(workflows): Add code coverage reporting for v2 (#6884) chore(version): 2025.01.23.0 refactor: [CYBERSOURCE, BANKOFAMERICA, WELLSFARGO] Move code to crate hyperswitch_connectors (#6908) Documentation edits made through Mintlify web editor chore: enable 128-column-tables feature for diesel crate (#6857) feat(connector): [ADYEN ] Consume transaction id for PaymentsPreProcessing error (#7061) chore(version): 2025.01.22.0 feat(routing): Integrate global success rates (#6950) feat(email): Add mailhog by default in docker-compose for local smtp server (#6869) refactor: check allowed payment method types in enabled options (#7019) feat(router): add payment method-specific features to connector feature list (#6963) Refactor: Customer email and browser Information (#7034) feat(connectors): fiuu,novalnet,worldpay - extend NTI flows (#6946) fix(cypress): address cybersource redirection inconsistency (#7057) chore(version): 2025.01.21.0 refactor(payment-link): use shouldRemoveBeforeUnloadEvents flag for handling removal of beforeunload events through SDK (#7072) refactor(router): refactor ctp flow to fetch mca_id and get the connector creds instead of connector_name (#6859) chore(version): 2025.01.20.0 fix(relay): populate connector metadata in the refunds flow (#7045) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR enables a flag which enables HyperSwitch SDK to handle removal of
beforeunload
events based on it's consumption by the integrating merchants.Additional Changes
Motivation and Context
This PR enables handling of removal of
beforeunload
events once checkout form is submitted by the user. Helps keep a clean user experience.How did you test it?
Tested locally using payment links.
Checklist
cargo +nightly fmt --all
cargo clippy