Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(payment-link): use shouldRemoveBeforeUnloadEvents flag for handling removal of beforeunload events through SDK #7072

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

kashif-m
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR enables a flag which enables HyperSwitch SDK to handle removal of beforeunload events based on it's consumption by the integrating merchants.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

This PR enables handling of removal of beforeunload events once checkout form is submitted by the user. Helps keep a clean user experience.

How did you test it?

Tested locally using payment links.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

…andling removal of beforeunload events through SDK
@kashif-m kashif-m self-assigned this Jan 20, 2025
@kashif-m kashif-m requested a review from a team as a code owner January 20, 2025 09:38
Copy link

semanticdiff-com bot commented Jan 20, 2025

Copy link
Contributor

@hrithikesh026 hrithikesh026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No core changes

@SanchithHegde SanchithHegde merged commit 776ed9a into main Jan 20, 2025
19 of 20 checks passed
@SanchithHegde SanchithHegde deleted the 7071-payment-link-beforeunload-flag branch January 20, 2025 13:23
pixincreate added a commit that referenced this pull request Jan 20, 2025
…urce-inconsistency

* 'main' of github.com:juspay/hyperswitch:
  refactor(payment-link): use shouldRemoveBeforeUnloadEvents flag for handling removal of beforeunload events through SDK (#7072)
  refactor(router): refactor ctp flow to fetch mca_id and get the connector creds instead of connector_name (#6859)
kashif-m added a commit that referenced this pull request Jan 20, 2025
…andling removal of beforeunload events through SDK (#7072)

(cherry picked from commit 776ed9a)
kashif-m added a commit that referenced this pull request Jan 22, 2025
…andling removal of beforeunload events through SDK (#7072)

(cherry picked from commit 776ed9a)
pixincreate added a commit that referenced this pull request Jan 24, 2025
…d-memory-cache

* 'main' of github.com:juspay/hyperswitch: (38 commits)
  fix(cypress): uncaught exceptions thrown by `hyperswitch.io` (#7092)
  ci(workflows): Add code coverage reporting for v2 (#6884)
  chore(version): 2025.01.23.0
  refactor: [CYBERSOURCE, BANKOFAMERICA, WELLSFARGO] Move code to crate hyperswitch_connectors (#6908)
  Documentation edits made through Mintlify web editor
  chore: enable 128-column-tables feature for diesel crate (#6857)
  feat(connector): [ADYEN ] Consume transaction id for PaymentsPreProcessing error (#7061)
  chore(version): 2025.01.22.0
  feat(routing): Integrate global success rates (#6950)
  feat(email): Add mailhog by default in docker-compose for local smtp server (#6869)
  refactor: check allowed payment method types in enabled options (#7019)
  feat(router): add payment method-specific features to connector feature list (#6963)
  Refactor: Customer email and browser Information (#7034)
  feat(connectors): fiuu,novalnet,worldpay - extend NTI flows (#6946)
  fix(cypress): address cybersource redirection inconsistency (#7057)
  chore(version): 2025.01.21.0
  refactor(payment-link): use shouldRemoveBeforeUnloadEvents flag for handling removal of beforeunload events through SDK (#7072)
  refactor(router): refactor ctp flow to fetch mca_id and get the connector creds instead of connector_name (#6859)
  chore(version): 2025.01.20.0
  fix(relay): populate connector metadata in the refunds flow (#7045)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INTEGRATION] update payment link's integration to handle beforeunload events
4 participants