Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(storagenode): check log level #411

Merged
merged 1 commit into from
Jun 1, 2023
Merged

perf(storagenode): check log level #411

merged 1 commit into from
Jun 1, 2023

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Apr 11, 2023

What this PR does

This PR slightly improves the storage node's performance by checking the log level, making the
logger not make slices in advance.

Copy link
Member

@hungryjang hungryjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how much it helps performance, but it seems to be very poor in usability.

@ijsong
Copy link
Member Author

ijsong commented Apr 14, 2023

I don't know how much it helps performance, but it seems to be very poor in usability.

Yeah, it is too micro-optimization to recognize it.

This PR slightly improves the storage node's performance by checking the log level, making the
logger not make slices in advance.
@ijsong
Copy link
Member Author

ijsong commented Jun 1, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from bump_etcd_version to main June 1, 2023 05:26
@ijsong ijsong merged commit da1409d into main Jun 1, 2023
@ijsong ijsong deleted the check_log_level branch June 1, 2023 05:26
@ijsong
Copy link
Member Author

ijsong commented Jun 1, 2023

@ijsong merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants