-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(storagenode): estimate the number of batchlets #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2023
ijsong
force-pushed
the
unary_rpc_logging
branch
from
April 13, 2023 13:23
51494e9
to
d928d2c
Compare
ijsong
force-pushed
the
append_batchlet_size
branch
from
April 13, 2023 13:23
546b9b9
to
430808b
Compare
ijsong
force-pushed
the
unary_rpc_logging
branch
from
April 13, 2023 13:43
d928d2c
to
467ee59
Compare
ijsong
force-pushed
the
append_batchlet_size
branch
from
April 13, 2023 13:43
430808b
to
a329065
Compare
hungryjang
approved these changes
Apr 14, 2023
ijsong
force-pushed
the
unary_rpc_logging
branch
from
April 15, 2023 13:18
467ee59
to
a7dd5e9
Compare
ijsong
force-pushed
the
append_batchlet_size
branch
from
April 15, 2023 13:18
a329065
to
5c97657
Compare
ijsong
force-pushed
the
unary_rpc_logging
branch
from
April 25, 2023 12:13
a7dd5e9
to
12e5586
Compare
ijsong
force-pushed
the
append_batchlet_size
branch
from
April 25, 2023 12:13
5c97657
to
c2975b2
Compare
ijsong
force-pushed
the
append_batchlet_size
branch
from
May 16, 2023 14:54
c2975b2
to
39fcf2e
Compare
This was referenced May 16, 2023
This PR estimates the number of batchlets more accurately. Previously, the number of batchlets is estimated by dividing the size of batches by the smallest batchlet. It is now divided by the right size of batchlet.
ijsong
force-pushed
the
append_batchlet_size
branch
from
June 1, 2023 03:31
39fcf2e
to
3c91b62
Compare
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR estimates the number of batchlets more accurately. Previously, the number of batchlets is
estimated by dividing the size of batches by the smallest batchlet. It is now divided by the right
size of batchlet.