Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Specify what change was made to a document in event message #438

Merged
merged 1 commit into from
Jul 30, 2020
Merged

✨ Specify what change was made to a document in event message #438

merged 1 commit into from
Jul 30, 2020

Conversation

XuTheBunny
Copy link
Contributor

@XuTheBunny XuTheBunny commented Jul 30, 2020 •
edited
Loading

image
Closes #435

@XuTheBunny XuTheBunny self-assigned this Jul 30, 2020
@XuTheBunny XuTheBunny added bug Something isn't working refactor Something needs to be done better labels Jul 30, 2020
@XuTheBunny XuTheBunny force-pushed the refactor-event-message branch 2 times, most recently from dfb6ee8 to 30d4563 Compare July 30, 2020 03:18
@XuTheBunny XuTheBunny removed the bug Something isn't working label Jul 30, 2020
@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited
Loading

Codecov Report

Merging #438 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
+ Coverage   91.18%   91.21%   +0.02%     
==========================================
  Files          49       49              
  Lines        2733     2742       +9     
==========================================
+ Hits         2492     2501       +9     
  Misses        241      241
Impacted Files Coverage Δ
creator/files/schema/file.py 94.11% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06be010...773b75c. Read the comment docs.

dankolbman
dankolbman reviewed Jul 30, 2020
View reviewed changes
creator/files/schema/file.py
file.tags = kwargs.get("tags")
file.save()
except ClientError:
raise GraphQLError("Failed to save file mutation.")

# Make an update event
message = f"{user.username} updated file {file.kf_id}"
message = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is ok to leave an event even though none of the mutable fields are modified. The updated field is still modified so I would say it's ok, though we may consider not updating at all or making an event if nothing changed.

dankolbman
dankolbman approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@dankolbman dankolbman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@XuTheBunny XuTheBunny merged commit 6482709 into master Jul 30, 2020
@XuTheBunny XuTheBunny deleted the refactor-event-message branch July 30, 2020 20:13
dankolbman added a commit that referenced this pull request Aug 7, 2020
@dankolbman
🏷️ Release 1.14.0
7d08879 
## Release 1.14.0

### Summary

- Emojis: 🐛 x2, ♻️ x3, ✅ x2, 🔧 x1, ✨ x1
- Categories: Fixes x2, Other Changes x6, Additions x1

### New features and changes

- [#433](#433) - 🐛 Fix file link in slack updates - [4266f2f](4266f2f) by [XuTheBunny](https://github.com/XuTheBunny)
- [#446](#446) - ♻️ Replace usernames in events with full names - [c9d459b](c9d459b) by [XuTheBunny](https://github.com/XuTheBunny)
- [#444](#444) - ✅ Add test for model strings - [2b02f77](2b02f77) by [dankolbman](https://github.com/dankolbman)
- [#445](#445) - ♻️ Refactor schemas - [faf2d40](faf2d40) by [dankolbman](https://github.com/dankolbman)
- [#443](#443) - ✅ Add test for unfound nodes - [d47e2a4](d47e2a4) by [dankolbman](https://github.com/dankolbman)
- [#442](#442) - 🔧 Increase task queue timeouts - [013dd82](013dd82) by [dankolbman](https://github.com/dankolbman)
- [#437](#437) - ♻️ Shift slack messages timestamp to be US/Eastern timezone - [ade3020](ade3020) by [XuTheBunny](https://github.com/XuTheBunny)
- [#438](#438) - ✨ Specify what change was made to a document in event message - [6482709](6482709) by [XuTheBunny](https://github.com/XuTheBunny)
- [#439](#439) - 🐛 Fix referral token event message with f-string - [06be010](06be010) by [XuTheBunny](https://github.com/XuTheBunny)
@dankolbman dankolbman mentioned this pull request Aug 7, 2020
Merged
alubneuski pushed a commit that referenced this pull request Sep 3, 2020
@dankolbman
parent c9d459b
30d9241 
author Dan Kolbman <dankolbman@gmail.com> 1596824304 -0400
committer Alex Lubneuski <jenkins@d3b.center> 1599161926 -0400

:label: Release 1.14.0

- Emojis: 🐛 x2, ♻️ x3, ✅ x2, 🔧 x1, ✨ x1
- Categories: Fixes x2, Other Changes x6, Additions x1

- [#433](#433) - 🐛 Fix file link in slack updates - [4266f2f](4266f2f) by [XuTheBunny](https://github.com/XuTheBunny)
- [#446](#446) - ♻️ Replace usernames in events with full names - [c9d459b](c9d459b) by [XuTheBunny](https://github.com/XuTheBunny)
- [#444](#444) - ✅ Add test for model strings - [2b02f77](2b02f77) by [dankolbman](https://github.com/dankolbman)
- [#445](#445) - ♻️ Refactor schemas - [faf2d40](faf2d40) by [dankolbman](https://github.com/dankolbman)
- [#443](#443) - ✅ Add test for unfound nodes - [d47e2a4](d47e2a4) by [dankolbman](https://github.com/dankolbman)
- [#442](#442) - 🔧 Increase task queue timeouts - [013dd82](013dd82) by [dankolbman](https://github.com/dankolbman)
- [#437](#437) - ♻️ Shift slack messages timestamp to be US/Eastern timezone - [ade3020](ade3020) by [XuTheBunny](https://github.com/XuTheBunny)
- [#438](#438) - ✨ Specify what change was made to a document in event message - [6482709](6482709) by [XuTheBunny](https://github.com/XuTheBunny)
- [#439](#439) - 🐛 Fix referral token event message with f-string - [06be010](06be010) by [XuTheBunny](https://github.com/XuTheBunny)

:construction: Modified Jenkinsfiles
:wrench: Added JenkinsfileWorker

Added debugging statements

Removed bin/bash

:wrench: Added additional cert

:arrow_up: Upgrade redis dependencies

:bug: Correctly handle boolean settings

:bug: Add missing import

✨ Accept .xls file type for file analysis

✅ Update test for file format including xls

:recycle: Add study relation to versions

:card_file_box: Add study field to versions

:sparkles: Add createFile mutation

:recycle: Save version in transaction

:white_check_mark: Update test fixtures for new flow

:white_check_mark: Update analysis tests for new flow

:white_check_mark: Update event tests for new flow

:white_check_mark: Update upload tests for new flow

:fire: Deprecate direct file upload

:fire: Remove unused exception

The exception for boto errors should never be hit as the contained code
never utilizes boto.

:white_check_mark: Add tests

:pencil2: Fix app name for permission

:recycle: Do not return abandoned versions when listing

:sparkles: Allow version to be updated with new file

:white_check_mark: Add tests for linking version

:bug: Determine study from version or file

:white_check_mark: Increase analysis testing

:label: Release 1.14.1

- Emojis: 🐛 x1, ♻️ x1, ✨ x2, 🔧 x2, 🔥 x1
- Categories: Fixes x1, Other Changes x3, Additions x2, Removals x1

- [#457](#457) - 🐛 Determine study from version or file - [642c1ae](642c1ae) by [dankolbman](https://github.com/dankolbman)
- [#455](#455) - ♻️ Refactor document upload flow - [f825f58](f825f58) by [dankolbman](https://github.com/dankolbman)
- [#456](#456) - ✨ Accept .xls file type for file analysis - [c76d4d4](c76d4d4) by [XuTheBunny](https://github.com/XuTheBunny)
- [#454](#454) - 🔧 Dev Ops upgrades - [21e2d4a](21e2d4a) by [dankolbman](https://github.com/dankolbman)
- [#452](#452) - 🔧 Add SSL setting to RQ config - [03fd0c5](03fd0c5) by [dankolbman](https://github.com/dankolbman)
- [#449](#449) - ✨ File analyses - [c2e5a87](c2e5a87) by [dankolbman](https://github.com/dankolbman)
- [#450](#450) - 🔥 Remove vault - [4d6dc93](4d6dc93) by [dankolbman](https://github.com/dankolbman)

:bug: Check view_my_version permissions for downloads

:label: Release 1.14.2

- Emojis: 🐛 x1
- Categories: Fixes x1

- [#459](#459) - 🐛 Check view_my_version permissions for downloads - [6a8cad5](6a8cad5) by [dankolbman](https://github.com/dankolbman)

:sparkles: Validate document when saving

:sparkles: Add error handler for django validation

:white_check_mark: Add file_type validation tests

:card_file_box: Add migration for new file type

:recycle: Use explicit enum instead of graphene's

:sparkles: Add valid_types property to documents

:sparkles: Add valid_types to version

:bug: Catch UUID exceptions for tokens

:recycle: Make validation error formatting more precise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dankolbman dankolbman dankolbman approved these changes

Assignees

@XuTheBunny XuTheBunny

Labels
refactor Something needs to be done better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify what change was made to a document
2 participants
@XuTheBunny @dankolbman