♻️ Refactor document upload flow #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
+ Coverage 92.33% 92.58% +0.24%
==========================================
Files 67 67
Lines 3119 3154 +35
==========================================
+ Hits 2880 2920 +40
+ Misses 239 234 -5
Continue to review full report at Codecov.
|
dankolbman
force-pushed
the
upload-save-flow
branch
2 times, most recently
from
9f025c3 to
7a5eb61
Compare
dankolbman
force-pushed
the
upload-save-flow
branch
2 times, most recently
from
6dd3aef to
f14a7db
Compare
The exception for boto errors should never be hit as the contained code never utilizes boto.
dankolbman
force-pushed
the
upload-save-flow
branch
from
f14a7db to
f9d19d6
Compare
dankolbman
added a commit
that referenced
this pull request
Aug 26, 2020
## Release 1.14.1 ### Summary - Emojis: 🐛 x1, ♻️ x1, ✨ x2, 🔧 x2, 🔥 x1 - Categories: Fixes x1, Other Changes x3, Additions x2, Removals x1 ### New features and changes - [#457](#457) - 🐛 Determine study from version or file - [642c1ae](642c1ae) by [dankolbman](https://github.com/dankolbman) - [#455](#455) - ♻️ Refactor document upload flow - [f825f58](f825f58) by [dankolbman](https://github.com/dankolbman) - [#456](#456) - ✨ Accept .xls file type for file analysis - [c76d4d4](c76d4d4) by [XuTheBunny](https://github.com/XuTheBunny) - [#454](#454) - 🔧 Dev Ops upgrades - [21e2d4a](21e2d4a) by [dankolbman](https://github.com/dankolbman) - [#452](#452) - 🔧 Add SSL setting to RQ config - [03fd0c5](03fd0c5) by [dankolbman](https://github.com/dankolbman) - [#449](#449) - ✨ File analyses - [c2e5a87](c2e5a87) by [dankolbman](https://github.com/dankolbman) - [#450](#450) - 🔥 Remove vault - [4d6dc93](4d6dc93) by [dankolbman](https://github.com/dankolbman)
Merged
alubneuski
pushed a commit
that referenced
this pull request
Sep 3, 2020
author Dan Kolbman <dankolbman@gmail.com> 1596824304 -0400 committer Alex Lubneuski <jenkins@d3b.center> 1599161926 -0400 :label: Release 1.14.0 - Emojis: 🐛 x2, ♻️ x3, ✅ x2, 🔧 x1, ✨ x1 - Categories: Fixes x2, Other Changes x6, Additions x1 - [#433](#433) - 🐛 Fix file link in slack updates - [4266f2f](4266f2f) by [XuTheBunny](https://github.com/XuTheBunny) - [#446](#446) - ♻️ Replace usernames in events with full names - [c9d459b](c9d459b) by [XuTheBunny](https://github.com/XuTheBunny) - [#444](#444) - ✅ Add test for model strings - [2b02f77](2b02f77) by [dankolbman](https://github.com/dankolbman) - [#445](#445) - ♻️ Refactor schemas - [faf2d40](faf2d40) by [dankolbman](https://github.com/dankolbman) - [#443](#443) - ✅ Add test for unfound nodes - [d47e2a4](d47e2a4) by [dankolbman](https://github.com/dankolbman) - [#442](#442) - 🔧 Increase task queue timeouts - [013dd82](013dd82) by [dankolbman](https://github.com/dankolbman) - [#437](#437) - ♻️ Shift slack messages timestamp to be US/Eastern timezone - [ade3020](ade3020) by [XuTheBunny](https://github.com/XuTheBunny) - [#438](#438) - ✨ Specify what change was made to a document in event message - [6482709](6482709) by [XuTheBunny](https://github.com/XuTheBunny) - [#439](#439) - 🐛 Fix referral token event message with f-string - [06be010](06be010) by [XuTheBunny](https://github.com/XuTheBunny) :construction: Modified Jenkinsfiles :wrench: Added JenkinsfileWorker Added debugging statements Removed bin/bash :wrench: Added additional cert :arrow_up: Upgrade redis dependencies :bug: Correctly handle boolean settings :bug: Add missing import ✨ Accept .xls file type for file analysis ✅ Update test for file format including xls :recycle: Add study relation to versions :card_file_box: Add study field to versions :sparkles: Add createFile mutation :recycle: Save version in transaction :white_check_mark: Update test fixtures for new flow :white_check_mark: Update analysis tests for new flow :white_check_mark: Update event tests for new flow :white_check_mark: Update upload tests for new flow :fire: Deprecate direct file upload :fire: Remove unused exception The exception for boto errors should never be hit as the contained code never utilizes boto. :white_check_mark: Add tests :pencil2: Fix app name for permission :recycle: Do not return abandoned versions when listing :sparkles: Allow version to be updated with new file :white_check_mark: Add tests for linking version :bug: Determine study from version or file :white_check_mark: Increase analysis testing :label: Release 1.14.1 - Emojis: 🐛 x1, ♻️ x1, ✨ x2, 🔧 x2, 🔥 x1 - Categories: Fixes x1, Other Changes x3, Additions x2, Removals x1 - [#457](#457) - 🐛 Determine study from version or file - [642c1ae](642c1ae) by [dankolbman](https://github.com/dankolbman) - [#455](#455) - ♻️ Refactor document upload flow - [f825f58](f825f58) by [dankolbman](https://github.com/dankolbman) - [#456](#456) - ✨ Accept .xls file type for file analysis - [c76d4d4](c76d4d4) by [XuTheBunny](https://github.com/XuTheBunny) - [#454](#454) - 🔧 Dev Ops upgrades - [21e2d4a](21e2d4a) by [dankolbman](https://github.com/dankolbman) - [#452](#452) - 🔧 Add SSL setting to RQ config - [03fd0c5](03fd0c5) by [dankolbman](https://github.com/dankolbman) - [#449](#449) - ✨ File analyses - [c2e5a87](c2e5a87) by [dankolbman](https://github.com/dankolbman) - [#450](#450) - 🔥 Remove vault - [4d6dc93](4d6dc93) by [dankolbman](https://github.com/dankolbman) :bug: Check view_my_version permissions for downloads :label: Release 1.14.2 - Emojis: 🐛 x1 - Categories: Fixes x1 - [#459](#459) - 🐛 Check view_my_version permissions for downloads - [6a8cad5](6a8cad5) by [dankolbman](https://github.com/dankolbman) :sparkles: Validate document when saving :sparkles: Add error handler for django validation :white_check_mark: Add file_type validation tests :card_file_box: Add migration for new file type :recycle: Use explicit enum instead of graphene's :sparkles: Add valid_types property to documents :sparkles: Add valid_types to version :bug: Catch UUID exceptions for tokens :recycle: Make validation error formatting more precise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the new document flow to be a two step process.
Versions are no longer required to be linked to a document when created, but must be linked to at least a study.
Versions may be updated later to connect to a document, or an existing version may be specified when creating a new document.