-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ukrainian localization #20020
Add Ukrainian localization #20020
Conversation
* Initial commit for Ukrainian localization * Fix misspell and crosslink * Add Nikita Potapenko to PR reviewers kubernetes#18569 (comment) Co-authored-by: Anastasiya Kulyk <56824659+anastyakulyk@users.noreply.github.com>
* Localize front page * Localize heading and subheading URLs Close #6 Close #11 * Uk translation for k8s basics Close #9 * Uk localization homepage PR: #102 * Buildable version of the Ukrainian website * Adding localized content of the what-is-kubernetes.md Close #12 * Localizing site strings in toml file * Localizing tutorials Close #32 * Localizing templates * Localize glossary terms Close #2 * Create glossary for UK contributors Close #101 * Add butuzov to dream team Co-authored-by: Anastasiya Kulyk <nastya.kulyk@gmail.com> Co-Authored-By: Maksym Vlasov <MaxymVlasov@users.noreply.github.com> Co-authored-by: Oleg Butuzov <butuzov@users.noreply.github.com>
Deploy preview for kubernetes-io-master-staging ready! Built with commit e29dbe4 https://deploy-preview-20020--kubernetes-io-master-staging.netlify.com |
That preview looks good @MaxymVlasov! The new localization needs at least 2 owners that speak Ukrainian well. Owners & reviewers must be members of the Kubernetes organization on GitHub. It looks like this branch is close to being OK to merge. I saw a few nits: there are files in the branch still in English; the owners file does not look valid; and “Home” isn't localized in https://deploy-preview-20020--kubernetes-io-master-staging.netlify.com/uk/docs/home/ However, I have a different concern; this one is less technical and more legal. Accepting a commit into the fork does not mean that it is valid for this project. Prow checks for contributor license agreements; if the fork does not, then a merge from that fork may not be allowed. Maybe there's a case for revising those requirements but, as they stand, the requirement for a CLA is going to be an obstacle there. |
Hi @sftim, thank you for your quick review! 1.
Localization have 3 owners that speak Ukrainian very well, @anastyakulyk also is linguist by education. 2.
Got it. All of us here, except @butuzov, but this will fix soon via this issue. 3.
@anastyakulyk can describe it more, in general - we translate headers of top pages for add it to localization - otherwise is not showing on site (as I remember) though we specified Is this OK for now and we can translate it in future PRs or we should translate all stuff? 4.
Sorry, what you mean? I don't see non-localized stuff in About legal stuff.IMHO, is distracting and if see to many small and big OSS projects, they have no this limitation, because when someone contributing to repo, they automatically agree with In this PR, we have contribution of me (@MaxymVlasov), @anastyakulyk and @butuzov. We all signed CLA so for this PR is is not problem. 5.In future, we can work with k/website In other hand, if I can add Prow bot to fork, I do it. 6.P.S. Also, @idvoretskyi propose separate |
I'll let @sftim speak on this as well, but the OWNERS file should be submitted (and merged) before the actual content (available in the specific language). Right now, the prow bot can't assign this PR to any Ukrainian native language speakers. |
That's unusual. Localizations usually localize entire pages; if you look in other localizations' folders, you should see no English text (apart from words left in the original language because they are technical).
The English word “HOME” appears on the page. Compare this to the Russian localization where you see “ГЛАВНАЯ” instead.
Because there are concerns here, I'm going to discuss them with approvers and make sure there's clear consensus (possibly existing, possible it's new discussion) on the policy and how to apply it. |
@sftim thanks for your comments! |
AIUI, for a minimum localization the left navigation on https://deploy-preview-20020--kubernetes-io-master-staging.netlify.com/uk/docs/setup/ should also be showing as localized. |
One more point. If people work in a fork, I've just realized that this becomes a barrier for new Kubernetes organization members: their contributions don't count towards the requirements for membership of the Kubernetes GitHub organization. Now I've thought of that, I think that's possible a more important concern than the legal paperwork (which is still important). |
@MaxymVlasov we can also log bugs against the localizations that are missing those translations. |
838e132
to
379cd00
Compare
@sftim would it be enough for the start to translate only the headers or do we need to translate the entire documents? |
I think there's a way to localize just the section headings. See for example https://github.com/kubernetes/website/blob/master/content/ko/docs/setup/production-environment/_index.md This whole file is translated. If other files in that folder aren't localized, that's OK for an initial localization. |
Ok, thanks, got it. |
I am catching up on the details here. |
I think, info about needed adding redirect Otherwise folks, when click on 'Documentation home link' it will go to not very useful page like this: Should I create an issue/PR? |
a0592f4
to
42566cc
Compare
42566cc
to
b62cdc1
Compare
/lgtm |
/hold |
“Il meglio è nemico del bene” or perhaps “il meglio è nemico del merged”. So long as the essentials are in place and there are no howlers (major errors), it's OK to merge this even with snags not yet addressed. Let's focus on what needs to happen to get these commits into master. Can this get another /lgtm? Is there anything left to address before that? |
94e9275
to
842c7d1
Compare
* Fix home page name * Remove untranslated * Localize left panel in Getting Started * Fix left menu button on mobile and add redirect * Implement review suggestions Co-authored-by: Anastasiya Kulyk <nastya.kulyk@gmail.com> Co-authored-by: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
842c7d1
to
e29dbe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
+1, let's merge as-is and iterate later. /hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@sftim we'll need your approval superpower :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: idvoretskyi, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/language uk |
What: This PR initialize Ukrainian translation and include all from
dev-1.17-uk.1
branchContributors:
Why we used separate repo for work for startup
If we use bot, it will be create more than 100 messages
Body for
Squash and merge
commit:After merge
After merge this PR to master feel free to remove
dev-1.17-uk.1
branchWhat we do after merge initial commit
In future we would like work into our individual forks and than send PR directly to
master
.And use
kubernetes-i18n-ukrainian
organization as synchronization tool by issue tracking.Thanks!