community: fixed critical bugs at Writer provider #27879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yanomaly
force-pushed
the
fix/writer-main-functionality
branch
from
0619599
to
03a994b
Compare
yanomaly
force-pushed
the
fix/writer-main-functionality
branch
from
03a994b
to
23e35f8
Compare
yanomaly
force-pushed
the
fix/writer-main-functionality
branch
2 times, most recently
from
bccd024
to
212c6d1
Compare
yanomaly
changed the title
dosubot
bot
added
size:XL
efriis
reviewed
Nov 7, 2024
| Optional, | ||
| Sequence, | ||
| Tuple, | ||
| Type, | ||
| Union, | ||
| ) | ||
|
|
||
| from dotenv import load_dotenv |
There was a problem hiding this comment.
let's not use this in the integration - this should be for the end user to do only
There was a problem hiding this comment.
for testing could you import the standard tests instead like https://github.com/langchain-ai/langchain/pull/27645/files#diff-c86d5e9b25ea852938eae1c62bad9708df0cd8c0a75147f3c4a100bdcf73fd28R22-R33
There was a problem hiding this comment.
May you describe which benefits are provided by standard tests?
If it's possible to stay with custom tests?
Thank you!
There was a problem hiding this comment.
it'll catch errors related to the integration not actually implementing the abstraction correctly! e.g. your chat model is documented as supporting streaming, but there are no chat model tests for it
yanomaly
force-pushed
the
fix/writer-main-functionality
branch
from
16bcb25
to
0ca66ad
Compare
dosubot
bot
added
size:XXL
yanomaly
force-pushed
the
fix/writer-main-functionality
branch
from
bcfec3d
to
8897656
Compare
yanomaly
force-pushed
the
fix/writer-main-functionality
branch
3 times, most recently
from
6040d33
to
9798c32
Compare
yanomaly
force-pushed
the
fix/writer-main-functionality
branch
4 times, most recently
from
542519f
to
f2a16b9
Compare
yanomaly
force-pushed
the
fix/writer-main-functionality
branch
from
f2a16b9
to
f01882b
Compare
ccurme
reviewed
Nov 25, 2024
| @@ -17,29 +17,28 @@ | |||
| "source": [ | |||
| "# ChatWriter\n", | |||
| "\n", | |||
| "This notebook provides a quick overview for getting started with Writer [chat models](/docs/concepts/chat_models).\n", | |||
| "This notebook provides a quick overview for getting started with Writer [chat models](/docs/concepts/#chat-models).\n", | |||
| "\n", | |||
| "Writer has several chat models. You can find information about their latest models and their costs, context windows, and supported input types in the [Writer docs](https://dev.writer.com/home/models).\n", | |||
| "\n", | |||
| ":::" | |||
There was a problem hiding this comment.
|
|
||
|
|
||
| @pytest.mark.requires("writerai") | ||
| class TestChatWriterStandart(ChatModelUnitTests): |
ccurme
approved these changes
Nov 25, 2024
dosubot
bot
added
the
lgtm
ccurme
added a commit
that referenced
this pull request
Nov 25, 2024
Library name was updated after #27879 branched off master.
AlwaysBluer
pushed a commit
to AlwaysBluer/langchain
that referenced
this pull request
Nov 27, 2024
… into LindormIntegration * 'LindormIntegration' of github.com:AlwaysBluer/langchain: (72 commits) langchain[patch]: update deprecation message for agent classes and constructors (langchain-ai#28369) Updated docs for the BM25 preprocessing function (langchain-ai#28101) Community: Marqo Index Setting GET Request Updated according to `2.x` API version while keep backward compatability for 1.5.x (langchain-ai#28342) langchain: Fix Neo4jVector vector store reference from partner package for self query (langchain-ai#28292) ollama[patch]: bump to 0.4.1 in lock file (langchain-ai#28365) ollama[patch]: support ollama 0.4 (langchain-ai#28364) openai[patch]: bump core dep (langchain-ai#28361) openai[patch]: Release 0.2.10 (langchain-ai#28360) openai[patch]: use max_completion_tokens in place of max_tokens (langchain-ai#26917) langchain[patch]: support numpy 2 (langchain-ai#28183) docs: update tutorials (langchain-ai#28219) docs[patch]: fix broken anchor link (langchain-ai#28358) docs(create_sql_agent): fix reStructured Text Markup (langchain-ai#28356) Community: Adding citations in AIMessage for ChatPerplexity (langchain-ai#28321) docs: update azure_openai_whisper_parser.ipynb (langchain-ai#28327) community[patch]: fix import in test (langchain-ai#28339) community[patch]: Neo4j community deprecation (langchain-ai#28130) community: fixed critical bugs at Writer provider (langchain-ai#27879) docs: fix GOOGLE_API_KEY typo (langchain-ai#28322) community[patch]: release 0.3.8 (langchain-ai#28316) ...
robbins
pushed a commit
to lucasile/langchain-achroma
that referenced
this pull request
Nov 27, 2024
Library name was updated after langchain-ai#27879 branched off master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.