ollama[patch]: support ollama 0.4 #28364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.4 of the Python SDK is already installed via the lock file in CI, but our current implementation is not compatible with it.
This also addresses an issue introduced in #28299. @RyanMagnuson would you mind explaining the motivation for that change? From what I can tell the Ollama SDK does not support kwargs. Previously, unsupported kwargs were ignored, but they currently raise
TypeError
.Some of LangChain's standard test suite expects
tool_choice
to be supported, so here we catch it inbind_tools
so it is ignored and not passed through to the client.