Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community: Marqo Index Setting GET Request Updated according to 2.x API version while keep backward compatability for 1.5.x #28342

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

keenborder786
Copy link
Contributor

  • Description: add_texts was using get_setting for marqo client which was being used according to 1.5.x API version. However, this PR updates the add_text accounting for updated response payload for 2.x and later while maintaining backward compatibility. Plus I have verified this was the only place where marqo client was not accounting for updated API version.
  • Issue: Marqo.add_texts() throws exception when using Marqo >= v2.0.0 #28323

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 6:24pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. community Related to langchain-community Ɑ: vector store Related to vector store module labels Nov 25, 2024
@keenborder786
Copy link
Contributor Author

@ccurme important

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Nov 26, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 26, 2024
@ccurme ccurme enabled auto-merge (squash) November 26, 2024 18:19
@ccurme ccurme merged commit 06fafc6 into langchain-ai:master Nov 26, 2024
19 checks passed
AlwaysBluer pushed a commit to AlwaysBluer/langchain that referenced this pull request Nov 27, 2024
… into LindormIntegration

* 'LindormIntegration' of github.com:AlwaysBluer/langchain: (72 commits)
  langchain[patch]: update deprecation message for agent classes and constructors (langchain-ai#28369)
  Updated docs for the BM25 preprocessing function (langchain-ai#28101)
  Community: Marqo Index Setting GET Request Updated according to `2.x` API version while keep backward compatability for 1.5.x (langchain-ai#28342)
  langchain: Fix Neo4jVector vector store reference from partner package for self query (langchain-ai#28292)
  ollama[patch]: bump to 0.4.1 in lock file (langchain-ai#28365)
  ollama[patch]: support ollama 0.4 (langchain-ai#28364)
  openai[patch]: bump core dep (langchain-ai#28361)
  openai[patch]: Release 0.2.10 (langchain-ai#28360)
  openai[patch]: use max_completion_tokens in place of max_tokens (langchain-ai#26917)
  langchain[patch]: support numpy 2 (langchain-ai#28183)
  docs: update tutorials (langchain-ai#28219)
  docs[patch]: fix broken anchor link (langchain-ai#28358)
  docs(create_sql_agent): fix reStructured Text Markup (langchain-ai#28356)
  Community: Adding citations in AIMessage for ChatPerplexity (langchain-ai#28321)
  docs: update azure_openai_whisper_parser.ipynb (langchain-ai#28327)
  community[patch]: fix import in test (langchain-ai#28339)
  community[patch]: Neo4j community deprecation (langchain-ai#28130)
  community: fixed critical bugs at Writer provider (langchain-ai#27879)
  docs: fix GOOGLE_API_KEY typo (langchain-ai#28322)
  community[patch]: release 0.3.8 (langchain-ai#28316)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants