fixed realtime #217
Merged
fixed realtime #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readme fixes and global colors
Update landing and welcome email, contrib experience, minor fixes
Improve onboarding, fix eval page placeholder
Explicit mapping in labels + frontend improvements
Labeling queues
parse litellm attributes (#171)
add claude-3-5-haiku to pipeline and prices (#174)
fix evaluations query in labeling queue (#176)
Middleware auth, traces page efficiency
fixed post requests (#185)
improve UI for workspaces + internal fixes
Store label values sent from association properties
Playgrounds v0
* initial work to compare evals * remove unnecessary div * design --------- Co-authored-by: Din <dinmukhamed.mailibay@gmail.com>
disable all clickhouse queries for non-full builds (#213)
update models in pipeline templates to 4o family (#215)
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 1dabce6 in 1 minute and 2 seconds
More details
- Looked at
121lines of code in4files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/app/project/[projectId]/pipelines/[pipelineId]/page.tsx:77
- Draft comment:
TheisSupabaseEnabledprop is passed to thePipelinecomponent but is not used. Ensure it is utilized within the component or remove it if unnecessary. - Reason this comment was not posted:
Comment did not seem useful.
2. frontend/components/pipeline/pipeline.tsx:58
- Draft comment:
TheisSupabaseEnabledprop is passed to thePipelinecomponent but is not used. Ensure it is utilized within the component or remove it if unnecessary. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_I32YQWKjo1lvywsk
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -132,7 +132,7 @@ export default function Pipeline({ pipeline }: PipelineProps) { | |||
| const { supabaseAccessToken, username, imageUrl } = useUserContext(); | |||
|
|
|||
| const supabase = useMemo(() => { | |||
There was a problem hiding this comment.
Add supabaseAccessToken and isSupabaseEnabled to the dependency array of the useMemo hook to ensure it updates correctly when these values change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Added Supabase feature flag handling and minor UI adjustments in pipeline components.
isSupabaseEnabledprop toPipelinecomponent inpage.tsxandpipeline.tsxto check if Supabase feature is enabled.isFeatureEnabled(Feature.SUPABASE)withisSupabaseEnabledinpipeline.tsx.model-select.tsxfor setting API keys.PipelineEnvcomponent inpipeline-header.tsx.pipeline.tsx.selectedVersionvariable inpage.tsx.This description was created by
for 1dabce6. It will automatically update as commits are pushed.