Refactor datatable component to include filter clearing functionality #270
Conversation
Readme fixes and global colors
Update landing and welcome email, contrib experience, minor fixes
Improve onboarding, fix eval page placeholder
Explicit mapping in labels + frontend improvements
Labeling queues
parse litellm attributes (lmnr-ai#171)
add claude-3-5-haiku to pipeline and prices (lmnr-ai#174)
fix evaluations query in labeling queue (lmnr-ai#176)
Middleware auth, traces page efficiency
fixed post requests (lmnr-ai#185)
improve UI for workspaces + internal fixes
Store label values sent from association properties
Playgrounds v0
* initial work to compare evals * remove unnecessary div * design --------- Co-authored-by: Din <dinmukhamed.mailibay@gmail.com>
disable all clickhouse queries for non-full builds (lmnr-ai#213)
update models in pipeline templates to 4o family (lmnr-ai#215)
Fix realtime and manual spans
Labeling queues
Semantic search API, blogs, minor fixes
update rust deps and fix blog images (lmnr-ai#246)
Minor fixes in evals
Allow disabling tracing, search by spans
Events and landing
|
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 8f65322 in 1 minute and 36 seconds
More details
- Looked at
48lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_IyRPITAjPptnnzdd
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
@devansh-m12 LGTM. Can you please attach a screenshot of what it looks like after your last change? |
|
Here, @dinmukhamedm I've implemented the requested changes. To clarify, it removes the filter from the search parameters but does not reset the filter fields, allowing previously applied filters to be re-applied with a single click. you can check recording for refrence. 
Screen.Recording.2024-12-06.at.9.34.21.AM.mov |
|
Awesome, that works great, merging to dev now! |
fixes #269
@dinmukhamedm I've updated the DataTable component to check if a filter exists in the search parameters and is applied. Only then do we have the permission to clear filters."
Important
Adds filter clearing functionality to
DataTablecomponent, allowing users to clear applied filters via a button.clearFiltersfunction indatatable.tsxto remove 'filter' from search parameters and update the URL.TableCellwhen filters are applied and no results are found.usePathname,useRouter, anduseSearchParamsfromnext/navigationindatatable.tsx.This description was created by
for 8f65322. It will automatically update as commits are pushed.