DM-41528: Incorporate the REST spawner and JupyterHub build #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 949ef223f81ffe92a06b7761d0029cdaed92b649.
RSP RestSpawner implementation
…ns/checkout-4 Bump actions/checkout from 3 to 4
- Update pre-commit/pre-commit-hooks pre-commit hook from v4.4.0 to v4.5.0 - Update astral-sh/ruff-pre-commit pre-commit hook from v0.0.291 to v0.0.292
[neophile] Update dependencies
bump hub version
tickets/DM-41198: add postgresql-client to image
- Update astral-sh/ruff-pre-commit pre-commit hook from v0.0.292 to v0.1.1 - Update psf/black pre-commit hook from 23.9.1 to 23.10.0
[neophile] Update dependencies
Update the lab status enum to match the current Nublado controller, including renaming starting to pending. Add support for terminated status, which will be used for labs killed by the idle culler. Update comments for the (soon to be implemented) behavior of the Nublado controller. Treat terminating status the same as terminated: tell the hub that the lab has exited, even though it hasn't yet. We want to allow the user to start spawning a new lab, and if they kick that off before the lab deletion completes, we'll join the existing delete call now that the controller supports multiple simultaneous deletes.
DM-41350: Handle terminating and terminated status
Get somewhat nicer test output.
DM-41350: Update Python dependencies, use pytest-sugar
Remove the mypy and linter configuration, since this can now be done at the top level. Point setuptools_scm at the correct root of the repository for its magic. Update the project URLs and set the development status back to beta for now.
Update Python dependencies for both the controller and the spawner. Pin the version of anyio for the spawner since a newer version breaks the controller (via FastAPI). This is temporary until I redo how dependencies are handled for the JuypterHub build.
Move the top-level Dockerfile to Dockerfile.controller since it only builds the controller, and move its scripts into the controller subdirectory instead of the top level since they'll conflict with the scripts for the spawner.
Eventually the additional modules we add to the spawner will be broken up into separate directories, but for now add the spawner directory with its own frozen dependencies.
Move the Dockerfile in the spawner directory up a level as Dockerfile.hub and integrate that build into GitHub CI. Push that image as nublado-jupyterhub.
Python wants a LICENSE file for pyproject.toml for each Python project, but the overall repository only has one license. Use symlinks to make Python happy.
The spawner code triggers a couple more Ruff errors that seem too prone to false positives.
The module name will change, but tell Ruff this is a first-party module for proper import sorting.
Force Black to use the top-level pyproject.toml for configuration when run with pre-commit instead of finding the pyproject.toml in a subdirectory and then using its defaults for line length since no Black configuration is present there.
Remove GitHub Actions, flake8, .gitignore, pre-commit, Makefile, and tox configuration from the spawner directory, since this is now handled by the top-level configuration.
Update Python and pre-commit dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the rsp-restspawner repository into this repository as a subdirectory and integrate it with the build system. Merge its Ruff exclusions and update Python dependencies.