🌐 New Crowdin updates #1167
🌐 New Crowdin updates #1167
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
WalkthroughThe recent updates span multiple locale files, removing obsolete keys and adding new ones for enhanced user interface articulation. These changes streamline text descriptions, status indicators, and notifications, providing clearer, more intuitive user interactions across different languages. Specific phrases related to polling, events, and account management have been optimized for better understanding and usability. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
apps/web/public/locales/nl/app.json (1)
262-262: The descriptions for empty states are identical. Consider rephrasing one to enhance user experience or confirm if this repetition is intentional.Also applies to: 264-264
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/web/public/locales/nl/app.json (5 hunks)
Additional comments not posted (3)
apps/web/public/locales/nl/app.json (3)
266-266: The term "Poll maken" should be consistent across the application. Verify its usage in other parts of the application to ensure consistency.Verification successful
The term "Poll maken" is used consistently across the application, as it appears only once in the
apps/web/public/locales/nl/app.jsonfile.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistency of the term "Poll maken" across the application. rg --type json '"Poll maken"'Length of output: 96
Script:
#!/bin/bash # Description: Verify consistency of the term "Poll maken" across the entire application, including all file types. rg 'Poll maken'Length of output: 82
253-253: Ensure the HTML tag<b>is intended for use here for emphasizing email. This could affect text styling and accessibility.Verification successful
The usage of the
<b>tag in the string "We hebben een verificatiecode naar {{ email }} gestuurd" is consistent with its usage in other localization files for emphasizing parts of the text. The tag is used similarly in other contexts, such as names, actions, and email addresses, indicating that it is appropriate for this context.
- apps/web/public/locales/nl/app.json: "We hebben een verificatiecode naar {{ email }} gestuurd"
- apps/web/public/locales/en/app.json: "We sent a verification code to {{ email }}"
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if HTML tags are consistently used in similar contexts. rg --type json '<b>'Length of output: 15383
260-260: Ensure that the functionality for copying links is implemented as this string suggests a UI interaction.
| "groupPoll": "Groepsenquête", | ||
| "groupPollDescription": "Deel je beschikbaarheid met een groep mensen en vind de beste tijd om elkaar te ontmoeten.", |
There was a problem hiding this comment.
Tip
Codebase Verification
The translation "Groepsenquête" for "group poll" translates to "Group Survey" according to the online translation API. While "survey" and "poll" are similar, they are not exact synonyms.
apps/web/public/locales/nl/app.json: Consider using "Groepspeiling" instead of "Groepsenquête" for a more accurate translation of "group poll".
Analysis chain
Confirm the translation for "group poll" is accurate and culturally appropriate.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify translation accuracy with a language expert or service.
echo "Confirm translation for 'group poll' in Dutch."
Length of output: 108
Script:
#!/bin/bash
# Search for occurrences of "groupPoll" to understand its context better.
rg "groupPoll"
Length of output: 771
Script:
#!/bin/bash
# Use an online translation API to verify the translation of "Groepsenquête" to "group poll".
curl -s "https://api.mymemory.translated.net/get?q=Groepsenquête&langpair=nl|en" | jq '.responseData.translatedText'
Length of output: 131
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/web/public/locales/hu/app.json (6 hunks)
Additional comments not posted (10)
apps/web/public/locales/hu/app.json (10)
253-253: LGTM! The updated verification code message is clearer and more standard with the use of double curly braces for variable interpolation in localization files.
254-254: LGTM! The new home key is a straightforward addition and is consistent with the rest of the file.
255-256: LGTM! The term 'groupPoll' has been updated to 'groupPollDescription' which better describes its functionality.
257-257: LGTM! The 'create' key is a simple action command, correctly localized.
258-259: LGTM! The terms for upcoming and past events are well-translated and match the intended context.
260-260: LGTM! The 'copyLink' key is essential for user interactions, and its translation appears accurate.
261-262: LGTM! The empty state messages for upcoming events are clear and informative, providing users with guidance on what to expect.
263-264: LGTM! Similar to the upcoming events, the past events empty state messages are well-translated and maintain consistency in user guidance.
265-265: LGTM! The active poll count message correctly uses pluralization logic, which is important for languages with complex plural forms.
266-266: LGTM! The 'createPoll' action is reintroduced and correctly localized.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/web/public/locales/hu/app.json (6 hunks)
Files skipped from review as they are similar to previous changes (1)
- apps/web/public/locales/hu/app.json
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/landing/public/locales/pl/common.json (1 hunks)
- apps/web/public/locales/pl/app.json (8 hunks)
Additional comments not posted (4)
apps/landing/public/locales/pl/common.json (2)
26-26: Update to "howItWorks" appears correct. Ensure consistency across all languages.Verification successful
The script output shows that the key "howItWorks" is translated into multiple languages, including Polish ("Jak to działa"). The translations appear consistent in meaning, indicating the update is correctly applied across different language files.
- "如何使用" (Chinese)
- "Nasıl Çalışır" (Turkish)
- "Rallly的運作方式" (Chinese Traditional)
- "Как это работает" (Russian)
- "วิธีการทำงาน" (Thai)
- "Como Funciona" (Portuguese)
- "Slik fungerer det" (Norwegian)
- "Jak to działa" (Polish)
- "이용 방법" (Korean)
- "Hoe het werkt" (Dutch)
- "Come funziona" (Italian)
- "Näin se toimii" (Finnish)
- "Hogyan mükődik" (Hungarian)
- "Comment ça fonctionne" (French)
- "Cómo funciona" (Spanish)
- "Ako to funguje" (Slovak)
- "Nola funtzionatzen duen" (Basque)
- "Jak to funguje" (Czech)
- "Com funciona" (Catalan)
- "Sådan virker det" (Danish)
- "So funktioniert's" (German)
- "How it Works" (English)
Given that the translations are consistent in meaning, the update to the Polish translation "Jak to działa" is correct.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistency of "howItWorks" across all language files. # Test: Search for "howItWorks" in all JSON files under `locales`. Expect: Consistent translations. fd '.*\.json' apps/landing/public/locales/ --exec rg '"howItWorks":'Length of output: 795
27-27: New entry "status" added. Verify its usage in the application.Verification successful
The new entry "status" is used in the application's TypeScript and JSX files as shown by the following snippets:
const pollStatusQueryKey = "status";<Trans i18nKey="status" defaults="Status" />This confirms that the new entry is indeed being utilized within the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify usage of "status" in the application's codebase. # Test: Search for "status" in the application's JavaScript files. Expect: Usage of this key. fd '\.js$' apps/ --exec rg '"status"'Length of output: 39
Script:
#!/bin/bash # Description: Verify usage of "status" in the application's codebase. # Test: Search for "status" in the application's TypeScript and JSX files. Expect: Usage of this key. fd '\.(ts|tsx|jsx)$' apps/ --exec rg '"status"'Length of output: 147
apps/web/public/locales/pl/app.json (2)
116-116: Update to "pollStatusOpen" appears correct. Ensure consistency across all languages.Verification successful
The translation "Aktywna" for "pollStatusOpen" in Polish is consistent with the context provided by other translations across different languages.
- "啟用中" (Chinese) - Active
- "Canlı" (Turkish) - Live
- "Активен" (Russian) - Active
- "Naživo" (Slovak) - Live
- "Ativo" (Portuguese) - Active
- "Aktiv" (German) - Active
- "실시간" (Korean) - Real-time
- "Live" (English)
- "Aktív" (Hungarian) - Active
- "Diretta" (Italian) - Live
- "Käynnissä" (Finnish) - Ongoing
- "Zuzenean" (Basque) - Direct
- "En vivo" (Spanish) - Live
- "Aktivno" (Slovenian) - Active
- "Probíhá" (Czech) - Ongoing
- "En ligne" (French) - Online
- "En viu" (Catalan) - Live
Given this context, the translation "Aktywna" (Polish) correctly conveys the status of being active or live.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistency of "pollStatusOpen" across all language files. # Test: Search for "pollStatusOpen" in all JSON files under `locales`. Expect: Consistent translations. fd '.*\.json' apps/web/public/locales/ --exec rg '"pollStatusOpen":'Length of output: 722
253-266: Multiple new entries added. Verify their integration and usage in the application.Verification successful
The new script successfully found the usage of the new keys in the application's codebase. Here are the relevant findings:
verificationCodeSentTohomegroupPollgroupPollDescriptioncreateupcomingpastcopyLinkupcomingEventsEmptyStateTitleupcomingEventsEmptyStateDescriptionpastEventsEmptyStateTitlepastEventsEmptyStateDescriptionactivePollCountcreatePollThese keys are indeed being used in the JavaScript and TypeScript files, confirming their integration.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify usage of new entries in the application's codebase. # Test: Search for new keys like "home", "groupPoll" in the application's JavaScript files. Expect: Usage of these keys. fd '\.js$' apps/web/ --exec rg '"home"|"groupPoll"'Length of output: 53
Script:
#!/bin/bash # Description: Verify usage of new entries in the application's codebase. # Test: Search for new keys in the application's JavaScript and TypeScript files. Expect: Usage of these keys. fd '\.jsx?$|\.tsx?$' apps/web/ --exec rg '"verificationCodeSentTo"|"home"|"groupPoll"|"groupPollDescription"|"create"|"upcoming"|"past"|"copyLink"|"upcomingEventsEmptyStateTitle"|"upcomingEventsEmptyStateDescription"|"pastEventsEmptyStateTitle"|"pastEventsEmptyStateDescription"|"activePollCount"|"createPoll"'Length of output: 1658
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/web/public/locales/es/app.json (5 hunks)
Additional comments not posted (5)
apps/web/public/locales/es/app.json (5)
232-232: The modification to"timeShownIn"enhances clarity by explicitly formatting time based on user's timezone. Good improvement.
233-233: Addition of"eventHostDescription"provides clear information about the role of the user in the context of the event. This is a beneficial addition for user understanding.
234-234: The addition of"deleteAccount"empowers users by providing them direct control over their account data, aligning with good data privacy practices.
235-235: Updating"verificationCodeSentTo"to use variable placeholders enhances message clarity and flexibility, improving the user's experience during the verification process.
236-236: Modifying"createPoll"to clarify the action enhances user understanding and interaction with the poll creation feature.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/web/public/locales/sv/app.json (4 hunks)
Additional comments not posted (8)
apps/web/public/locales/sv/app.json (8)
224-224: The "home" key has been added, translating to "Startsidan". This should align with navigational elements in the UI that direct users to the home page.
225-226: Added "groupPoll" and "groupPollDescription" keys for group polls. Verify that these new keys are integrated into the relevant parts of the application where group polls are managed or displayed.Verification successful
The keys "groupPoll" and "groupPollDescription" are integrated into the application, as evidenced by their usage in the
dashboard.tsxandpage.tsxfiles.
apps/web/src/app/[locale]/(admin)/dashboard.tsxapps/web/src/app/[locale]/new/page.tsxScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Ensure that "groupPoll" and "groupPollDescription" are integrated into the application. # Test: Search for the usage of "groupPoll" and "groupPollDescription" in the application code. rg --type js --type html $'groupPoll|groupPollDescription'Length of output: 59
Script:
#!/bin/bash # Description: Ensure that "groupPoll" and "groupPollDescription" are integrated into the application. # Test: Search for the usage of "groupPoll" and "groupPollDescription" in the application code, including additional file types. rg --type js --type ts --type html --type json --type yaml $'groupPoll|groupPollDescription'Length of output: 1526
235-235: Added a dynamic placeholder for "activePollCount". This needs to be integrated with the backend to display the correct number of active polls. Ensure backend integration is completed.
[APROVED]Verification successful
The search results indicate that the backend integration for "activePollCount" is already in place. The relevant code can be found in
packages/backend/trpc/routers/dashboard.tswhere the active poll count is fetched from the database and returned. Additionally, the integration in the frontend is evident inapps/web/src/app/[locale]/(admin)/dashboard.tsx.
packages/backend/trpc/routers/dashboard.ts: Backend code fetching the active poll count.apps/web/src/app/[locale]/(admin)/dashboard.tsx: Frontend code integrating the active poll count.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Ensure backend integration for "activePollCount". # Test: Search for the backend integration of "activePollCount". rg --type js --type html $'activePollCount'Length of output: 42
Script:
#!/bin/bash # Description: Ensure backend integration for "activePollCount". # Test: Search for the backend integration of "activePollCount" across all file types. rg 'activePollCount'Length of output: 927
230-230: Added a "copyLink" translation. Ensure this is linked to functionalities that allow users to copy links, such as sharing poll links.Verification successful
The expanded search provided useful context:
- The
copyLinkkey is used inapps/web/src/app/[locale]/(admin)/polls/user-polls.tsx.- There are related functions and components like
CopyLinkButtonandcopyInviteLinkthat handle link copying functionalities.This confirms that the
copyLinktranslation is indeed linked to functionalities that allow users to copy links.
apps/web/src/app/[locale]/(admin)/polls/user-polls.tsx: Contains theCopyLinkButtoncomponent using thecopyLinkkey.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Ensure that "copyLink" is linked to functionalities that allow users to copy links. # Test: Search for the usage of "copyLink" in the application code. rg --type js --type html $'copyLink'Length of output: 35
Script:
#!/bin/bash # Description: Ensure that "copyLink" is linked to functionalities that allow users to copy links. # Test: Expand the search for the usage of "copyLink" in the application code to include all file types. rg 'copyLink' # Test: Search for components or functions related to copying links. rg -i 'copy.*link' # Test: Search for any tests that might mention "copyLink". rg -i 'copyLink' --type test # Test: Search for any documentation that might mention "copyLink". rg -i 'copyLink' --type mdLength of output: 2191
231-234: Translations for empty state messages in events sections have been added. These should appear when there are no events to display. Confirm that these translations are displayed correctly in the UI under those circumstances.Verification successful
The translation keys for the empty state messages are correctly used in the following files:
apps/web/src/app/[locale]/(admin)/events/past-events.tsxapps/web/src/app/[locale]/(admin)/events/upcoming-events.tsxThese files include the keys
pastEventsEmptyStateTitle,pastEventsEmptyStateDescription,upcomingEventsEmptyStateTitle, andupcomingEventsEmptyStateDescription, confirming that the translations should be displayed correctly in the UI under the specified conditions.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Confirm that empty state messages are displayed correctly in the UI. # Test: Search for the usage of "upcomingEventsEmptyStateTitle", "upcomingEventsEmptyStateDescription", "pastEventsEmptyStateTitle", and "pastEventsEmptyStateDescription" in the application code. rg --type js --type html $'upcomingEventsEmptyStateTitle|upcomingEventsEmptyStateDescription|pastEventsEmptyStateTitle|pastEventsEmptyStateDescription'Length of output: 152
Script:
#!/bin/bash # Description: Confirm that empty state messages are displayed correctly in the UI. # Test: Search for the usage of "upcomingEventsEmptyStateTitle", "upcomingEventsEmptyStateDescription", "pastEventsEmptyStateTitle", and "pastEventsEmptyStateDescription" in the application code, including TypeScript files. rg --type js --type ts --type html --type tsx $'upcomingEventsEmptyStateTitle|upcomingEventsEmptyStateDescription|pastEventsEmptyStateTitle|pastEventsEmptyStateDescription'Length of output: 201
Script:
#!/bin/bash # Description: Confirm that empty state messages are displayed correctly in the UI. # Test: Search for the usage of "upcomingEventsEmptyStateTitle", "upcomingEventsEmptyStateDescription", "pastEventsEmptyStateTitle", and "pastEventsEmptyStateDescription" in the application code, including TypeScript and TSX files. rg --type-add 'tsx:*.tsx' --type js --type ts --type html --type tsx $'upcomingEventsEmptyStateTitle|upcomingEventsEmptyStateDescription|pastEventsEmptyStateTitle|pastEventsEmptyStateDescription'Length of output: 644
227-227: Added a new key "create" with the translation "Skapa". This should be connected to any UI element that involves creation functionalities. Verify for consistent usage across the application.Verification successful
The localization key "create" has been found in the application code and is used in the following files:
apps/web/src/app/[locale]/(admin)/sidebar.tsxapps/web/src/app/[locale]/(admin)/dashboard.tsxThis indicates that the key is indeed being utilized in the UI components related to administrative functionalities.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for consistent usage of the "create" key across the application. # Test: Search for the usage of "create" in the application code. rg --type js --type html $'create'Length of output: 695
Script:
#!/bin/bash # Description: Check for the usage of the localization key "create" specifically in the application code. # Test: Search for the usage of the localization key "create" in the application code. rg '"create"' --type js --type ts --type jsx --type tsx --type htmlLength of output: 97
Script:
#!/bin/bash # Description: Check for the usage of the localization key "create" specifically in the application code. # Test: Search for the usage of the localization key "create" in the application code. rg '"create"' --type js --type ts --type tsx --type htmlLength of output: 86
Script:
#!/bin/bash # Description: Check for the usage of the localization key "create" specifically in the application code. # Test: Search for the usage of the localization key "create" in the application code. rg '"create"'Length of output: 524
228-229: Added translations for "upcoming" and "past". These should be used in the context of filtering or displaying events. Ensure these are used appropriately in the UI.Verification successful
The translations for "upcoming" and "past" are used appropriately in the UI, particularly in the context of filtering and displaying events.
- File:
packages/features/scheduled-events/api.ts
- Lines: 1, 3, 5
- File:
packages/backend/trpc/routers/scheduled-events.ts
- Line: 1
- File:
apps/web/src/app/[locale]/(admin)/events/user-scheduled-events.tsx
- Lines: 1, 2, 3, 4, 5, 6, 7, 8
- File:
apps/web/src/app/[locale]/(admin)/events/upcoming-events.tsx
- Lines: 1, 2, 3
- File:
apps/web/src/app/[locale]/(admin)/events/past-events.tsx
- Lines: 1, 2, 3
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that "upcoming" and "past" are used appropriately in the UI. # Test: Search for the usage of "upcoming" and "past" in the application code. rg --type js --type html $'upcoming|past'Length of output: 42
Script:
#!/bin/bash # Description: Verify that "upcoming" and "past" are used appropriately in the UI. # Test: Search for the usage of "upcoming" and "past" in the application code, including TypeScript and JSX files. rg --type js --type ts --type jsx --type tsx $'upcoming|past'Length of output: 90
Script:
#!/bin/bash # Description: Verify that "upcoming" and "past" are used appropriately in the UI. # Test: Search for the usage of "upcoming" and "past" in the application code, including JavaScript, TypeScript, and their JSX/TSX variants. rg --type js --type ts --type tsx --type tsx 'upcoming|past'Length of output: 90
Script:
#!/bin/bash # Description: Verify that "upcoming" and "past" are used appropriately in the UI. # Test: Search for the usage of "upcoming" and "past" in the application code, including JavaScript, TypeScript, and their JSX/TSX variants. rg --type js --type ts --type tsx --type jsx 'upcoming|past'Length of output: 90
Script:
#!/bin/bash # Description: Verify that "upcoming" and "past" are used appropriately in the UI. # Test: Search for the usage of "upcoming" and "past" in the application code, including JavaScript, TypeScript, and their JSX/TSX variants. rg 'upcoming|past' --glob '*.js' --glob '*.ts' --glob '*.tsx' --glob '*.jsx'Length of output: 2920
223-223: The translation for "verificationCodeSentTo" has been updated to include dynamic email placeholders. Ensure that this change is reflected across all client-side implementations where this string is used.
Summary by CodeRabbit
New Features
Improvements
Removals