New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product variants OLD PR #400

Merged

mmansoor-magento merged 13 commits into magento:develop from bricht:27_product-variants

Nov 13, 2020

Contributor

bricht commented Oct 21, 2020 •

edited

Loading

-Added string type or message entity id to accommodate for product variants

Description (*)

PR moved to #413

Related Pull Requests

Fixed Issues (if relevant)

Questions or comments

Code Review Checklist (*)

See dataied checklist

Story AC is completed
proposed changes correspond to Magento Technical Vision
new or changed code is covered with web-api/integration tests (if applicable)
- expected results in test verified with data from fixture
no backward incompatibile changes
Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
- prerequisite: story branch created with all needed generated classes according to proposes schema-changes
- DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
- Check composer.json dependencies
Legacy code is deleted
- Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
- And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
- Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
- Any “mapper” on Message Broker (between Export API and SF API)
  - if mapper still needed, verify fields used in mapping, remove not relevant fields


          Product variants

400334b

-Added string type or message entity id to accomodate product variants

Contributor Author

bricht commented Oct 21, 2020

@magento run all tests

1 similar comment

Contributor Author

bricht commented Oct 21, 2020

@magento run all tests

Member

mslabko commented Oct 21, 2020

@magento run Static Tests

Member

mslabko commented Oct 21, 2020

@magento run Unit Tests

Member

slavvka commented Oct 22, 2020

@magento run all tests

Member

mslabko commented Oct 23, 2020

@magento run Integration Tests


          Product variants

e5dde08

-Added product variant write and delete functionality to Catalog Storefront

Contributor Author

bricht commented Oct 27, 2020

@magento run all tests

Contributor Author

bricht commented Oct 27, 2020

@magento run all tests with editions EE

1 similar comment

Contributor Author

bricht commented Oct 27, 2020

@magento run all tests with editions EE

Member

mslabko commented Oct 28, 2020

@magento run Unit Tests


          Product variants

239f3e4

-Modified GetProductVariants and DeleteProductVariants to the VariantService

Contributor Author

bricht commented Oct 29, 2020

@magento run all tests with editions EE


          Product variants

209937d

-static fixes

Contributor Author

bricht commented Oct 29, 2020

@magento run all tests with editions EE

1 similar comment

Contributor Author

bricht commented Oct 29, 2020

@magento run all tests with editions EE

Contributor

vgoncharenko commented Oct 29, 2020

@magento run Static Tests

jekabs added 2 commits

October 30, 2020 13:08


          Merge branch 'develop' into 27_product-variants

950d865


          Product variants

6d57388

-Added test
-Improved elasticsearch deleteByQuery
-Added some exceptions for empty variant response

Contributor Author

bricht commented Nov 3, 2020

@magento run all tests with editions EE

jekabs added 3 commits

November 3, 2020 14:23


          Product variants

eed02bc

-Test fix


          Product variants

4300f91

-Removed old ConfigurableVariantsExtractor


          Product variants

aad8769

RuslanKostiv1 reviewed

View reviewed changes

app/code/Magento/CatalogExport/Event/Data/Entity.php

@@ @@ -14,7 +14,7 @@ @@
               class Entity
               {
                   /**
-                   * @var int
+                   * @var int|string
                    */

Contributor

RuslanKostiv1 Nov 3, 2020 •

edited

Loading

in which case entityId is a string?
Can we use string only?

Contributor Author

bricht Nov 5, 2020 •

edited

Loading

Using string only. Id is a string for product variants.

app/code/Magento/CatalogMessageBroker/Model/MessageBus/Category/DeleteCategoriesConsumer.php Outdated

@@ @@ -49,7 +49,7 @@ public function __construct( @@
                   /**
                    * @inheritdoc
                    */
-                  public function execute(array $entities, string $scope): void
+                  public function execute(array $entities, string $scope = null): void

Contributor

RuslanKostiv1 Nov 3, 2020

let's use nullable annotation ?string $scope

Contributor Author

bricht Nov 5, 2020

Resolved

app/code/Magento/CatalogMessageBroker/Model/MessageBus/Category/PublishCategoriesConsumer.php Outdated

		public function execute(array $entities, string $scope): void
		public function execute(array $entities, string $scope = null): void

Contributor

RuslanKostiv1 Nov 3, 2020

let's use nullable annotation ?string $scope

Contributor Author

bricht Nov 5, 2020

Resolved

app/code/Magento/CatalogMessageBroker/Model/MessageBus/ConsumerEventInterface.php Outdated

                    *
                    * @return void
                    */
-                  public function execute(array $entities, string $scope): void;
+                  public function execute(array $entities, string $scope = null): void;

Contributor

RuslanKostiv1 Nov 3, 2020

let's use nullable annotation ?string $scope

Contributor Author

bricht Nov 5, 2020

Resolved

app/code/Magento/CatalogMessageBroker/Model/MessageBus/Product/DeleteProductsConsumer.php Outdated

@@ @@ -49,7 +49,7 @@ public function __construct( @@
                   /**
                    * @inheritdoc
                    */
-                  public function execute(array $entities, string $scope): void
+                  public function execute(array $entities, string $scope = null): void

Contributor

RuslanKostiv1 Nov 3, 2020

let's use nullable annotation ?string $scope

Contributor Author

bricht Nov 5, 2020

Resolved

app/code/Magento/CatalogStorefront/Model/VariantService.php Outdated

+                          'product_variant' => [
+                              //TODO: Adapt to work without store code
+                              self::EMPTY_STORE_CODE => [
+                                  'delete_by_query' => $deleteFields

Contributor

RuslanKostiv1 Nov 3, 2020

use created constant here \Magento\CatalogStorefront\Model\CatalogRepository::DELETE_BY_QUERY

Contributor Author

bricht Nov 5, 2020

Resolved

...i-functional/testsuite/Magento/CatalogMessageBroker/Model/MessageBus/ProductVariantsTest.php Outdated

+                  }
+                  /**
+                   * Validate something

Contributor

RuslanKostiv1 Nov 3, 2020

let's add better description to this method

Contributor Author

bricht Nov 5, 2020

Resolved

...i-functional/testsuite/Magento/CatalogMessageBroker/Model/MessageBus/ProductVariantsTest.php

+                      }
+                  }
+                  /**

Contributor

RuslanKostiv1 Nov 3, 2020

method description is missing

Contributor Author

bricht Nov 5, 2020

Resolved

...i-functional/testsuite/Magento/CatalogMessageBroker/Model/MessageBus/ProductVariantsTest.php

+                      $this->variantService->GetProductVariants($this->variantsGetRequestInterface);
+                  }
+                  /**

Contributor

RuslanKostiv1 Nov 3, 2020

method description is missing

Contributor Author

bricht Nov 5, 2020

Resolved

...i-functional/testsuite/Magento/CatalogMessageBroker/Model/MessageBus/ProductVariantsTest.php

+                      }
+                  }
+                  /**

Contributor

RuslanKostiv1 Nov 3, 2020

method description is missing

Contributor Author

bricht Nov 5, 2020

Resolved


          Product variants

617352d

-Changed entity_id type to string in order to pass product variant message correctly

RuslanKostiv1 reviewed

View reviewed changes

app/code/Magento/CatalogMessageBroker/Model/FetchProductVariants.php

+              use Psr\Log\LoggerInterface;
+              /**
+               * @inheritdoc

Contributor

RuslanKostiv1 Nov 4, 2020

@inheritdoc should be used only on class members

Contributor Author

bricht Nov 5, 2020

Resolved

jekabs and others added 3 commits

November 5, 2020 13:06


          Product variants

6c5bf07

-Fixed and added tests
-Other minor fixes and improvements like syntax, docBlock, constants, etc.


          Merge pull request #1 from magento/develop

1608c98

Merge


          Merge branch 'develop' into 27_product-variants

292ab85

bricht mentioned this pull request

Configurable variants saving to cache OLD magento/commerce-data-export#5

Closed

4 tasks

bricht changed the title ~~Product variants~~ Product variants OLD PR

mmansoor-magento merged commit 292ab85 into magento:develop

m2-community-project bot added the Progress: done label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels