Missing required argument $productAvailabilityChecks of Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker. #20825

ianitsky · 2019-01-30T20:57:57Z

Preconditions (*)

Magento 2.2.7
PHP 7.1

Steps to reproduce (*)

Admin -> Sales -> Any Order -> Reorder

Expected result (*)

Continue to reorder process.

Actual result (*)

Shows exception:

1 exception(s):
Exception #0 (BadMethodCallException): Missing required argument $productAvailabilityChecks of Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker.

Exception #0 (BadMethodCallException): Missing required argument $productAvailabilityChecks of Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker.
#0 /var/www/magento/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(34): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgumentsInRuntime('Magento\Sales\M...', Array, Array)
#1 /var/www/magento/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(59): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->_resolveArguments('Magento\Sales\M...', Array, Array)
#2 /var/www/magento/vendor/magento/framework/ObjectManager/ObjectManager.php(70): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create('Magento\Sales\M...')
#3 /var/www/magento/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(144): Magento\Framework\ObjectManager\ObjectManager->get('Magento\Sales\M...')
#4 /var/www/magento/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(230): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgument(Array, 'Magento\Sales\M...', NULL, 'orderedProductA...', 'Magento\Sales\M...')
#5 /var/www/magento/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(34): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgumentsInRuntime('Magento\Sales\M...', Array, Array)
#6 /var/www/magento/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(59): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->_resolveArguments('Magento\Sales\M...', Array, Array)
#7 /var/www/magento/vendor/magento/framework/ObjectManager/ObjectManager.php(70): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create('Magento\Sales\M...')
#8 /var/www/magento/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(144): Magento\Framework\ObjectManager\ObjectManager->get('Magento\Sales\M...')
#9 /var/www/magento/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(230): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgument(Array, 'Magento\Sales\M...', NULL, 'unavailableProd...', 'Magento\Sales\C...')
#10 /var/www/magento/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(34): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgumentsInRuntime('Magento\Sales\C...', Array, Array)
#11 /var/www/magento/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(59): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->_resolveArguments('Magento\Sales\C...', Array, Array)
#12 /var/www/magento/vendor/magento/framework/ObjectManager/ObjectManager.php(56): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create('Magento\Sales\C...', Array)
#13 /var/www/magento/vendor/magento/framework/App/ActionFactory.php(40): Magento\Framework\ObjectManager\ObjectManager->create('Magento\Sales\C...')
#14 /var/www/magento/vendor/magento/framework/App/Router/Base.php(297): Magento\Framework\App\ActionFactory->create('Magento\Sales\C...')
#15 /var/www/magento/vendor/magento/framework/App/Router/Base.php(158): Magento\Framework\App\Router\Base->matchAction(Object(Magento\Framework\App\Request\Http), Array)
#16 /var/www/magento/vendor/magento/framework/App/FrontController.php(50): Magento\Framework\App\Router\Base->match(Object(Magento\Framework\App\Request\Http))
#17 /var/www/magento/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\FrontController->dispatch(Object(Magento\Framework\App\Request\Http))
#18 /var/www/magento/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\FrontController\Interceptor->___callParent('dispatch', Array)
#19 /var/www/magento/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception{closure}(Object(Magento\Framework\App\Request\Http))
#20 /var/www/magento/generated/code/Magento/Framework/App/FrontController/Interceptor.php(26): Magento\Framework\App\FrontController\Interceptor->___callPlugins('dispatch', Array, Array)
#21 /var/www/magento/vendor/magento/framework/App/Http.php(135): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#22 /var/www/magento/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\Http->launch()
#23 /var/www/magento/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\Http\Interceptor->___callParent('launch', Array)
#24 /var/www/magento/vendor/msp/apienhancer/Plugin/AppInterfacePlugin.php(75): Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception{closure}()
#25 /var/www/magento/vendor/magento/framework/Interception/Interceptor.php(135): MSP\APIEnhancer\Plugin\AppInterfacePlugin->aroundLaunch(Object(Magento\Framework\App\Http\Interceptor), Object(Closure))
#26 /var/www/magento/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception{closure}()
#27 /var/www/magento/generated/code/Magento/Framework/App/Http/Interceptor.php(26): Magento\Framework\App\Http\Interceptor->___callPlugins('launch', Array, NULL)
#28 /var/www/magento/vendor/magento/framework/App/Bootstrap.php(257): Magento\Framework\App\Http\Interceptor->launch()
#29 /var/www/magento/pub/index.php(37): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http\Interceptor))
#30 {main}

@magento-engcom-team give me 2.2.7 instance

magento-engcom-team · 2019-01-30T20:58:03Z

Hi @ianitsky. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ianitsky do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

magento-engcom-team · 2019-01-31T00:22:17Z

Hi @dominicfernando. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

dominicfernando · 2019-01-31T01:08:12Z

@magento-engcom-team give me 2.2-develop instance

magento-engcom-team · 2019-01-31T01:08:17Z

Hi @dominicfernando. Thank you for your request. I'm working on Magento 2.2-develop instance for you

magento-engcom-team · 2019-01-31T01:19:42Z

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

shikhamis11 · 2019-01-31T01:20:39Z

@magento-engcom-team give me 2.2-develop instance

magento-engcom-team · 2019-01-31T01:20:42Z

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.2-develop instance for you

nainesh2jcommerce · 2019-01-31T06:21:51Z

@magento-engcom-team give me 2.2-develop instance

magento-engcom-team · 2019-01-31T06:22:02Z

Hi @nainesh2jcommerce. Thank you for your request. I'm working on Magento 2.2-develop instance for you

magento-engcom-team · 2019-01-31T06:22:02Z

Hi @nainesh2jcommerce. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

shikhamis11 · 2019-01-31T06:54:00Z

Hi @ianitsky I checked the issue at my local environment with current 2.2- develop branch code . This issue is not reproducable so I am closing this. You can share screenshots here if you still get issue in 2.2-develop branch

zaximus84 · 2019-02-11T22:34:11Z

I came across this issue when Magento_ConfigurableProductSales was disabled on a 2.2.3 installation. The productAvailabilityChecks argument isn't defined in di.xml in Magento_Sales. The sole definition comes from Magento_ConfigurableProductSales's di.xml when its adding its own check to the array (and in fact defining the argument as an array).

If you disable Magento_ConfigurableProductSales, you'll get the error. As the Sales module shouldn't depend on ConfigurableProductSales, the argument should really be defined in the Sales module and I'd classify this as a core bug. This just needs to be added to the Sales di.xml:

<type name="Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker"> <arguments> <argument name="productAvailabilityChecks" xsi:type="array" /> </arguments> </type>

I added that via patch and it fixed the error, even with ConfigurableProductSales still disabled.

shikhamis11 · 2019-02-12T03:36:32Z

@zaximus84 thanks for explanation I will recheck and reopen the issue if it exists

magento-engcom-team · 2019-02-12T06:46:45Z

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98209, MAGETWO-98210 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

shikhamis11 · 2019-02-12T06:57:57Z

@zaximus84 yes found the issue .. yes Sales module shouldn't depend on ConfigurableProductSales . If you have solution for the issue please create Pull request .
https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html#pull_request

magento-engcom-team · 2019-03-18T13:25:32Z

Hi @kisroman. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

3. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
4. If the issue is not relevant or is not reproducible any more, feel free to close it.

… Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker.

magento-engcom-team · 2019-03-25T13:53:12Z

Hi @ianitsky. Thank you for your report.
The issue has been fixed in #21820 by @kisroman in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

…cks of Magent… #21820 - Merge Pull Request #21820 from kisroman/magento2:20825 - Merged commits: 1. c4f8496 2. 933d35d 3. 5dbbffb

…cks of Magent… #21820

… Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker.

magento-engcom-team · 2019-03-27T20:50:07Z

Hi @ianitsky. Thank you for your report.
The issue has been fixed in #21920 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

…labilityChecks of Magent… #21920 - Merge Pull Request #21920 from amol2jcommerce/magento2:2.2-develop-PR-port-21820 - Merged commits: 1. 6958066 2. 61d7158

…labilityChecks of Magent… #21920

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 30, 2019

dominicfernando self-assigned this Jan 31, 2019

shikhamis11 self-assigned this Jan 31, 2019

dominicfernando removed their assignment Jan 31, 2019

nainesh2jcommerce self-assigned this Jan 31, 2019

shikhamis11 added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Jan 31, 2019

shikhamis11 closed this as completed Jan 31, 2019

shikhamis11 reopened this Feb 12, 2019

magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 12, 2019

magento-engcom-team unassigned shikhamis11 Feb 12, 2019

kisroman self-assigned this Mar 18, 2019

kisroman added a commit to kisroman/magento2 that referenced this issue Mar 18, 2019

magento#20825 Missing required argument $productAvailabilityChecks of…

c4f8496

… Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker.

kisroman mentioned this issue Mar 18, 2019

#20825 Missing required argument $productAvailabilityChecks of Magent… #21820

Merged

4 tasks

kisroman added a commit to kisroman/magento2 that referenced this issue Mar 20, 2019

magento#20825 Missing required argument $productAvailabilityChecks of…

933d35d

… Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker.

magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 25, 2019

magento-engcom-team closed this as completed Mar 25, 2019

magento-engcom-team pushed a commit that referenced this issue Mar 25, 2019

ENGCOM-4543: #20825 Missing required argument $productAvailabilityChe…

2f4d12a

…cks of Magent… #21820

amol2jcommerce mentioned this issue Mar 25, 2019

[Backport] #20825 Missing required argument $productAvailabilityChecks of Magent… #21920

Merged

4 tasks

amol2jcommerce pushed a commit to amol2jcommerce/magento2 that referenced this issue Mar 25, 2019

magento#20825 Missing required argument $productAvailabilityChecks of…

6958066

… Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker.

amol2jcommerce pushed a commit to amol2jcommerce/magento2 that referenced this issue Mar 25, 2019

magento#20825 Missing required argument $productAvailabilityChecks of…

61d7158

… Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker.

magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 27, 2019

magento-engcom-team pushed a commit that referenced this issue Mar 27, 2019

ENGCOM-4570: [Backport] #20825 Missing required argument $productAvai…

5061ae5

…labilityChecks of Magent… #21920

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Missing required argument $productAvailabilityChecks of Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker. #20825

Missing required argument $productAvailabilityChecks of Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker. #20825

ianitsky commented Jan 30, 2019 •

edited

Loading

magento-engcom-team commented Jan 30, 2019

magento-engcom-team commented Jan 31, 2019

dominicfernando commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019 •

edited by shikhamis11

Loading

shikhamis11 commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

nainesh2jcommerce commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

shikhamis11 commented Jan 31, 2019 •

edited

Loading

zaximus84 commented Feb 11, 2019

shikhamis11 commented Feb 12, 2019

magento-engcom-team commented Feb 12, 2019

shikhamis11 commented Feb 12, 2019

magento-engcom-team commented Mar 18, 2019

magento-engcom-team commented Mar 25, 2019

magento-engcom-team commented Mar 27, 2019

Missing required argument $productAvailabilityChecks of Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker. #20825

Missing required argument $productAvailabilityChecks of Magento\Sales\Model\Order\Reorder\OrderedProductAvailabilityChecker. #20825

Comments

ianitsky commented Jan 30, 2019 • edited Loading

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

magento-engcom-team commented Jan 30, 2019

magento-engcom-team commented Jan 31, 2019

dominicfernando commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019 • edited by shikhamis11 Loading

shikhamis11 commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

nainesh2jcommerce commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

magento-engcom-team commented Jan 31, 2019

shikhamis11 commented Jan 31, 2019 • edited Loading

zaximus84 commented Feb 11, 2019

shikhamis11 commented Feb 12, 2019

magento-engcom-team commented Feb 12, 2019

shikhamis11 commented Feb 12, 2019

magento-engcom-team commented Mar 18, 2019

magento-engcom-team commented Mar 25, 2019

magento-engcom-team commented Mar 27, 2019

ianitsky commented Jan 30, 2019 •

edited

Loading

magento-engcom-team commented Jan 31, 2019 •

edited by shikhamis11

Loading

shikhamis11 commented Jan 31, 2019 •

edited

Loading