Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the domReady! statement for editing the cart product on the PDP #13253

Closed
wants to merge 83 commits into from
Closed

Add the domReady! statement for editing the cart product on the PDP #13253

wants to merge 83 commits into from

Conversation

arnoudhgz
Copy link
Contributor

Description

When you are on the cart page and click on the 'edit' link for a product you are being redirected to the PDP and the current amount for that product that is in the cart should be filled in the amount field on the PDP.

In production mode when the settings minify and merge the javascript files in Stores > Configuration > Advanced > Developer are enabled the jquery selector sometimes (depending on the amount of javascript files) returns no values because the DOM is not ready when the script is executed.

By adding the domReady! statement in the require part we are sure that when the jQuery selector is being filled the DOM is ready.

This issue could not be reproduced on a clean magento 2.2 installation, but in a project where significantly more (external) modules (and therefore more javascript files) are included the issue occurred.

Manual testing scenarios

  1. Go to a PDP
  2. Add a product to the cart
  3. Go to the cart page (view and edit cart from the minicart)
  4. Click the edit button for the product in the cart
  5. See that the amount that you have in your cart for the product is being filled in the amount field on the PDP.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Carlos Lizaga and others added 30 commits November 21, 2017 17:36
Added translate.test.js for Jasmine compatibility unit testing.
2abaf8c 
Removed transtale-test.js from jsTestDriver suite.
Fix translate.test to be eslint friendly
1691621
Added accordion.test.js for Jasmine testing.
ea56695 
Removed accordion.js and index.html for jsTestDriver test.
Eslint upgrades.
126a1e3
@omiroshnichenko
Added decorate.test.js for Jasmine testing. Removed decorate-test.js
b3fedbc
Added translate.test.js for Jasmine compatibility unit testing.
0117f86 
Removed transtale-test.js from jsTestDriver suite.
Fix translate.test to be eslint friendly
3a907c2
Added accordion.test.js for Jasmine testing.
821bdaa 
Removed accordion.js and index.html for jsTestDriver test.
Eslint upgrades.
2846c78
Eslint improvements and logical fixes for unit testing.
f4712cd
@omiroshnichenko
Added decorate.test.js for Jasmine testing. Removed decorate-test.js
f0a1877 
(cherry picked from commit b3fedbc)
Merge remote-tracking branch 'karldeux/issue/12342/JSTestDriver-remov…
5e785eb 
…al' into issue/12342/JSTestDriver-removal

# Conflicts:
#	dev/tests/js/jasmine/tests/lib/mage/accordion.test.js
Eslint improvements and logical fixes for unit testing.
64bf208
@omiroshnichenko
Fix decorate.test.js
8595da6
Fixed unsafe comparison with a literal. No need to eslint eqeqeq.
2adf9e8 
Fixed enable method. It was not enabling and activating the collapsible.
This was detected on Jasmine unit testing.

Minor repositioning to this.options.disabled on disable method for
consistency purposes with enable method.
that - this consistency and splat complete function to be Jasmine fri…
9b28fe2 
…endly.
Added collapsible.test.js and removed JsTestDriver equivalent.
4127a8c
jscs:disable jsDoc
6366f83
Added dropdown.test.js and removed JsTestDriver equivalent.
c98720f
Backend jquery-ui version has a diferent behavior on create that will…
de225a9 
… add ui-dialog-titlebar anyway.

This test is only valid with frontend's version
@todo: Re-design Jasmine settings to match a selective architecture for testing in order to split them.
Added form.test.js and removed JsTestDriver equivalent.
9f14822 
Modified if documentation to be more friendly with developers.
jQuery consistency.
ad90a47
@RomaKis
8624: Stock status not coming back after qty update
15928fb
@RomaKis
8624: Stock status not coming back after qty update
188ecb3
@RomaKis
Merge branch '2.2-develop' into 8624
546a0bb
@nmalevanec
magento#11897: Catalog product list widget not working with multiple sku
8d62341
@omiroshnichenko
magento#12342: JSTestDriver removal
35a1aca 
- Added menu.test.js and removed JsTestDriver equivalent.
@nmalevanec
magento#11897: Catalog product list widget not working with multiple sku
d5b596a
@omiroshnichenko
magento#12342: JSTestDriver removal
36cfa45 
- Added translate-inline.test.js and removed JsTestDriver equivalent.
@omiroshnichenko
magento#12342: JSTestDriver removal
b1b001a 
- Added calendar.test.js and removed JsTestDriver equivalent.
ishakhsuvarov and others added 19 commits January 18, 2018 16:09
@ishakhsuvarov
MAGETWO-86840: GitHub 12322: Bug with CDATA in XML layout update mage…
2e19f33 
…nto#1163
@omiroshnichenko
magento#12342: JSTestDriver removal
faed0c5 
- Fix timeout dropdown close.
@slopukhov
Merge branch '2.2-develop' of github.com:magento/magento2ce into MAGE…
59bd8fc 
…TWO-84480
MAGETWO-85288: 8624: Stock status not coming back after qty update ma…
08b4a41 
…gento#955

 - Merge Pull Request magento-engcom/magento2ce#955 from RomaKis/magento2:8624
 - Merged commits:
   1. 15928fb
   2. 188ecb3
   3. 546a0bb
   4. 4b585d4
   5. a9a3c19
@omiroshnichenko
magento#12342: JSTestDriver removal
ac8aa21 
- Fix jstree override.
@kandy
Merge pull request magento#1966 from magento-performance/MAGETWO-84480
11fd8ce 
[Performance] MAGETWO-84480: Add cache for getimagesize() function for product images
@magento-engcom-team
[EngCom] Public Pull Requests - 2.2-develop
afd02d7 
 - merged latest code from mainline branch
@magento-team
🔃 [EngCom] Public Pull Requests - 2.2-develop
83a9b9c 
Accepted Public Pull Requests:
 - magento#13208: magento#12714 - pass parameter for export button url (by @sanjay-wagento)
 - magento-engcom/magento2ce#1163: GitHub 12322: Bug with CDATA in XML layout update (by @serhii-balko)


Fixed GitHub Issues:
 - magento#12714: Extra records are in exported CSV file for order (reported by @alena-marchenko) has been fixed in magento#13208 by @sanjay-wagento in 2.2-develop branch
   Related commits:
     1. f7baf29

 - magento#12322: Bug with CDATA in XML layout update (reported by @alexvandervegt) has been fixed in magento-engcom/magento2ce#1163 by @serhii-balko in 2.2-develop branch
   Related commits:
     1. 6b22445
MAGETWO-86663: 11897: Catalog product list widget not working with mu…
ca5c2ed 
…ltiple sku. magento#1050

 - Merge Pull Request magento-engcom/magento2ce#1050 from nmalevanec/magento2:11897
 - Merged commits:
   1. 8d62341
   2. d5b596a
@ishakhsuvarov
MAGETWO-86882: 2.2.2 - Duplicating Bundle Product Removes Bundle Opti…
772c10d 
…ons From Original Product. magento#1217

 - Merge Pull Request magento-engcom/magento2ce#1217 from nmalevanec/magento2:13126
 - Merged commits:
   1. b57eb03
   2. d8bd657
@ishakhsuvarov
MAGETWO-86883: The function 'isUsingStaticUrlsAllowed' (configuration…
2a80282 
… setting 'cms/wysiwyg/use_static_urls_in_catalog') doesn't have any effect with the WYSIWYG editor image insertion magento#1215

 - Merge Pull Request magento-engcom/magento2ce#1215 from nmalevanec/magento2:12147
 - Merged commits:
   1. 26a83d5
   2. 94fdca7
@ishakhsuvarov
MAGETWO-86886: magento#12993: Type error in Cart/Totals [Forwardport …
225e6d1 
…for public PR#9647] magento#1186

 - Merge Pull Request magento-engcom/magento2ce#1186 from p-bystritsky/magento2:ISSUE-12993
 - Merged commits:
   1. 69cad44
   2. dc64138
@ishakhsuvarov
MAGETWO-86883: The function "isUsingStaticUrlsAllowed" (configuration…
5d537a3 
… setting "cms/wysiwyg/use_static_urls_in_catalog") doesn't have any effect with the WYSIWYG editor image insertion magento#1215
@ishakhsuvarov
MAGETWO-86663: 11897: Catalog product list widget not working with mu…
18bb122 
…ltiple sku. magento#1050
@ishakhsuvarov
MAGETWO-85288: 8624: Stock status not coming back after qty update ma…
f13beab 
…gento#955
@omiroshnichenko
Merge branch '2.2-develop' of github.com:magento/magento2 into issue/…
fa69aa5 
…12342/JSTestDriver-removal
@omiroshnichenko
magento#12342: JSTestDriver removal
64f9c6d 
- Fix validation.
@omiroshnichenko
MAGETWO-86859: Issue/12342/js test driver removal magento#12406
f748630 
 - Merge Pull Request magento#12406 from KarlDeux/magento2:issue/12342/JSTestDriver-removal
 - Merged commits:
   1. 2abaf8c
   2. 1691621
   3. ea56695
   4. 126a1e3
   5. b3fedbc
   6. 0117f86
   7. 3a907c2
   8. 821bdaa
   9. 2846c78
   10. f4712cd
   11. f0a1877
   12. 5e785eb
   13. 64bf208
   14. 8595da6
   15. 2adf9e8
   16. 9b28fe2
   17. 4127a8c
   18. 6366f83
   19. c98720f
   20. de225a9
   21. 9f14822
   22. ad90a47
   23. 35a1aca
   24. 36cfa45
   25. b1b001a
   26. b716482
   27. c5a1722
   28. 40e6981
   29. 2fff734
   30. e510801
   31. a667b63
   32. 574daf5
   33. faed0c5
   34. ac8aa21
   35. fa69aa5
   36. 64f9c6d
@magento-team
🔃 [EngCom] Public Pull Requests - 2.2-develop
78028f0 
Accepted Public Pull Requests:
 - magento-engcom/magento2ce#1215: The function "isUsingStaticUrlsAllowed" (configuration setting "cms/wysiwyg/use_static_urls_in_catalog") doesn't have any effect with the WYSIWYG editor image insertion (by @nmalevanec)
 - magento-engcom/magento2ce#1050: 11897: Catalog product list widget not working with multiple sku. (by @nmalevanec)
 - magento-engcom/magento2ce#955: 8624: Stock status not coming back after qty update  (by @RomaKis)


Fixed GitHub Issues:
 - magento#12147: The function "isUsingStaticUrlsAllowed" (configuration setting "cms/wysiwyg/use_static_urls_in_catalog") doesn't have any effect with the WYSIWYG editor image insertion (reported by @andrewhowdencom) has been fixed in magento-engcom/magento2ce#1215 by @nmalevanec in 2.2-develop branch
   Related commits:
     1. 26a83d5
     2. 94fdca7

 - magento#11897: Catalog product list widget not working with multiple sku (reported by @hemendraajmera) has been fixed in magento-engcom/magento2ce#1050 by @nmalevanec in 2.2-develop branch
   Related commits:
     1. 8d62341
     2. d5b596a

 - magento#8624: Stock status not coming back after qty update (reported by @oroskodias) has been fixed in magento-engcom/magento2ce#955 by @RomaKis in 2.2-develop branch
   Related commits:
     1. 15928fb
     2. 188ecb3
     3. 546a0bb
     4. 4b585d4
     5. a9a3c19
ishakhsuvarov and others added 7 commits January 20, 2018 13:08
@ishakhsuvarov
MAGETWO-86886: magento#12993: Type error in Cart/Totals [Forwardport …
48dd554 
…for public PR#9647] magento#1186
@ishakhsuvarov
MAGETWO-86859: Issue/12342/js test driver removal magento#12406
b641bf8
@ishakhsuvarov
🔃 [EngCom] Public Pull Requests - 2.2-develop
1cd8257 
Accepted Public Pull Requests:
 - magento-engcom/magento2ce#1186: magento#12993: Type error in Cart/Totals [Forwardport for public PR#9647] (by @p-bystritsky)
 - magento#12406: Issue/12342/js test driver removal (by @KarlDeux)


Fixed GitHub Issues:
 - magento#12819: CartTotalRepository cannot handle extension attributes in quote addresses in 2.2.2 (reported by @marius-bica) has been fixed in magento-engcom/magento2ce#1186 by @p-bystritsky in 2.2-develop branch
   Related commits:
     1. 69cad44
     2. dc64138

 - magento#12993: Type error in Cart/Totals (reported by @andrewhowdencom) has been fixed in magento-engcom/magento2ce#1186 by @p-bystritsky in 2.2-develop branch
   Related commits:
     1. 69cad44
     2. dc64138

 - magento#12342: JSTestDriver removal (reported by @ishakhsuvarov) has been fixed in magento#12406 by @KarlDeux in 2.2-develop branch
   Related commits:
     1. 2abaf8c
     2. 1691621
     3. ea56695
     4. 126a1e3
     5. b3fedbc
     6. 0117f86
     7. 3a907c2
     8. 821bdaa
     9. 2846c78
     10. f4712cd
     11. f0a1877
     12. 5e785eb
     13. 64bf208
     14. 8595da6
     15. 2adf9e8
     16. 9b28fe2
     17. 4127a8c
     18. 6366f83
     19. c98720f
     20. de225a9
     21. 9f14822
     22. ad90a47
     23. 35a1aca
     24. 36cfa45
     25. b1b001a
     26. b716482
     27. c5a1722
     28. 40e6981
     29. 2fff734
     30. e510801
     31. a667b63
     32. 574daf5
     33. faed0c5
     34. ac8aa21
     35. fa69aa5
     36. 64f9c6d
@ishakhsuvarov
MAGETWO-86882: Duplicating Bundle Product Removes Bundle Options From…
7bcbbeb 
… Original Product

 - Added suppress warning for a test method which was too long
@ishakhsuvarov
MAGETWO-86882: 2.2.2 - Duplicating Bundle Product Removes Bundle Opti…
d2d438c 
…ons From Original Product. magento#1217
@magento-team
🔃 [EngCom] Public Pull Requests - 2.2-develop
d0b82cc 
Accepted Public Pull Requests:
 - magento-engcom/magento2ce#1217: 2.2.2 - Duplicating Bundle Product Removes Bundle Options From Original Product. (by @nmalevanec)


Fixed GitHub Issues:
 - magento#13126: 2.2.2 - Duplicating Bundle Product Removes Bundle Options From Original Product (reported by @MattUnity) has been fixed in magento-engcom/magento2ce#1217 by @nmalevanec in 2.2-develop branch
   Related commits:
     1. b57eb03
     2. d8bd657
@arnoudhgz
Merge branch '2.2-develop' of github.com:mediact/magento2 into 2.2-de…
83fb6cb 
…velop
@arnoudhgz
Copy link
Contributor Author

@omiroshnichenko I messed up something with my branch :(, this PR should be closed

@arnoudhgz arnoudhgz closed this Jan 22, 2018
@arnoudhgz
Copy link
Contributor Author

@omiroshnichenko I created a new PR: #13310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omiroshnichenko omiroshnichenko Awaiting requested review from omiroshnichenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.