Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortening currency list in Configuration->General (this replaces PR #19946) #20397

Closed
wants to merge 6 commits into from
Closed

Shortening currency list in Configuration->General (this replaces PR #19946) #20397

wants to merge 6 commits into from

Conversation

melaxon
Copy link
Member

@melaxon melaxon commented Jan 18, 2019 •
edited
Loading

Description (*)

in Store->Configuration->General->Currency setup will be shown only those currencies selected in
Installed currencies list (Configuration->Advanced->System)

This filters the list of allowed currencies to show only selected ones

This PR replaces closed one #19946

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios (*)

  1. The list of currencies will look like in screenshot
    screenshot 2019-01-18 14 26 30

  2. These changes can be applied to 2.2.x as well

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@melaxon
downloadable product view layout fix (issue #20187)
8b089df 
1) This fixes only catalog product view layout of of downloadables.
The layout now is similar to simple or other types
2) Now the links are shown on frontend only if they sell separately or have samples. (Previously meaningless names of links also appeared)
3) Duplicate links title "Links" was removed as well.
The layout on wishlist and maybe somewhere else still pending
@melaxon
Shortening the list of currencies
ec8c973 
This will shorten the list of allowed currencies showing only installed currencies
(Replace closed pr#19946)
@magento-engcom-team
Copy link
Contributor

Hi @melaxon. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@melaxon
Copy link
Member Author

melaxon commented Jan 18, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @melaxon. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @melaxon, here is your new Magento instance.
Admin access: https://pr-20397.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-3947 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@sivaschenko
Copy link
Member

Hi @melaxon , thank you for the pull request. There is a commit that does not seem related to the pull request description: 8b089df Can you please remove it?

@ghost
Copy link

ghost commented Jan 29, 2019

Hi @melaxon, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sivaschenko sivaschenko reopened this Jan 29, 2019
@sivaschenko
Copy link
Member

Closed by mistake, sorry.

@orlangur orlangur self-assigned this Apr 4, 2019
@orlangur
Copy link
Contributor

orlangur commented Apr 4, 2019

Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened.
Thanks for collaboration!

@orlangur orlangur closed this Apr 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2019

Hi @melaxon, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@melaxon
Copy link
Member Author

melaxon commented Apr 4, 2019

Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened.
Thanks for collaboration!

Hello orlangur :)
Just curious if there was any activity expected from my side and I missed something?

@melaxon melaxon reopened this Apr 4, 2019
@ghost ghost unassigned orlangur and aleron75 Apr 4, 2019
@orlangur
Copy link
Contributor

orlangur commented Apr 4, 2019

@melaxon oh, you there :)

Please apply #20397 (comment) review note.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

@orlangur orlangur self-assigned this Apr 4, 2019
orlangur
orlangur requested changes Apr 6, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

@melaxon
Copy link
Member Author

melaxon commented Apr 8, 2019

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

Hello orlangur, hello aleron75!
I completely messed up my fork when playing around with it, so I'd rather close this PR and create new one. Fortunately there is not a big deal to commit. New PR is 22230 #22230

@melaxon melaxon closed this Apr 8, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 8, 2019

Hi @melaxon, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added a commit that referenced this pull request Apr 29, 2019
@magento-engcom-team
ENGCOM-4736: Shortening currency list in Configuration->General (repl…
33a18b0 
…ace PR #20397) #22230

 - Merge Pull Request #22230 from melaxon/magento2:currency_list
 - Merged commits:
   1. 0c1ffcd
magento-engcom-team pushed a commit that referenced this pull request Apr 29, 2019
@sivaschenko
ENGCOM-4736: Shortening currency list in Configuration->General (repl…
5c7ecce 
…ace PR #20397) #22230
magento-engcom-team added a commit that referenced this pull request May 3, 2019
@magento-engcom-team
ENGCOM-4857: [Backport] Shortening currency list in Configuration->Ge…
21b2d01 
…neral (replace PR #20397) #22551

 - Merge Pull Request #22551 from amol2jcommerce/magento2:2.2-develop-PR-port-22230
 - Merged commits:
   1. f54c202
magento-engcom-team pushed a commit that referenced this pull request May 3, 2019
@sidolov
ENGCOM-4857: [Backport] Shortening currency list in Configuration->Ge…
b7db604 
…neral (replace PR #20397) #22551
magento-engcom-team added a commit that referenced this pull request May 3, 2019
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.2-develop
744c318 
Accepted Public Pull Requests:
 - #22536: [Bakport] Adding product from wishlist not adding to cart showing warning message. (by @niravkrish)
 - #22551: [Backport] Shortening currency list in Configuration->General (replace PR #20397) (by @amol2jcommerce)
 - #22543: [Backport] [Fixed] Checkout Section: Shipping step is getting skipped when customer hitting direct payment step URL (by @saphaljha)
 - #22288: [BACKPORT] #222249 configurable product images wrong sorting fix (by @Wirson)


Fixed GitHub Issues:
 - #9155: Adding product from wishlist not adding to cart showing warning message. (reported by @KishorkumarKar) has been fixed in #22536 by @niravkrish in 2.2-develop branch
   Related commits:
     1. c62ab93
     2. 4402714

 - #21596: Checkout: it is possible to leave blank Shipping Details section and get to Payment Details section by URL (reported by @hiren0241) has been fixed in #22543 by @saphaljha in 2.2-develop branch
   Related commits:
     1. 9b9d451
     2. 6645cb2

 - #22249: Configurable Product Gallery Images Out of Order when More than 10 images (reported by @sjb9774) has been fixed in #22288 by @Wirson in 2.2-develop branch
   Related commits:
     1. f4ab0e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur requested changes

@aleron75 aleron75 aleron75 approved these changes

Assignees

@orlangur orlangur

Labels
Area: Frontend Component: Config Component: Downloadable Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@melaxon @magento-engcom-team @sivaschenko @orlangur @aleron75 @okorshenko @nmalevanec