Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terrain & buildings on tile borders: hidden parts of features when neighbor tiles have different zoom #11041

Closed
astojilj opened this issue Sep 21, 2021 · 0 comments
Closed

Terrain & buildings on tile borders: hidden parts of features when neighbor tiles have different zoom #11041

astojilj opened this issue Sep 21, 2021 · 0 comments
Assignees
@astojilj
Labels
bug 🐞

Comments

@astojilj
Copy link
Contributor

With map camera set like on the screenshot, toggle terrain.
Part of the building that is in tile 15-5238-12668 (above zoom level 16 tiles) is not visible.
The issue is not a recent regression, verified it exists with e.g. release 2.3.

Screen Shot 2021-09-21 at 9 47 04
@astojilj astojilj self-assigned this Sep 21, 2021
astojilj added a commit that referenced this issue Sep 29, 2021
@astojilj
Render test for #11041
6f87d9b
astojilj added a commit that referenced this issue Sep 30, 2021
@astojilj
Render tests for #11041
0925560
astojilj added a commit that referenced this issue Sep 30, 2021
@astojilj
Ignore #11041 render tests
1703585 
Ignore in gl-js before the fix.
astojilj added a commit that referenced this issue Sep 30, 2021
@astojilj
Render tests for #11041
d315a72
astojilj added a commit that referenced this issue Sep 30, 2021
@astojilj
Ignore #11041 render tests
cd698e6 
Ignore in gl-js before the fix.
@astojilj astojilj mentioned this issue Sep 30, 2021
Merged
karimnaaji pushed a commit that referenced this issue Oct 4, 2021
@astojilj
Render tests for #11041 (#11070)
d33f124 
* Render tests for #11041

* Ignore #11041 render tests

Ignore in gl-js before the fix.
katydecorah pushed a commit that referenced this issue Oct 20, 2021
Merge branch 'main' into docs-touch-pitch
dba85e8 
* main:
  Add touch pan blocker to gesture handling for touch devices (#11116)
  Address accessibility issues (#11064)
  add support for non-mercator projections (#11124)
  Image fallback expressions within paint properties (#11049)
  Replaces EPSG:4326 with OGC:CRS84 in GL JS `LngLat` doc (#11072)
  Add globe view support to heatmap shaders (#11120)
  Exclude flaky test (#11118)
  consistify YOUR_MAPBOX_ACCESS_TOKEN as placeholder string (#11113)
  Allow adding multiple layers to `map.on()` event handler (h/t @omerbn) (#11114)
  render-test-flakiness:clear worker storage (#11111)
  upgrade to supercluster v7.1.4, earcut v2.2.3, vt-pbf v3.1.3, geojson-rewind v0.5.1 (#11110)
  Added v1.13.2 changelog entry (#11108)
  One weird JSON.parse() trick (#11098)
  Fixed doc usage of map.getCenter (#11093)
  s̶y̶m̶b̶o̶l̶-̶c̶l̶i̶p̶ dynamic-filtering with `pitch` and `distance-from-camera` expressions (#10795)
  Update link to transpiling guide (#11096)
  Cherry pick 2.5.1 changelog (#11099)
  Fix an iOS15 issue where Safari tab bar interrupts panning (#11084)
  Fix conditional check for isFullscreen to accommodate Safari (#11086)
  Render tests for #11041 (#11070)
astojilj pushed a commit that referenced this issue Feb 18, 2022
Fix #11516: unecessary optimization approach disabled border intersec…
c02fda6 
…tion calculation for complex polygons: when enumerating polygon rings, if previous rings were outside bookkeeped aabb would prevent checking if edge crosses tile border and disable joining and displaying features split and asserting on check (in dev build).

Backporting fill extrusions on terrain #11041 fix from gl-native is related: when adjacent tiles are of different zooms, breaks or no building parts were visible.

Fixes: #11516, #11041
@astojilj astojilj mentioned this issue Feb 18, 2022
Merged
5 tasks
karimnaaji pushed a commit that referenced this issue Mar 8, 2022
@astojilj
Fix: #11516, #11041. Terrain: buildings on tile borders. (#11530)
3e64369 
* Fix #11516: unecessary optimization approach disabled border intersection calculation for complex polygons: when enumerating polygon rings, if previous rings were outside bookkeeped aabb would prevent checking if edge crosses tile border and disable joining and displaying features split and asserting on check (in dev build).
Backporting fill extrusions on terrain #11041 fix from gl-native is related: when adjacent tiles are of different zooms, breaks or no building parts were visible.

Fixes: #11516, #11041

* Enable flat-roof-over-border-of-different-zoom-zoomin render test

There is occasional flakiness on rendering fill color (zoom 16 evaluation is not seen on drape but zoom 15) and fill color is made constant to prevent it.

Co-authored-by: Aleksandar Stojiljković <aleksandar.stojijkovic@mapbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astojilj astojilj

Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@astojilj @karimnaaji @avpeery