Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade supercluster, earcut, vt-pbf, geojson-rewind #11110

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Upgrade supercluster, earcut, vt-pbf, geojson-rewind #11110

merged 1 commit into from
Oct 12, 2021

Conversation

mourner
Copy link
Member

@mourner mourner commented Oct 11, 2021

Upgrades:

  • supercluster to v7.1.4 which improves clustering memory footprint and fixes an issue where the same clusters had different cluster_id across zooms.
  • earcut to v2.2.3 which fixes a rare race condition that could cause an infinite loop.
  • vt-pbf to v3.1.3 which fixes an issue where null values where encoded as 'null' string, closes query*Features and MapMouseEvent.features returns a null feature property as "null" #8497.
  • geojson-rewind to v3.1.3 which shouldn't affect GL JS.

Launch Checklist

  • briefly describe the changes in this PR
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Improved memory footprint for clustering layers. Fixed an issue where the same clusters had different id across zoom levels. Fixed an issue where null values were exposed as 'null' strings when querying features.</changelog>

@mourner mourner requested a review from arindam1993 October 11, 2021 15:38
@arindam1993 arindam1993 merged commit 1c261a7 into main Oct 12, 2021
@arindam1993 arindam1993 deleted the mourner/upgrade-deps branch October 12, 2021 15:56
katydecorah pushed a commit that referenced this pull request Oct 20, 2021
Merge branch 'main' into docs-touch-pitch
dba85e8 
* main:
  Add touch pan blocker to gesture handling for touch devices (#11116)
  Address accessibility issues (#11064)
  add support for non-mercator projections (#11124)
  Image fallback expressions within paint properties (#11049)
  Replaces EPSG:4326 with OGC:CRS84 in GL JS `LngLat` doc (#11072)
  Add globe view support to heatmap shaders (#11120)
  Exclude flaky test (#11118)
  consistify YOUR_MAPBOX_ACCESS_TOKEN as placeholder string (#11113)
  Allow adding multiple layers to `map.on()` event handler (h/t @omerbn) (#11114)
  render-test-flakiness:clear worker storage (#11111)
  upgrade to supercluster v7.1.4, earcut v2.2.3, vt-pbf v3.1.3, geojson-rewind v0.5.1 (#11110)
  Added v1.13.2 changelog entry (#11108)
  One weird JSON.parse() trick (#11098)
  Fixed doc usage of map.getCenter (#11093)
  s̶y̶m̶b̶o̶l̶-̶c̶l̶i̶p̶ dynamic-filtering with `pitch` and `distance-from-camera` expressions (#10795)
  Update link to transpiling guide (#11096)
  Cherry pick 2.5.1 changelog (#11099)
  Fix an iOS15 issue where Safari tab bar interrupts panning (#11084)
  Fix conditional check for isFullscreen to accommodate Safari (#11086)
  Render tests for #11041 (#11070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arindam1993 arindam1993 arindam1993 approved these changes

Assignees
No one assigned
Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query*Features and MapMouseEvent.features returns a null feature property as "null"
2 participants
@mourner @arindam1993