Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed conditional for _isFullscreen to accommodate for Safari #11086

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fixed conditional for _isFullscreen to accommodate for Safari #11086

merged 1 commit into from
Oct 5, 2021

Conversation

avpeery
Copy link
Contributor

@avpeery avpeery commented Oct 5, 2021

This PR fixes a conditional check that didn't work in Safari. In the method "_isFullscreen" on the scrollZoomHandler, window.document.fullscreenElement evaluates to undefined instead of null in Safari. This change now handles checking fullscreenElement accurately in Safari as well.

Launch Checklist

  • briefly describe the changes in this PR
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'

@avpeery avpeery changed the title fixed conditional check for _isFullscreen to accomodate safari Fixed conditional for _isFullscreen to accommodate for Safari Oct 5, 2021
@avpeery avpeery requested review from mourner and rreusser October 5, 2021 16:12
@avpeery avpeery added the skip changelog Used for PRs that do not need a changelog entry label Oct 5, 2021
@avpeery avpeery requested a review from arindam1993 October 5, 2021 16:13
mourner
mourner approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry for missing that in my suggestion, looks like MDN should fix the docs because they explicitly mention null as the non-fullscreen state. Nice catch!

@avpeery avpeery merged commit c13e5ce into main Oct 5, 2021
@avpeery avpeery deleted the avpeery/gesture-handling-safari-fix branch October 5, 2021 17:20
katydecorah pushed a commit that referenced this pull request Oct 20, 2021
Merge branch 'main' into docs-touch-pitch
dba85e8 
* main:
  Add touch pan blocker to gesture handling for touch devices (#11116)
  Address accessibility issues (#11064)
  add support for non-mercator projections (#11124)
  Image fallback expressions within paint properties (#11049)
  Replaces EPSG:4326 with OGC:CRS84 in GL JS `LngLat` doc (#11072)
  Add globe view support to heatmap shaders (#11120)
  Exclude flaky test (#11118)
  consistify YOUR_MAPBOX_ACCESS_TOKEN as placeholder string (#11113)
  Allow adding multiple layers to `map.on()` event handler (h/t @omerbn) (#11114)
  render-test-flakiness:clear worker storage (#11111)
  upgrade to supercluster v7.1.4, earcut v2.2.3, vt-pbf v3.1.3, geojson-rewind v0.5.1 (#11110)
  Added v1.13.2 changelog entry (#11108)
  One weird JSON.parse() trick (#11098)
  Fixed doc usage of map.getCenter (#11093)
  s̶y̶m̶b̶o̶l̶-̶c̶l̶i̶p̶ dynamic-filtering with `pitch` and `distance-from-camera` expressions (#10795)
  Update link to transpiling guide (#11096)
  Cherry pick 2.5.1 changelog (#11099)
  Fix an iOS15 issue where Safari tab bar interrupts panning (#11084)
  Fix conditional check for isFullscreen to accommodate Safari (#11086)
  Render tests for #11041 (#11070)
@avpeery avpeery mentioned this pull request Mar 18, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

@rreusser rreusser Awaiting requested review from rreusser

@arindam1993 arindam1993 Awaiting requested review from arindam1993

Assignees
No one assigned
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avpeery @mourner