-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge from bot builder dev complete with history #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnector.Authentication and BotAuthenticationHanlder)
clean up interface definitions for middleware
Added in exception handling on public methods around parameters. General code cleanup and refactoring. Major changes coming in NEXT iteration with the removal of the crazy Dependepence Injection sytem that's there.
the JS version. Tests included.
with needed methods, and brought up to parity with JS changes.
…ft/BotBuilder-Dev into CLM-MessageStyler-CSharp
for AspNetCore, and changes to Auth model
Make Card version of alarmbot
* Added Typing Helper, and set the stage for more. * Added Delay Methods * Added Tests around extension methods to context. * Moved to Async per code review feedback
Add proactive sample
* Initial working set of MiddlwareSet and realted tests. Not yet integrated into the Bot. * Integration of Russian Doll Middleware. Migration to IBotContext in place of BotContext Migration to IActivity in place of Activity. * Tests and Bugfixes to enable MiddlwareSet to be composed. * Simplification to internal middleware next() code * Moved RunPipeline() from MiddlewareSet to Bot. * removed legacy middleware implementation * All Tests passing * Fixed missing Test attribute * Made Middleware example async * Makes AlarmBot Work * Updates to AlarmBot-Cards
* Removed IBotLogger interface, in favor of using standard Tracing. * Removed no-longer-existing Console Connector. Not sure how this previously compiled. * Removed no-longer-used class from previous Middleware Implementation * Removed ancient no-longer-needed file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.