Fix a bug causing sync to create many tiny chunks. #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Start full-service with an empty ledger and an empty wallet db 2) Import an account from entropy, giving it a first_block of 0 3) The ledger sync process will enter one block at a time into the ledger DB. The account sync process will then attempt to decode transactions from these blocks in very small chunks, of size 5-10 (instead of ten thousand), with no sleeping in between. Furthermore, the first account will do all of the syncing, not letting any other accounts sync at the same time. In order to fix this, the condition for reporting whether the sync thread can pause was updated to more elegantly handle this condition, by counting the number of blocks synced, and comparing it to the ideal chunk size.
briancorbin
approved these changes
Feb 16, 2022
briancorbin
added a commit
that referenced
this pull request
Mar 4, 2022
* adding max limit to some API endpoints (#248) * Remove unnecessary foreign keys from gift_codes table. (#249) * Update readme installation instructions (#250) * Enable foreign key constraints. Fix transient FK errors when deleting an account. (#251) * Remove foreign key check before running migrations. This allows databases with existing foreign key errors to be fixed by the migrations. (#252) * Fix a bug causing sync to create many tiny chunks. (#253) * Remove target block arg from manually sync account fn (#255) * Initial action to build containers for tag pushes (#256) * Supporting FOG enabled accounts (#254) * FOG Creds default to empty string if not provided from API (#257) * update readme (#259) * Api key guard (#205) * fixing issue with ledger not syncing automatically (#261) * sync up to the last block instead of excluding it (#262)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ledger DB. The account sync process will then attempt to decode
transactions from these blocks in very small chunks, of size 5-10
(instead of ten thousand), with no sleeping in between. Furthermore, the
first account will do all of the syncing, not letting any other accounts
sync at the same time.
In order to fix this, the condition for reporting whether the sync
thread can pause was updated to more elegantly handle this condition, by
counting the number of blocks synced, and comparing it to the ideal
chunk size.