Release/v1.5.0 #263
Merged
Release/v1.5.0 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improvements to MobCLI messages and documentation. * Remove external dependencies for command line client. * Clean up default full-service executable names in command line env vars. Add env var script and install script to setup.py. * Source the mobilecoin environment file after installing. * Work around a bug in the full-service status endpoint which misreports local_block_index. * Remove delay feature, which was reporting the tombstone block incorrectly. * Add --fee argument to mobcli send. * Put utility functions for address and receipt manipulation in their own module.
…hecking tombstone block validity. (#177)
* Optionally return tx_proposal with build_and_submit_transaction * Add assertion for build_and_submit_transaction when returning a tx_proposal * Encapsulate original build_and_submit_request logic, add two new methods instead to avoid breaking change * Remove params for build_and_submit_transaction_with_proposal from integration tests * Key name for tx_proposal in response changed * Debug CLI * Remove debug code
* bugfix for tx selection: prior to this change full-service would select the smallest TXOs, even though all previous checks look at the large ones * adding test * resetting to sort ascending and removing reversal when determining val * fixing flaky tests * updating tests * updating tests and fixing some flaky stuff * fixing flaky test * fixing a few more flaky tests * fixing flaky test * fixing bug (finally) * breaking up large test into multiple descriptive tests Co-authored-by: Brian <brian.william.corbin@gmail.com>
* Updating documentation * Adding change verification after scan to log_submitted test * Add test for big_int and self-send for transaction_log db
* Add an option to `mobcli export` to show entropy onscreen. * Clean up block-index vs block-height. A block index is the index number of a specific block. A block height is a count of a range of blocks. This was not consistent across the API and codebase. Change the API for account and ledger syncing to use block heights. This also fixes some bugs in sync reporting during offline mode. Update the command line client to handle the new API. Update the docs in API.md * GitBook: [feature/block-height] 4 pages modified * Remove legacy docs for database usage, now that gitbook has them. Clean up gitbook errors. * Remove legacy API.md. Remove spurious files created by gitbook. * Update usage of block_index in gitbook docs. * Rust formatting. Co-authored-by: Brian <brian.william.corbin@gmail.com>
* Add exit codes to indicate full-service process exit reason. * Rust formatting.
* can now claim gift codes to fog enabled addresses * Update full-service/src/service/gift_code.rs Fix documentation typo. Co-authored-by: Eran Rundstein <eran@rundste.in> * removed unnecessary functions and cleaned up code and added correct err Co-authored-by: itdaniher <itdaniher@gmail.com> Co-authored-by: Eran Rundstein <eran@rundste.in>
* WIP removing account_txo_statuses. * Create migration to add minted and received account id to txo table. * create_received, create_minted, update_to_pending * select_by_public_key * select_by_id * list_for_account * break up list_txos by type and status * WIP reenabling tests * txo service tests * transaction builder tests * receipt tests * WIP tests * WIP * WIP * WIP - list minted * cleaning up unused imports * removing txodetails fully * test get all txos * test_remove_account_from_txo * fix are_all_spent * fix delete unreferenced txos * fixing clippy issues * reproducing a known bug check receipt status is returning a transaction pending result when it should in fact return a failure to decrypt value for a receipt with a txo that is unowned by the checker * reimplementing and rewriting existing tests for transaction logs * removing account txo status * cargo fmt * determining correct status * WIP data migrations. * Fix a bug where spent txos are being selected for building a transaction. * Add data migrations. * Fix a query which incorrectly identified secreted txos for an account. * fixing comment issue * updating comment for receipt.rs bug * Clarify why get_balance_for_address cannot report orphaned balance. * refactored unwrapping and throwing error in receipt.rs Co-authored-by: Christian Oudard <christian.oudard@gmail.com>
* upreving mobilecoin library to current master * impl error handing for mc_util_serial::DecodeError * fixed TransactionBuilder memo field, removed unused crates * fixing test utils * remove mc-attest-core dep * update CI docker image * dep updates and cleanups * clippy fixes * whitespace Co-authored-by: Eran Rundstein <eran@rundste.in>
* update non-txo docs * comb remaining documentation * revert submodule hash change * clean up docs summary * revise docs structure, update README for stats Co-authored-by: Davey <davey@mobilecoin.com>
* Fix a bug in receipt status endpoint. Change the receipt status response to give FailedAmountDecryption when attempting to check a receipt for an account that does not have access to the txo in the receipt. Co-authored-by: Brian <brian.william.corbin@gmail.com>
* updating mobilecoin library and cargo lock * uprev again * updating to use new MINIMUM_FEE constant
* Update the builder imge reference, and the base image reference
* Add a performance benchmark for account syncing. Add configurable polling delays. Increase wait time for client test polling. * Sync optimization WIP * Sync WIP * Finish implementing tracking of spent txos. Fix sync control flow bugs. * Remove unused methods. * Nullify pneding_tombstone_block_index when updating a txo to spent. * removed num_workers from lvn sync code * readded tx logging for received transactions * readding subaddress to log_received and fixing warnings * making TODOs for remaining bits of things to add in * Remove num_workers from config, unittests, and docs. This argument is no longer needed with the change from threaded parallelism to Rayon. * WIP fixing unittests. * fixing tests related to syncing account and transaction logs * lint and fmt fixes * Adding error handling for B58Error into SyncError * get unspent key images not returns pending txo's as well as unspent * fixing test issues with new sync method * removing unnecessary wait_for_sync func from test_utils * readding (necessary) wait_for_sync function to test_utils * Added updating tx logs to succeeded and all tests passing * Added test case and implemented setting pending txos to unspent * adding last test case for updating tx log to failed * fixing lint issue * Put back starting the test server in CLI client tests. * Remove debug code. Co-authored-by: Christian Oudard <christian.oudard@gmail.com>
* change tombstone block default to 10 * revert changes to gitignore * use default const, linting fix * lint Co-authored-by: Brian <brian.william.corbin@gmail.com>
* adding max limit to some API endpoints * added limit to get_txos_for_account
Co-authored-by: Brian <brian.william.corbin@gmail.com>
…ases with existing foreign key errors to be fixed by the migrations. (#252)
* Fix a bug causing sync to create many tiny chunks. 1) Start full-service with an empty ledger and an empty wallet db 2) Import an account from entropy, giving it a first_block of 0 3) The ledger sync process will enter one block at a time into the ledger DB. The account sync process will then attempt to decode transactions from these blocks in very small chunks, of size 5-10 (instead of ten thousand), with no sleeping in between. Furthermore, the first account will do all of the syncing, not letting any other accounts sync at the same time. In order to fix this, the condition for reporting whether the sync thread can pause was updated to more elegantly handle this condition, by counting the number of blocks synced, and comparing it to the ideal chunk size.
* Initial action to build conatiners for tag pushes * Fix secret name for docker login
Co-authored-by: Colin Carey <colin.carey1@gmail.com>
* API Key Guard builds but tests do not fail when setting a non-matching MC_API_KEY, which should fail. * Api key header tentatively working - cargo test succeeds, export MC_API_KEY=shouldfail; cargo test fails. * Change apikeyerror to unauth, update docs * Add tests for api key * Use rocket state to manage api-key, add e2e tests * Remove bad merge changes Co-authored-by: Colin Carey <colin.carey1@gmail.com>
christian-oudard
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.