Supporting FOG enabled accounts #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancorbin
requested review from
christian-oudard,
david1alvarez and
Shramp
Shramp
reviewed
Feb 17, 2022
| @@ -114,6 +114,9 @@ pub enum JsonCommandRequest { | |||
| }, | |||
| create_account { | |||
| name: Option<String>, | |||
| fog_report_url: Option<String>, | |||
There was a problem hiding this comment.
no idea if this would be the rust way of doing things, but in TS I thought it was nice to keep the number of args passed into a fn down to ~<=3 and group similar arguments into a single object. For this fn, we could do:
fn create_account(name: string, fog_options: Option<FogOptions>) ...
struct FogOptions: {
fog_report_url: String,
fog_report_id: String,
fog_authority_spki: String,
}
Could do the same for AccountService.import_account, and import_account_from_legacy_root_entropy. Then we wouldn't have to pass in a bunch of nones when calling these functions for non-fog accounts.
what do you think?
There was a problem hiding this comment.
Nvm, after chatting and realizing that this would require an API change, let's not mess with it now
christian-oudard
pushed a commit
that referenced
this pull request
Feb 18, 2022
Co-authored-by: Colin Carey <colin.carey1@gmail.com>
briancorbin
added a commit
that referenced
this pull request
Mar 4, 2022
* adding max limit to some API endpoints (#248) * Remove unnecessary foreign keys from gift_codes table. (#249) * Update readme installation instructions (#250) * Enable foreign key constraints. Fix transient FK errors when deleting an account. (#251) * Remove foreign key check before running migrations. This allows databases with existing foreign key errors to be fixed by the migrations. (#252) * Fix a bug causing sync to create many tiny chunks. (#253) * Remove target block arg from manually sync account fn (#255) * Initial action to build containers for tag pushes (#256) * Supporting FOG enabled accounts (#254) * FOG Creds default to empty string if not provided from API (#257) * update readme (#259) * Api key guard (#205) * fixing issue with ledger not syncing automatically (#261) * sync up to the last block instead of excluding it (#262)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows accounts to be imported or created with FOG credentials. When that happens, a few things must happen to mimic how the mobile SDK works so that the accounts are compatible and all txos appear on on the mobile SDK.